Re: IMAP article move

["Bjørn Mork" <bmork@dod.no>]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

Simon Josefsson <jas@extundo.com> writes:

> What are you proposing?  There is some optimization in
> nnimap-request-move-article and nnimap-request-accept-article to make
> moving more efficient, and I thought it was pretty fast.  But I rarely
> copy/move articles, so I wouldn't know.  Maybe you could illustrate by
> comparing which IMAP commands are sent now, and which commands you
> want to be sent?

On a related issue: nnimap expiry with an expiry-target on the same
IMAP server is terribly slow.  To the degree that's entirely unusable.

I just got a new laptop and installed a fresh copy of CVS Gnus, and
that's when I noticed that this hasn't been fixed.  The attached patch
has fixed the problem for me on the old laptop (and now also on the
new one).

nnimap expiry will still be unecessarily slow with other expiry-
targets, but I don't know how to fix that.



Bjørn
-- 
How can you say that you wish you were a mental problem?  


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: nnimap-fix.patch --]
[-- Type: text/x-patch, Size: 1763 bytes --]

Index: lisp/nnimap.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v
retrieving revision 7.13
diff -u -u -r7.13 nnimap.el
--- lisp/nnimap.el	26 Oct 2004 17:40:05 -0000	7.13
+++ lisp/nnimap.el	11 Jan 2005 08:53:24 -0000
@@ -1452,14 +1452,23 @@
 
 (defun nnimap-expiry-target (arts group server)
   (unless (eq nnmail-expiry-target 'delete)
-    (with-temp-buffer
-      (dolist (art arts)
-	(nnimap-request-article art group server (current-buffer))
-	;; hints for optimization in `nnimap-request-accept-article'
-	(let ((nnimap-current-move-article art)
-	      (nnimap-current-move-group group)
-	      (nnimap-current-move-server server))
-	  (nnmail-expiry-target-group nnmail-expiry-target group))))
+    (if (and (not (functionp nnmail-expiry-target)) 
+	     (gnus-server-equal (gnus-group-method nnmail-expiry-target) 
+				(gnus-server-to-method 
+				 (format "nnimap:%s" server))))
+	;; moving article within same server, speed it up...
+	(and (nnimap-possibly-change-group group)
+	     (imap-message-copy (imap-range-to-message-set arts)
+				(gnus-group-short-name nnmail-expiry-target) 
+				'dontcreate nil nnimap-server-buffer))
+      (with-temp-buffer
+	(dolist (art arts)
+	  (nnimap-request-article art group server (current-buffer))
+	  ;; hints for optimization in `nnimap-request-accept-article'
+	  (let ((nnimap-current-move-article art)
+		(nnimap-current-move-group group)
+		(nnimap-current-move-server server))
+	    (nnmail-expiry-target-group nnmail-expiry-target group)))))
     ;; It is not clear if `nnmail-expiry-target' somehow cause the
     ;; current group to be changed or not, so we make sure here.
     (nnimap-possibly-change-group group server)))