* Re: CVS update of gnus/lisp (ChangeLog gnus-sum.el)
[not found] <E1CQv51-00070O-00@quimby.gnus.org>
@ 2004-11-11 18:18 ` Arne Jørgensen
2004-11-14 22:12 ` Jesper Harder
0 siblings, 1 reply; 7+ messages in thread
From: Arne Jørgensen @ 2004-11-11 18:18 UTC (permalink / raw)
"Jesper Harder" <harder@ifa.au.dk> writes:
> Date: Sunday, November 7, 2004 @ 23:00:11
> Author: cvs
> Path: /usr/local/cvsroot/gnus/lisp
>
> Modified: ChangeLog gnus-sum.el
>
> (gnus-summary-clear-local-variables): Use symbolp.
> From Stefan Wiens <s.wi@gmx.net>.
>
>
> -------------+
> ChangeLog | 5 +++++
> gnus-sum.el | 4 ++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
As a side(?) effect of this change my `gnus-summary-expunge-below'
gets reset to nil every time I have visited a summary buffer.
Is this the intended behaviour? How do I give it a global value then?
Kind regards,
--
Arne Jørgensen
Gammel Kongevej 7, 1. th., DK-1610 Copenhagen V, Denmark
mobile: +45 21 65 01 13
email: arne@arnested.dk, <http://arnested.dk/>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CVS update of gnus/lisp (ChangeLog gnus-sum.el)
2004-11-11 18:18 ` CVS update of gnus/lisp (ChangeLog gnus-sum.el) Arne Jørgensen
@ 2004-11-14 22:12 ` Jesper Harder
2004-11-15 11:06 ` Arne Jørgensen
2004-11-16 18:23 ` Romain Francoise
0 siblings, 2 replies; 7+ messages in thread
From: Jesper Harder @ 2004-11-14 22:12 UTC (permalink / raw)
Arne Jørgensen <arne@arnested.dk> writes:
> "Jesper Harder" <harder@ifa.au.dk> writes:
>
>> (gnus-summary-clear-local-variables): Use symbolp.
>> From Stefan Wiens <s.wi@gmx.net>.
>
> As a side(?) effect of this change my `gnus-summary-expunge-below'
> gets reset to nil every time I have visited a summary buffer.
>
> Is this the intended behaviour? How do I give it a global value
> then?
I guess it is, see below:
`gnus-summary-expunge-below'
Don't display the summary lines of articles that have scores lower
than this variable. This is `nil' by default, which means that no
articles will be hidden. This variable is local to the summary
buffers, and has to be set from `gnus-summary-mode-hook'.
--
Jesper Harder <http://purl.org/harder/>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CVS update of gnus/lisp (ChangeLog gnus-sum.el)
2004-11-14 22:12 ` Jesper Harder
@ 2004-11-15 11:06 ` Arne Jørgensen
2004-11-16 18:23 ` Romain Francoise
1 sibling, 0 replies; 7+ messages in thread
From: Arne Jørgensen @ 2004-11-15 11:06 UTC (permalink / raw)
Jesper Harder <harder@ifa.au.dk> writes:
> I guess it is, see below:
>
> `gnus-summary-expunge-below'
> Don't display the summary lines of articles that have scores lower
> than this variable. This is `nil' by default, which means that no
> articles will be hidden. This variable is local to the summary
> buffers, and has to be set from `gnus-summary-mode-hook'.
Thanks.
Kind regards,
--
Arne Jørgensen
Gammel Kongevej 7, 1. th., DK-1610 Copenhagen V, Denmark
mobile: +45 21 65 01 13
email: arne@arnested.dk, <http://arnested.dk/>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CVS update of gnus/lisp (ChangeLog gnus-sum.el)
2004-11-14 22:12 ` Jesper Harder
2004-11-15 11:06 ` Arne Jørgensen
@ 2004-11-16 18:23 ` Romain Francoise
2004-12-09 14:31 ` Katsumi Yamaoka
1 sibling, 1 reply; 7+ messages in thread
From: Romain Francoise @ 2004-11-16 18:23 UTC (permalink / raw)
Jesper Harder <harder@ifa.au.dk> writes:
>> As a side(?) effect of this change my `gnus-summary-expunge-below'
>> gets reset to nil every time I have visited a summary buffer.
>>
>> Is this the intended behaviour? How do I give it a global value
>> then?
> I guess it is, see below:
> `gnus-summary-expunge-below'
> Don't display the summary lines of articles that have scores lower
> than this variable. This is `nil' by default, which means that no
> articles will be hidden. This variable is local to the summary
> buffers, and has to be set from `gnus-summary-mode-hook'.
This is wrong. Why then would there be a defcustom for it?
In gnus-sum you will see that some local variables get their value from
global values (cons cells who have a 'global cdr), and your change has
the side effect of making all global values be cleared on summary exit,
losing the customization. This is also why articles with a negative
score are no longer marked as read: gnus-summary-mark-below gets reset
to nil from its default value of zero.
I suggest the following patch which fixes both problems: it removes the
"also clear global values" part, which in fact never worked since global
variable were apparently not reset.
(It may be fuzzy, I have other changes in gnus-sum.el.)
Index: gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 7.66
diff -u -r7.66 gnus-sum.el
--- gnus-sum.el 7 Nov 2004 22:00:10 -0000 7.66
+++ gnus-sum.el 16 Nov 2004 18:18:30 -0000
@@ -6704,12 +6718,6 @@
(gnus-summary-clear-local-variables))
(when (get-buffer gnus-article-buffer)
(bury-buffer gnus-article-buffer))
- ;; We clear the global counterparts of the buffer-local
- ;; variables as well, just to be on the safe side.
- (set-buffer gnus-group-buffer)
- (gnus-summary-clear-local-variables)
- (let ((gnus-summary-local-variables gnus-newsgroup-variables))
- (gnus-summary-clear-local-variables))
;; Return to group mode buffer.
(when (eq mode 'gnus-summary-mode)
(gnus-kill-buffer buf)))
--
Romain Francoise <romain@orebokech.com> | There's no stronger wind than
it's a miracle -- http://orebokech.com/ | the one that blows down a
| lonesome railroad line.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CVS update of gnus/lisp (ChangeLog gnus-sum.el)
2004-11-16 18:23 ` Romain Francoise
@ 2004-12-09 14:31 ` Katsumi Yamaoka
2004-12-09 23:59 ` Arnaud Giersch
0 siblings, 1 reply; 7+ messages in thread
From: Katsumi Yamaoka @ 2004-12-09 14:31 UTC (permalink / raw)
Cc: semi-gnus-ja
>>>>> In <87is85tzyg.fsf@orebokech.com>
>>>>> Romain Francoise <romain@orebokech.com> wrote:
> I suggest the following patch which fixes both problems: it removes the
> "also clear global values" part, which in fact never worked since global
> variable were apparently not reset.
> (It may be fuzzy, I have other changes in gnus-sum.el.)
> Index: gnus-sum.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
> retrieving revision 7.66
> diff -u -r7.66 gnus-sum.el
> --- gnus-sum.el 7 Nov 2004 22:00:10 -0000 7.66
> +++ gnus-sum.el 16 Nov 2004 18:18:30 -0000
> @@ -6704,12 +6718,6 @@
> (gnus-summary-clear-local-variables))
> (when (get-buffer gnus-article-buffer)
> (bury-buffer gnus-article-buffer))
> - ;; We clear the global counterparts of the buffer-local
> - ;; variables as well, just to be on the safe side.
> - (set-buffer gnus-group-buffer)
> - (gnus-summary-clear-local-variables)
> - (let ((gnus-summary-local-variables gnus-newsgroup-variables))
> - (gnus-summary-clear-local-variables))
> ;; Return to group mode buffer.
> (when (eq mode 'gnus-summary-mode)
> (gnus-kill-buffer buf)))
NAKAJI Hiroyuki also confirmed that your patch does the trick.
I've applied it. Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CVS update of gnus/lisp (ChangeLog gnus-sum.el)
2004-12-09 14:31 ` Katsumi Yamaoka
@ 2004-12-09 23:59 ` Arnaud Giersch
2004-12-10 0:11 ` Katsumi Yamaoka
0 siblings, 1 reply; 7+ messages in thread
From: Arnaud Giersch @ 2004-12-09 23:59 UTC (permalink / raw)
Jeudi le 09 décembre 2004, vers 15:31:28 (CET), Katsumi Yamaoka a
écrit:
>> --- gnus-sum.el 7 Nov 2004 22:00:10 -0000 7.66
>> +++ gnus-sum.el 16 Nov 2004 18:18:30 -0000
>> @@ -6704,12 +6718,6 @@
>> (gnus-summary-clear-local-variables))
>> (when (get-buffer gnus-article-buffer)
>> (bury-buffer gnus-article-buffer))
>> - ;; We clear the global counterparts of the buffer-local
>> - ;; variables as well, just to be on the safe side.
>> - (set-buffer gnus-group-buffer)
>> - (gnus-summary-clear-local-variables)
>> - (let ((gnus-summary-local-variables gnus-newsgroup-variables))
>> - (gnus-summary-clear-local-variables))
>> ;; Return to group mode buffer.
>> (when (eq mode 'gnus-summary-mode)
>> (gnus-kill-buffer buf)))
>
> NAKAJI Hiroyuki also confirmed that your patch does the trick.
> I've applied it. Thanks.
Hello,
This patch was not complete: the same lines should also be removed
from function gnus-summary-exit-no-update that is just below in
"gnus-sum.el".
--
Arnaud
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CVS update of gnus/lisp (ChangeLog gnus-sum.el)
2004-12-09 23:59 ` Arnaud Giersch
@ 2004-12-10 0:11 ` Katsumi Yamaoka
0 siblings, 0 replies; 7+ messages in thread
From: Katsumi Yamaoka @ 2004-12-10 0:11 UTC (permalink / raw)
Cc: ding
>>>>> In <87mzwn81lp.fsf@groumpf.homeip.net> Arnaud Giersch wrote:
>>> --- gnus-sum.el 7 Nov 2004 22:00:10 -0000 7.66
>>> +++ gnus-sum.el 16 Nov 2004 18:18:30 -0000
>>> - (set-buffer gnus-group-buffer)
>>> - (gnus-summary-clear-local-variables)
>>> - (let ((gnus-summary-local-variables gnus-newsgroup-variables))
>>> - (gnus-summary-clear-local-variables))
> This patch was not complete: the same lines should also be removed
>>From function gnus-summary-exit-no-update that is just below in
> "gnus-sum.el".
I've committed it. Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2004-12-10 0:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1CQv51-00070O-00@quimby.gnus.org>
2004-11-11 18:18 ` CVS update of gnus/lisp (ChangeLog gnus-sum.el) Arne Jørgensen
2004-11-14 22:12 ` Jesper Harder
2004-11-15 11:06 ` Arne Jørgensen
2004-11-16 18:23 ` Romain Francoise
2004-12-09 14:31 ` Katsumi Yamaoka
2004-12-09 23:59 ` Arnaud Giersch
2004-12-10 0:11 ` Katsumi Yamaoka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).