Re: Problems with IMAP-over-ssl mail source.

[Gaute B Strokkenes <biggaute@uwc.net>]

On 25 aug 2003, biggaute@uwc.net wrote:

> Consider the following snippet from mail-source-fetch-imap:
>
> (let* ((from (format "%s:%s:%s" server user port))
> 	   (found 0)
> 	   (buffer-name " *imap source*")
> 	   (buf (get-buffer-create (generate-new-buffer-name buffer-name)))
> 	   (mail-source-string (format "imap:%s:%s" server mailbox))
> 	   (imap-shell-program (or (list program) imap-shell-program))
> 	   remove)
> (if (and (imap-open server port stream authentication buffer-name)
> 	       (imap-authenticate
> 		user (or (cdr (assoc from mail-source-password-cache))
> 			 password) buf)
> 	       (imap-mailbox-select mailbox nil buf))
>
> The problem appear to be that the " *imap source*" buffer is not
> deleted when I interrupt a fetching session.  Then, the next time
> this code is called, generate-new-buffer-name ensures that `buf' is
> a new buffer called " *imap source*<1>".  However, when imap-open is
> called it is passed buffer-name which is still set to " *imap
> source", causing imap-open to operate on the wrong temporary buffer.

And the obvious fix is:

Index: lisp/mail-source.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mail-source.el,v
retrieving revision 6.38
diff -u -r6.38 mail-source.el
--- lisp/mail-source.el	14 Jul 2003 08:03:13 -0000	6.38
+++ lisp/mail-source.el	25 Aug 2003 20:51:52 -0000
@@ -968,12 +968,11 @@
   (mail-source-bind (imap source)
     (let* ((from (format "%s:%s:%s" server user port))
 	   (found 0)
-	   (buffer-name " *imap source*")
-	   (buf (get-buffer-create (generate-new-buffer-name buffer-name)))
+	   (buf (generate-new-buffer " *imap source*"))
 	   (mail-source-string (format "imap:%s:%s" server mailbox))
 	   (imap-shell-program (or (list program) imap-shell-program))
 	   remove)
-      (if (and (imap-open server port stream authentication buffer-name)
+      (if (and (imap-open server port stream authentication buf)
 	       (imap-authenticate
 		user (or (cdr (assoc from mail-source-password-cache))
 			 password) buf)

But I'm not sure that this is the best way to fix things.  Is it
correct to leave a " *imap source*" buffer lying about if
mail-source-fetch-imap is interupted?  Would it be better to reuse it
than to create a new one?

Lastly, this bug was introduced by Lars in mid-March:

 revision 6.33
 date: 2003/03/17 14:20:35;  author: larsi;  state: Exp;  lines: +8 -7
 * mail-source.el (mail-source-fetch-imap): Pass buffer-name to
 imap-open.

I've been unable to find discussion of why this change was made on the
ding list, though presumably there is some reason for it.  Lars?

-- 
Gaute Strokkenes                        http://www.srcf.ucam.org/~gs234/
The PINK SOCKS were ORIGINALLY from 1952!!
 But they went to MARS around 1953!!