From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/47560
Path: main.gmane.org!not-for-mail
From: John Paul Wallington <jpw@shootybangbang.com>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: Cannot open load file: tool-bar
Date: Tue, 05 Nov 2002 20:49:09 +0000
Sender: owner-ding@hpc.uh.edu
Message-ID: <87n0onivy2.fsf@bundalo.shootybangbang.com>
References: <th021103171587adkq1vev.fsf@demonium.de> <847kfu5w3g.fsf@crybaby.uni-duisburg.de>
 <th021104105987bs55zmdh.fsf@demonium.de>
 <84y989mott.fsf@crybaby.uni-duisburg.de>
 <th021104175287d6pl2s62.fsf@demonium.de>
 <84iszdqc5h.fsf@crybaby.uni-duisburg.de>
 <th021104231187znsp0yu2.fsf@demonium.de>
 <84n0oompug.fsf@crybaby.uni-duisburg.de>
 <th021105122387bs54qmz5.fsf@demonium.de>
 <841y60exlw.fsf@crybaby.uni-duisburg.de>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Trace: main.gmane.org 1036529227 27818 80.91.224.249 (5 Nov 2002 20:47:07 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Tue, 5 Nov 2002 20:47:07 +0000 (UTC)
Return-path: <owner-ding@hpc.uh.edu>
Original-Received: from malifon.math.uh.edu ([129.7.128.13])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 189AbF-0007Di-00
	for <ding-account@gmane.org>; Tue, 05 Nov 2002 21:47:01 +0100
Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists)
	by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
	id 189AYk-0007Lv-00; Tue, 05 Nov 2002 14:44:26 -0600
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 05 Nov 2002 14:45:10 -0600 (CST)
Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66])
	by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id OAA07101
	for <ding@hpc.uh.edu>; Tue, 5 Nov 2002 14:44:50 -0600 (CST)
Original-Received: (qmail 28664 invoked by alias); 5 Nov 2002 20:43:51 -0000
Original-Received: (qmail 28659 invoked from network); 5 Nov 2002 20:43:51 -0000
Original-Received: from main.gmane.org (80.91.224.249)
  by gnus.org with SMTP; 5 Nov 2002 20:43:51 -0000
Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 189AVx-0006YG-00
	for <ding@gnus.org>; Tue, 05 Nov 2002 21:41:33 +0100
Original-To: ding@gnus.org
X-Injected-Via-Gmane: http://gmane.org/
Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 189AVc-0006XG-00
	for <gmane-emacs-ding@m.gmane.org>; Tue, 05 Nov 2002 21:41:12 +0100
Original-Path: 127.0.0.1!nobody
Original-Lines: 24
Original-NNTP-Posting-Host: modem-983.stoked.dialup.pol.co.uk
Original-X-Trace: main.gmane.org 1036528872 25112 62.25.191.215 (5 Nov 2002 20:41:12 GMT)
Original-X-Complaints-To: usenet@main.gmane.org
Original-NNTP-Posting-Date: Tue, 5 Nov 2002 20:41:12 +0000 (UTC)
X-Attribution: jpw
X-Face: R(_z-<e!Z,qjN8xeu/^:Szs}15R'D_9}g7Qlm0x+2sF<`w9o]-oT>rF:grdKO.*u`n);p.i
 $Eiz=h^CO5eDYv"4:K@#\HN09*Ykx}}B{kF/KH}%f_o^Wp<kb`,1KLtZp"^C{-{e~S=IP0_"8B6K+C
 kbKw='FSzftzu
User-Agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.3.50
 (i686-pc-linux-gnu)
Cancel-Lock: sha1:8GsB1zI453SmNEJ1CH2/fMUdcYY=
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:47560
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:47560

kai.grossjohann@uni-duisburg.de (Kai Großjohann) wrote:

> Hm.  Now that you mention it...  See this code:
>
> /----
> | ;; Emacs 21 tool bar.  Should be no-op otherwise.
> | (defun gnus-group-make-tool-bar ()
> |   (if (and 
> |        (condition-case nil (require 'tool-bar) (error nil))
> |        (fboundp 'tool-bar-add-item-from-menu)
> \----
>
> It comes from gnus-group.el.  As you can see, it tries to load the
> file, ignoring errors, and if that fails it skips the code that only
> works for Emacs 21.
>
> So, what can we do?

The (condition-case nil (require 'tool-bar) (error nil)) is unnecessary
because `tool-bar-add-item-from-menu' is autoloaded and therefore
fbound (at least in RC and HEAD, untested in 21.1/2).

-- 
John Paul Wallington