Can't select group created by copying

Can't select group created by copying

[Jon K Hellan]

Here's a problem I found. I am not sure how to deal with it.

When I create a new group by copying a message into it, I can't
enter that group until gnus has been restarted.

This happens with the nnimap backend, but from my meagre understanding
of the code, it doesn't look like a backend issue.

I use B c - gnus-summary-copy-article, and enter the name of a group
that does not exist. When prompted, I confirm that I want to create
it.

gnus-read-move-group-name creates the group, and activates it. Of
course, it is empty, and this is what (gnus-active <group-name>) will
report from now on.

When I subscribe the group in the Group buffer, and try to select it, the
active info is never updated. So gnus believes that it is still empty,
and refuses to enter it. "Can't select group".

So - when should the active info have been updated?

Jon

Re: Can't select group created by copying

[Jon K Hellan]

Jon K Hellan <Jon.K.Hellan@item.ntnu.no> writes:

> Here's a problem I found. I am not sure how to deal with it.
> 
> When I create a new group by copying a message into it, I can't
> enter that group until gnus has been restarted.
> 
> This happens with the nnimap backend, but from my meagre understanding
> of the code, it doesn't look like a backend issue.
> 
> I use B c - gnus-summary-copy-article, and enter the name of a group
> that does not exist. When prompted, I confirm that I want to create
> it.
> 
> gnus-read-move-group-name creates the group, and activates it. Of
> course, it is empty, and this is what (gnus-active <group-name>) will
> report from now on.
> 
> When I subscribe the group in the Group buffer, and try to select it, the
> active info is never updated. So gnus believes that it is still empty,
> and refuses to enter it. "Can't select group".
> 
> So - when should the active info have been updated?
> 
> Jon

Have investigated further.

There is code to update the group that has been moved to in
gnus-summary-move-article,  gnus-sum.el, around l 7280.

	(let* ((pto-group (gnus-group-prefixed-name
			   (car art-group) to-method))
==>	       (entry
		(gnus-gethash pto-group gnus-newsrc-hashtb))
	       (info (nth 2 entry))
               (to-group (gnus-info-group info))
	       to-marks)
	  ;; Update the group that has been moved to.
	  (when (and info
		     (memq action '(move copy)))
	    (unless (member to-group to-groups)
	      (push to-group to-groups))

But entry is nil for the newly created group, so do not find a
to-group.

Both nnfolder and nnimap do this.

Jon

Re: Can't select group created by copying

[Simon Josefsson]

Jon K Hellan <Jon.K.Hellan@item.ntnu.no> writes:

> Have investigated further.
> 
> There is code to update the group that has been moved to in
> gnus-summary-move-article,  gnus-sum.el, around l 7280.
> 
> 	(let* ((pto-group (gnus-group-prefixed-name
> 			   (car art-group) to-method))
> ==>	       (entry
> 		(gnus-gethash pto-group gnus-newsrc-hashtb))
> 	       (info (nth 2 entry))
>                (to-group (gnus-info-group info))
> 	       to-marks)
> 	  ;; Update the group that has been moved to.
> 	  (when (and info
> 		     (memq action '(move copy)))
> 	    (unless (member to-group to-groups)
> 	      (push to-group to-groups))
> 
> But entry is nil for the newly created group, so do not find a
> to-group.

Ah, yes. Have a look at the select method on the newly created group
(`G E' in the group buffer). My bet it says (nnimap "foo") when it
should've been either "nnimap:foo" or (nnimap "foo" (nnimap-address
...)).

Either way, does this patch help?

1999-07-07  Simon Josefsson  <jas@pdc.kth.se>

	* gnus-sum.el (gnus-summary-move-article): Better method search.

--- gnus-sum.el.DIST	Wed Jul  7 21:12:50 1999
+++ gnus-sum.el	Wed Jul  7 21:13:22 1999
@@ -7200,7 +7200,7 @@
 	     articles prefix))
       (set (intern (format "gnus-current-%s-group" action)) to-newsgroup))
     (setq to-method (or select-method
-			(gnus-group-name-to-method to-newsgroup)))
+			(gnus-find-method-for-group to-newsgroup)))
     ;; Check the method we are to move this article to...
     (unless (gnus-check-backend-function
 	     'request-accept-article (car to-method))

Re: Can't select group created by copying

[Jon K Hellan]

Simon Josefsson <jas@pdc.kth.se> writes:

> Ah, yes. Have a look at the select method on the newly created group
> (`G E' in the group buffer). My bet it says (nnimap "foo") when it
> should've been either "nnimap:foo" or (nnimap "foo" (nnimap-address
> ...)).

("nnimap+parus:r1239" 3 nil nil "parus")

> 
> Either way, does this patch help?

> -			(gnus-group-name-to-method to-newsgroup)))
> +			(gnus-find-method-for-group to-newsgroup)))

No, we get "nntp does not support article copying".

Jon Kåre

Re: Can't select group created by copying

[Jon K Hellan]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

Here is my original problem:

> When I create a new group by copying a message into it, I can't
> select that group unless I do M-g (gnus-group-get-new-news-this-group).

> I use B c - gnus-summary-copy-article, and enter the name of a group
> that does not exist. When prompted, I confirm that I want to create
> it.

> gnus-read-move-group-name creates the group, and activates it. Of
> course, it is empty, and this is what (gnus-active <group-name>) will
> report from now on.

> When I subscribe the group in the Group buffer, and try to select it, the
> active info is never updated. So gnus believes that it is still empty,
> and refuses to enter it. "Can't select group".

I considered a few other solutions

1. Don't activate group when creating it.

2. Refresh active info of newly created groups in gnus-summary-move-article

3. Refresh active info when changing group level or selecting an
   ephemeral group.

2 seems to be most consistent with the current design - not that I
understand it well. Here is a patch. Is it OK?

It makes a separate list of copy destinations which do not have info,
and updates their active info.

Jon

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dr5 --]
[-- Type: text/patch, Size: 3209 bytes --]

Here is my original problem:

> When I create a new group by copying a message into it, I can't
> select that group unless I do M-g (gnus-group-get-new-news-this-group).

> I use B c - gnus-summary-copy-article, and enter the name of a group
> that does not exist. When prompted, I confirm that I want to create
> it.

> gnus-read-move-group-name creates the group, and activates it. Of
> course, it is empty, and this is what (gnus-active <group-name>) will
> report from now on.

> When I subscribe the group in the Group buffer, and try to select it, the
> active info is never updated. So gnus believes that it is still empty,
> and refuses to enter it. "Can't select group".

I considered a few other solutions

1. Don't activate group when creating it.

2. Refresh active info of newly created groups in gnus-summary-move-article

3. Refresh active info when changing group level or selecting an
   ephemeral group.

2 seems to be most consistent with the current design - not that I
understand it well. Here is a patch. Is it OK?

It makes a separate list of copy destinations which do not have info,
and updates their active info.


*** /home/jk/pgnus-0.93/lisp/gnus-sum.el	Thu Jul  8 13:31:21 1999
--- /home/jk/pgnus-jk/lisp/gnus-sum.el	Thu Jul  8 13:31:21 1999
***************
*** 7185,7191 ****
  		 (crosspost "Crosspost" "Crossposting")))
  	(copy-buf (save-excursion
  		    (nnheader-set-temp-buffer " *copy article*")))
! 	art-group to-method new-xref article to-groups)
      (unless (assq action names)
        (error "Unknown action %s" action))
      ;; Read the newsgroup name.
--- 7185,7191 ----
  		 (crosspost "Crosspost" "Crossposting")))
  	(copy-buf (save-excursion
  		    (nnheader-set-temp-buffer " *copy article*")))
!  	art-group to-method new-xref article to-groups new-groups)
      (unless (assq action names)
        (error "Unknown action %s" action))
      ;; Read the newsgroup name.
***************
*** 7280,7290 ****
                 (to-group (gnus-info-group info))
  	       to-marks)
  	  ;; Update the group that has been moved to.
  	  (when (and info
  		     (memq action '(move copy)))
- 	    (unless (member to-group to-groups)
- 	      (push to-group to-groups))
- 
  	    (unless (memq article gnus-newsgroup-unreads)
  	      (push 'read to-marks)
  	      (gnus-info-set-read
--- 7280,7294 ----
                 (to-group (gnus-info-group info))
  	       to-marks)
  	  ;; Update the group that has been moved to.
+ 	  (when (memq action '(move copy))
+ 	    (if info
+ 		(unless (member to-group to-groups)
+ 		  (push to-group to-groups))
+ 	      (unless (member pto-group new-groups)
+ 		(push pto-group new-groups))))
+ 
  	  (when (and info
  		     (memq action '(move copy)))
  	    (unless (memq article gnus-newsgroup-unreads)
  	      (push 'read to-marks)
  	      (gnus-info-set-read
***************
*** 7361,7366 ****
--- 7365,7373 ----
  	(when (gnus-group-goto-group (car to-groups) t)
  	  (gnus-group-get-new-news-this-group 1 t))
  	(pop to-groups)))
+ 
+     (while new-groups		; Update active info
+ 	(gnus-activate-group (pop new-groups) nil nil to-method))
  
      (gnus-kill-buffer copy-buf)
      (gnus-summary-position-point)

Re: Can't select group created by copying

[Jon K Hellan]

Trying again

When I read my previous message from the
"nntp+sunsite.auc.dk:emacs.ding" archive, I get 
"Wrong number of arguments: #<subr assoc>" when I try to open the
attachment.

So here we go again

Here is my original problem:

> When I create a new group by copying a message into it, I can't
> select that group unless I do M-g (gnus-group-get-new-news-this-group).

> I use B c - gnus-summary-copy-article, and enter the name of a group
> that does not exist. When prompted, I confirm that I want to create
> it.

> gnus-read-move-group-name creates the group, and activates it. Of
> course, it is empty, and this is what (gnus-active <group-name>) will
> report from now on.

> When I subscribe the group in the Group buffer, and try to select it, the
> active info is never updated. So gnus believes that it is still empty,
> and refuses to enter it. "Can't select group".

I considered a few other solutions

1. Don't activate group when creating it.

2. Refresh active info of newly created groups in gnus-summary-move-article

3. Refresh active info when changing group level or selecting an
   ephemeral group.

2 seems to be most consistent with the current design - not that I
understand it well. Here is a patch. Is it OK?

It makes a separate list of copy destinations which do not have info,
and updates their active info.

--

Jon

--
Here is my original problem:

> When I create a new group by copying a message into it, I can't
> select that group unless I do M-g (gnus-group-get-new-news-this-group).

> I use B c - gnus-summary-copy-article, and enter the name of a group
> that does not exist. When prompted, I confirm that I want to create
> it.

> gnus-read-move-group-name creates the group, and activates it. Of
> course, it is empty, and this is what (gnus-active <group-name>) will
> report from now on.

> When I subscribe the group in the Group buffer, and try to select it, the
> active info is never updated. So gnus believes that it is still empty,
> and refuses to enter it. "Can't select group".

I considered a few other solutions

1. Don't activate group when creating it.

2. Refresh active info of newly created groups in gnus-summary-move-article

3. Refresh active info when changing group level or selecting an
   ephemeral group.

2 seems to be most consistent with the current design - not that I
understand it well. Here is a patch. Is it OK?

It makes a separate list of copy destinations which do not have info,
and updates their active info.


*** /home/jk/pgnus-0.93/lisp/gnus-sum.el	Thu Jul  8 13:31:21 1999
--- /home/jk/pgnus-jk/lisp/gnus-sum.el	Thu Jul  8 13:31:21 1999
***************
*** 7185,7191 ****
  		 (crosspost "Crosspost" "Crossposting")))
  	(copy-buf (save-excursion
  		    (nnheader-set-temp-buffer " *copy article*")))
! 	art-group to-method new-xref article to-groups)
      (unless (assq action names)
        (error "Unknown action %s" action))
      ;; Read the newsgroup name.
--- 7185,7191 ----
  		 (crosspost "Crosspost" "Crossposting")))
  	(copy-buf (save-excursion
  		    (nnheader-set-temp-buffer " *copy article*")))
!  	art-group to-method new-xref article to-groups new-groups)
      (unless (assq action names)
        (error "Unknown action %s" action))
      ;; Read the newsgroup name.
***************
*** 7280,7290 ****
                 (to-group (gnus-info-group info))
  	       to-marks)
  	  ;; Update the group that has been moved to.
  	  (when (and info
  		     (memq action '(move copy)))
- 	    (unless (member to-group to-groups)
- 	      (push to-group to-groups))
- 
  	    (unless (memq article gnus-newsgroup-unreads)
  	      (push 'read to-marks)
  	      (gnus-info-set-read
--- 7280,7294 ----
                 (to-group (gnus-info-group info))
  	       to-marks)
  	  ;; Update the group that has been moved to.
+ 	  (when (memq action '(move copy))
+ 	    (if info
+ 		(unless (member to-group to-groups)
+ 		  (push to-group to-groups))
+ 	      (unless (member pto-group new-groups)
+ 		(push pto-group new-groups))))
+ 
  	  (when (and info
  		     (memq action '(move copy)))
  	    (unless (memq article gnus-newsgroup-unreads)
  	      (push 'read to-marks)
  	      (gnus-info-set-read
***************
*** 7361,7366 ****
--- 7365,7373 ----
  	(when (gnus-group-goto-group (car to-groups) t)
  	  (gnus-group-get-new-news-this-group 1 t))
  	(pop to-groups)))
+ 
+     (while new-groups		; Update active info
+ 	(gnus-activate-group (pop new-groups) nil nil to-method))
  
      (gnus-kill-buffer copy-buf)
      (gnus-summary-position-point)

Re: Can't select group created by copying

[Jon K Hellan]

Jonas Steverud <d4jonas@dtek.chalmers.se> writes:

> Jon K Hellan <Jon.K.Hellan@item.ntnu.no> writes:
> 
> > Here's a problem I found. I am not sure how to deal with it.
> > 
> > When I create a new group by copying a message into it, I can't
> > enter that group until gnus has been restarted.
> 
> [...]
> 
> > When I subscribe the group in the Group buffer, and try to select it, the
> > active info is never updated. So gnus believes that it is still empty,
> > and refuses to enter it. "Can't select group".
> 
> Potential stupid question: have you tried M-g at the group in the
> *Group*-buffer. Did it matter?

It helps

Jon

Re: Can't select group created by copying

[Kai.Grossjohann]

Jonas Steverud <d4jonas@dtek.chalmers.se> writes:

> I've experienced something similar: In a nnmh-folder you cannot delete
> the last article. When a new article turns up in the group the old
> "last article" cannot be deleted until Gnus is restarted. pgnus 0.91.

This is normal and must be that way.  Gnus gets really confused when
article numbers are reused.  In particular, it might think the new
article has already been read because it has the same number as an old
article which has been read.  Not good.

kai
-- 
Life is hard and then you die.

Re: nnmh, delete next last article (Was: Re: Can't select group created by copying)

[Kai.Grossjohann]

Jonas Steverud <d4jonas@dtek.chalmers.se> writes:

> Articles that exist: 1, 5, 9, 12, 13.
> Adds article 14.
> Articles that exist: 1, 5, 9, 12, 13, 14.
> Tries to delete article 13.
> Fails.
> Restarts Gnus.
> Tries to delete article 13.
> Succeeds.

Oh.  Strange.  Hm.  Bug in pgnus?

kai
-- 
Life is hard and then you die.

Re: nnmh, delete next last article (Was: Re: Can't select group created by copying)

[Stainless Steel Rat]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

* Kai.Grossjohann@CS.Uni-Dortmund.DE  on Thu, 08 Jul 1999
| Oh.  Strange.  Hm.  Bug in pgnus?

Well, if you use nnml/nnmh, Gnus will generally not delete the last message
just in case you happen to be using procmail.  It sounds like the variable
(or whatever) that tells Gnus what the last message number might be is not
being updated.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v0.9.8 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE3hPtSgl+vIlSVSNkRAnxbAJ9+tmZocss6k/uZ7eHpGDcP8gWBdQCgnhaW
LPRTWrdny/Ax5gbT8HjwlBM=
=QoSW
-----END PGP SIGNATURE-----

-- 
Rat <ratinox@peorth.gweep.net>    \ Ingredients of Happy Fun Ball include an
Minion of Nathan - Nathan says Hi! \ unknown glowing substance which fell to
PGP Key: at a key server near you!  \ Earth, presumably from outer space.

Re: nnmh, delete next last article (Was: Re: Can't select group created by copying)

[Kai.Grossjohann]

Stainless Steel Rat <ratinox@peorth.gweep.net> writes:

> * Kai.Grossjohann@CS.Uni-Dortmund.DE  on Thu, 08 Jul 1999
> | Oh.  Strange.  Hm.  Bug in pgnus?
> 
> Well, if you use nnml/nnmh, Gnus will generally not delete the last message
> just in case you happen to be using procmail.  It sounds like the variable
> (or whatever) that tells Gnus what the last message number might be is not
> being updated.

That's what I thought, too, but the original poster explained that
it's the _next to last_ msg which isn't deleted, rather than the
_last_ one.

kai
-- 
Life is hard and then you die.

Re: nnmh, delete next last article (Was: Re: Can't select group created by copying)

[Stainless Steel Rat]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

* Kai.Grossjohann@CS.Uni-Dortmund.DE  on Fri, 09 Jul 1999
| That's what I thought, too, but the original poster explained that
| it's the _next to last_ msg which isn't deleted, rather than the
| _last_ one.

But it *was* the last one.  That is, if 18 is the last message, and the
backend knows this, and message 19 is created, it will still think that 18
is the last message.  At least, that is what I think might be happening.
I'm not sure, though.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v0.9.8 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE3hkXtgl+vIlSVSNkRAgK2AKCzEFnhwATd0QRR668NRxqWPzPvDQCfbXeN
74SQsH4D5dNPYPXdrVZXyT8=
=5/JM
-----END PGP SIGNATURE-----

-- 
Rat <ratinox@peorth.gweep.net>    \ Do not use Happy Fun Ball on concrete.
Minion of Nathan - Nathan says Hi! \ 
PGP Key: at a key server near you!  \ 

Re: nnmh, delete next last article (Was: Re: Can't select group created by copying)

[Lars Magne Ingebrigtsen]

Jonas Steverud <d4jonas@dtek.chalmers.se> writes:

> Strangely enough I couldn't make it out. I got stuck in the funcall in
> gnus-request-update-mark in gnus-int.el. "No such function:
> nnmh-request-update-mark". Hmm.

`(setq debug-on-error t)', repeat the bug and mail me the resulting
backtrace.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: nnmh, delete next last article (Was: Re: Can't select group created by copying)

[Lars Magne Ingebrigtsen]

Stainless Steel Rat <ratinox@peorth.gweep.net> writes:

> It sounds like the variable (or whatever) that tells Gnus what the
> last message number might be is not being updated.

Yup.  Fix in Pterodactyl Gnus v0.94.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen