Re: message-citation-line-format - should %F have a fall back?

[asjo@koldfront.dk (Adam Sjøgren)]

Katsumi Yamaoka writes:

> On Wed, 25 Feb 2015 21:34:24 +0100, Adam Sjøgren wrote:
>> Should %F in message-citation-line-format fall back to something
>> different than nil, if no first name can be detected?

> The most corner‐cutting way would be:

> --- message.el~	2015-01-29 02:00:24.303787500 +0000
> +++ message.el	2015-02-26 00:40:28.328441100 +0000
> @@ -4085,3 +4085,3 @@
>  	      (push ?E lst) (push "<E>" lst)
> -	      (push ?F lst) (push fname lst)
> +	      (push ?F lst) (push (or fname name-or-net) lst)
>  	      ;; We might want to use "" instead of "<X>" later.
>
> This is what %N does.

I was testing this:

--- a/lisp/message.el
+++ b/lisp/message.el
@@ -4036,7 +4036,7 @@ See `message-citation-line-format'."
 			      from)
 		   (error nil)))
 	   (name (car data))
-	   (fname name)
+	   (fname-or-net (or name (car (cdr data)) from))
 	   (lname name)
 	   (net (car (cdr data)))
 	   (name-or-net (or (car data)
@@ -4083,7 +4083,7 @@ See `message-citation-line-format'."
                       (setq fname lname lname newlname)))))
 	      ;; The following letters are not used in `format-time-string':
 	      (push ?E lst) (push "<E>" lst)
-	      (push ?F lst) (push fname lst)
+	      (push ?F lst) (push fname-or-net lst)
 	      ;; We might want to use "" instead of "<X>" later.
 	      (push ?J lst) (push "<J>" lst)
 	      (push ?K lst) (push "<K>" lst)

I don't know if that is better or worse...


  Best regards,

    Adam

-- 
 "Apparantly I was misinformed."                              Adam Sjøgren
                                                         asjo@koldfront.dk