Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Dave Love <fx@gnu.org>
Cc: simon@josefsson.org, ding@gnus.org, bugs@gnus.org
Subject: Re: imap.el workaround for Exchange 2007
Date: Mon, 22 Dec 2008 23:38:31 +0100	[thread overview]
Message-ID: <87ocz3n8d4.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <87iqphil5p.fsf@liv.ac.uk> (Dave Love's message of "Thu, 18 Dec 2008 14:59:46 +0000")

On Thu, Dec 18 2008, Dave Love wrote:

> Although this Microsoft product is apparently at least a year past its
> sell-by date, we just got it, and it broke my mail reading (which was OK
> with the one with a sell-by date of 2003).
>
> The first problem was fixed by `imap-enable-exchange-bug-workaround'.
> However, you're only likely to find that variable when debugging the
> breakage.  Why doesn't it use `*' generally -- as that seems to be
> equivalent -- and remove the need for users to find that variable?

You meant "*:*" (i.e. the variant used if
`imap-enable-exchange-bug-workaround' is t)?  If I recall the
discussion correctly, this is much slower.
Cf. <http://thread.gmane.org/gmane.emacs.gnus.general/66635>.

> Alternatively, perhaps it should check for Exchange and set it
> (per-server?) automatically, 

This has been discussed, but nobody implemented it yet.  I also think
this would be the right thing.

> or otherwise at least provide a user variable to customize.

Making `imap-enable-exchange-bug-workaround' customizable?

> The next problem (of many, doubtless...) is an assertion failure "In
> imap-parse-body".  I get a response like this for Exchange's version of
> article
> <URL:nntp://news.gmane.org/gmane.comp.clustering.gridengine.users/13804>,
> which I get direct from the gridengine list:
>
>
>   * 161 FETCH (UID 4779 RFC822.SIZE 35507 BODY ("multipart" "signed"
>   ("boundary" "----=_Part_2607_14582877.1229556098849") NIL NIL NIL
>   -1) BODY[HEADER.FIELDS (Subject From Date Message-Id References
>   In-Reply-To Xref X-Spam-Status X-Bogosity X-CRM114-Status To
>   Newsgroups)] {725}
[...]
>   )230 OK FETCH completed.
>
> Note the `-1' where there should be an unsigned integer, says rfc 3501:
>
>   body-fields     = body-fld-param SP body-fld-id SP body-fld-desc SP
>                     body-fld-enc SP body-fld-octets
>   body-fld-octets = number
>   number          = 1*DIGIT
>                       ; Unsigned 32-bit integer
>
> The following patch against current CVS fixes it for me (see the last
> hunk).  I also fixed some doc/commentary, and I assume the KTH mail
> address is obsolete.
>
> 2008-12-18  Dave Love  <fx@gnu.org>
>
> 	* imap.el: Fix author email.  Doc fixes.
> 	(imap-parse-body): Work around assertion failure in bogus Exchange 2007
> 	reply.
>
> --- imap.el	22 Jun 2008 13:24:10 +0100	7.47
> +++ imap.el	18 Dec 2008 14:10:53 +0000	
[... fixes for docs and comments stripped ]
> @@ -2862,7 +2871,12 @@
>  	;; as the standard says.
>  	(push (or (imap-parse-nstring) "7BIT") body) ;; body-fld-enc
>  	(imap-forward)
> -	(push (imap-parse-number) body)	;; body-fld-octets
> +	;; Exchange 2007 can return -1, contrary to the spec...
> +	(if (eq (char-after) ?-)
> +	    (progn
> +	      (skip-chars-forward "-0-9")
> +	      (push nil body))
> +	  (push (imap-parse-number) body)) ;; body-fld-octets

Installed.  (IIRC you still have write access to the repository, don't
you?)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/



       reply	other threads:[~2008-12-22 22:38 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87iqphil5p.fsf@liv.ac.uk>
2008-12-22 22:38 ` Reiner Steib [this message]
2008-12-23 15:41   ` Dave Love
2009-01-01 18:34     ` Reiner Steib
2009-01-02 22:20       ` Ted Zlatanov
2009-01-02 22:38         ` Reiner Steib
2009-01-09 12:00       ` Simon Josefsson
2009-01-01 18:55     ` FIXMEs in imap.el and nnimap.el (was: imap.el workaround for Exchange 2007) Reiner Steib
2009-01-02 22:19       ` FIXMEs in imap.el and nnimap.el Ted Zlatanov
2009-01-02 22:57         ` Reiner Steib
2009-01-04 23:10           ` Dave Love
2009-01-07 21:07             ` Dave Love
2009-01-08 20:42               ` Reiner Steib
2009-01-07 19:25           ` Ted Zlatanov
2009-01-08 21:04             ` Reiner Steib
2009-01-13 10:40               ` Dave Love
2009-01-13 17:00                 ` IMAP and Exchange 2007 - imap-fetch-safe (was: FIXMEs in imap.el and nnimap.el) Reiner Steib
2009-01-13 17:20                   ` IMAP and Exchange 2007 - imap-fetch-safe Simon Josefsson
2009-01-17 20:58                     ` Dave Love
2009-01-28  1:18                       ` Dave Love
2009-01-31 15:27                       ` Reiner Steib
2009-02-01 15:43                         ` Bjorn Solberg
2009-02-02 14:54                           ` Dave Goldberg
2009-02-02 19:19                             ` Reiner Steib
2009-02-03 16:21                               ` Stephen J. Turnbull
2009-02-08 18:00                               ` Dave Love
2009-02-08 18:38                                 ` Dave Goldberg
2009-02-02 19:15                           ` Reiner Steib
2009-01-13 18:28                   ` Bjorn Solberg
2009-01-13 20:18                     ` Bjorn Solberg
2009-01-17 20:59                     ` Dave Love
2009-01-04 20:08       ` FIXMEs in imap.el and nnimap.el Dave Love
2009-01-05 16:13       ` Dave Love
2009-01-05 20:35         ` Conventions (was: FIXMEs in imap.el and nnimap.el) Reiner Steib
2009-01-06 11:33           ` Conventions Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocz3n8d4.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=bugs@gnus.org \
    --cc=ding@gnus.org \
    --cc=fx@gnu.org \
    --cc=simon@josefsson.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).