* security buttons without a face (3)
@ 2006-07-28 12:04 Max Froumentin
2006-07-28 13:16 ` Reiner Steib
0 siblings, 1 reply; 8+ messages in thread
From: Max Froumentin @ 2006-07-28 12:04 UTC (permalink / raw)
Sorry to insist, but no one's told me if this is a bad idea, and I
think it's a very good one ;-)
Why aren't PGP signature buttons "[[PGP Signed Part:..." faced
like other article body buttons?
The fix is simple: insert
(when gnus-article-button-face
(gnus-overlay-put (gnus-make-overlay b e)
'face gnus-article-button-face))
in both button creation functions in article.el
Max.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: security buttons without a face (3)
2006-07-28 12:04 security buttons without a face (3) Max Froumentin
@ 2006-07-28 13:16 ` Reiner Steib
2006-07-29 18:18 ` Max Froumentin
0 siblings, 1 reply; 8+ messages in thread
From: Reiner Steib @ 2006-07-28 13:16 UTC (permalink / raw)
On Fri, Jul 28 2006, Max Froumentin wrote:
> Sorry to insist, but no one's told me if this is a bad idea, and I
> think it's a very good one ;-)
>
> Why aren't PGP signature buttons "[[PGP Signed Part:..." faced
> like other article body buttons?
>
> The fix is simple: insert
>
> (when gnus-article-button-face
> (gnus-overlay-put (gnus-make-overlay b e)
> 'face gnus-article-button-face))
>
> in both button creation functions in article.el
The patch you posted in <news:87lktppwc6.fsf_-_@lapin-bleu.net>
(http://permalink.gmane.org/gmane.emacs.gnus.general/63054)?
I see that you have now signed the papers for Emacs so we can install
your changes.
Could you please send us a diff against the current source (trunk)?
Could you provide a ChangeLog entry, too?
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: security buttons without a face (3)
2006-07-28 13:16 ` Reiner Steib
@ 2006-07-29 18:18 ` Max Froumentin
2006-09-20 16:30 ` Reiner Steib
0 siblings, 1 reply; 8+ messages in thread
From: Max Froumentin @ 2006-07-29 18:18 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
Reiner Steib <reinersteib+gmane@imap.cc> writes:
> The patch you posted in <news:87lktppwc6.fsf_-_@lapin-bleu.net>
> (http://permalink.gmane.org/gmane.emacs.gnus.general/63054)?
> I see that you have now signed the papers for Emacs so we can install
> your changes.
> Could you please send us a diff against the current source (trunk)?
Attached below.
[-- Attachment #2: gnus-art.el diff against 7.186 --]
[-- Type: text/plain, Size: 696 bytes --]
--- gnus-art.el 2006-07-29 19:05:11.000000000 +0100
+++ gnus-art.el.new 2006-07-29 18:56:02.000000000 +0100
@@ -5158,6 +5158,9 @@
;; Exclude a newline.
(1- (point))
(point)))
+ (when gnus-article-button-face
+ (gnus-overlay-put (gnus-make-overlay b e)
+ 'face gnus-article-button-face))
(widget-convert-button
'link b e
:mime-handle handle
@@ -7904,6 +7907,9 @@
;; Exclude a newline.
(1- (point))
(point)))
+ (when gnus-article-button-face
+ (gnus-overlay-put (gnus-make-overlay b e)
+ 'face gnus-article-button-face))
(widget-convert-button
'link b e
:mime-handle handle
[-- Attachment #3: Type: text/plain, Size: 286 bytes --]
> Could you provide a ChangeLog entry, too?
"Apply gnus-article-button-face to MIME and security buttons"
Note that there is another pair of buttons that are left without
faces: prev-page and next-page. I couldn't find any articles anywhere
that had them, so I couldn't test.
Max.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: security buttons without a face (3)
2006-07-29 18:18 ` Max Froumentin
@ 2006-09-20 16:30 ` Reiner Steib
2006-09-26 13:55 ` Max Froumentin
0 siblings, 1 reply; 8+ messages in thread
From: Reiner Steib @ 2006-09-20 16:30 UTC (permalink / raw)
Cc: ding
On Sat, Jul 29 2006, Max Froumentin wrote:
> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> The patch you posted in <news:87lktppwc6.fsf_-_@lapin-bleu.net>
>> (http://permalink.gmane.org/gmane.emacs.gnus.general/63054)?
>
>> I see that you have now signed the papers for Emacs so we can install
>> your changes.
>
>> Could you please send us a diff against the current source (trunk)?
>
> Attached below.
Thanks for your patch. I've applied it in CVS trunk. Sorry for the
delay.
> Note that there is another pair of buttons that are left without
> faces: prev-page and next-page. I couldn't find any articles anywhere
> that had them, so I couldn't test.
Here's an example (you need to insert a literal ^L using `C-q C-l' in
a line on it's own:
This is the first page.
\f
And this is the next one. One more page break follows.
\f
,----[ (info "(gnus)Article Washing") ]
| `W l'
| Remove page breaks from the current article
| (`gnus-summary-stop-page-breaking'). *Note Misc Article::, for
| page delimiters.
`----
,----[ (info "(gnus)Misc Article") ]
| `gnus-break-pages'
| Controls whether "page breaking" is to take place. If this
| variable is non-`nil', the articles will be divided into pages
| whenever a page delimiter appears in the article. If this
| variable is `nil', paging will not be done.
`----
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: security buttons without a face (3)
2006-09-20 16:30 ` Reiner Steib
@ 2006-09-26 13:55 ` Max Froumentin
2006-09-26 14:53 ` Reiner Steib
0 siblings, 1 reply; 8+ messages in thread
From: Max Froumentin @ 2006-09-26 13:55 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> Note that there is another pair of buttons that are left without
>> faces: prev-page and next-page. I couldn't find any articles anywhere
>> that had them, so I couldn't test.
Thanks. Here's a patch against gnus-art 7.196
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-art.diff --]
[-- Type: text/x-patch, Size: 1484 bytes --]
7502d7501
< (e (point))
7507,7517c7506,7508
< gnus-prev t
< gnus-callback gnus-article-button-prev-page
< article-type annotation))
< (setq e
< (if (bolp)
< ;; Exclude a newline.
< (1- (point))
< (point)))
< (when gnus-article-button-face
< (gnus-overlay-put (gnus-make-overlay b e)
< 'face gnus-article-button-face))
---
> gnus-prev t
> gnus-callback gnus-article-button-prev-page
> article-type annotation))
7519c7510,7513
< 'link b e
---
> 'link b (if (bolp)
> ;; Exclude a newline.
> (1- (point))
> (point))
7541d7534
< (e (point))
7544,7555c7537,7540
< `(keymap ,gnus-next-page-map
< gnus-next t
< gnus-callback gnus-article-button-next-page
< article-type annotation))
< (setq e
< (if (bolp)
< ;; Exclude a newline.
< (1- (point))
< (point)))
< (when gnus-article-button-face
< (gnus-overlay-put (gnus-make-overlay b e)
< 'face gnus-article-button-face))
---
> `(keymap ,gnus-next-page-map
> gnus-next t
> gnus-callback gnus-article-button-next-page
> article-type annotation))
7557c7542,7545
< 'link b e
---
> 'link b (if (bolp)
> ;; Exclude a newline.
> (1- (point))
> (point))
[-- Attachment #3: Type: text/plain, Size: 6 bytes --]
Max.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: security buttons without a face (3)
2006-09-26 13:55 ` Max Froumentin
@ 2006-09-26 14:53 ` Reiner Steib
2006-09-27 10:18 ` Max Froumentin
0 siblings, 1 reply; 8+ messages in thread
From: Reiner Steib @ 2006-09-26 14:53 UTC (permalink / raw)
On Tue, Sep 26 2006, Max Froumentin wrote:
> Here's a patch against gnus-art 7.196
>
> 7502d7501
> < (e (point))
> 7507,7517c7506,7508
> < gnus-prev t
Could you please resend the patch including the diff headers?
Preferably using a unified (or at least context) diff format (-u or
-c).
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: security buttons without a face (3)
2006-09-26 14:53 ` Reiner Steib
@ 2006-09-27 10:18 ` Max Froumentin
2006-09-27 12:30 ` Reiner Steib
0 siblings, 1 reply; 8+ messages in thread
From: Max Froumentin @ 2006-09-27 10:18 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
Reiner Steib <reinersteib+gmane@imap.cc> writes:
> Could you please resend the patch including the diff headers?
> Preferably using a unified (or at least context) diff format (-u or
> -c).
certainly:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-art.el.diff --]
[-- Type: text/x-patch, Size: 2039 bytes --]
--- gnus-art.el 2006-09-26 14:43:50.000000000 +0100
+++ gnus-art.el.7.196 2006-09-26 14:53:16.000000000 +0100
@@ -7499,24 +7499,18 @@
(defun gnus-insert-prev-page-button ()
(let ((b (point))
- (e (point))
(inhibit-read-only t))
(gnus-eval-format
gnus-prev-page-line-format nil
`(keymap ,gnus-prev-page-map
- gnus-prev t
- gnus-callback gnus-article-button-prev-page
- article-type annotation))
- (setq e
- (if (bolp)
- ;; Exclude a newline.
- (1- (point))
- (point)))
- (when gnus-article-button-face
- (gnus-overlay-put (gnus-make-overlay b e)
- 'face gnus-article-button-face))
+ gnus-prev t
+ gnus-callback gnus-article-button-prev-page
+ article-type annotation))
(widget-convert-button
- 'link b e
+ 'link b (if (bolp)
+ ;; Exclude a newline.
+ (1- (point))
+ (point))
:action 'gnus-button-prev-page
:button-keymap gnus-prev-page-map)))
@@ -7538,23 +7532,17 @@
(defun gnus-insert-next-page-button ()
(let ((b (point))
- (e (point))
(inhibit-read-only t))
(gnus-eval-format gnus-next-page-line-format nil
- `(keymap ,gnus-next-page-map
- gnus-next t
- gnus-callback gnus-article-button-next-page
- article-type annotation))
- (setq e
- (if (bolp)
- ;; Exclude a newline.
- (1- (point))
- (point)))
- (when gnus-article-button-face
- (gnus-overlay-put (gnus-make-overlay b e)
- 'face gnus-article-button-face))
+ `(keymap ,gnus-next-page-map
+ gnus-next t
+ gnus-callback gnus-article-button-next-page
+ article-type annotation))
(widget-convert-button
- 'link b e
+ 'link b (if (bolp)
+ ;; Exclude a newline.
+ (1- (point))
+ (point))
:action 'gnus-button-next-page
:button-keymap gnus-next-page-map)))
[-- Attachment #3: Type: text/plain, Size: 6 bytes --]
Max.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: security buttons without a face (3)
2006-09-27 10:18 ` Max Froumentin
@ 2006-09-27 12:30 ` Reiner Steib
0 siblings, 0 replies; 8+ messages in thread
From: Reiner Steib @ 2006-09-27 12:30 UTC (permalink / raw)
On Wed, Sep 27 2006, Max Froumentin wrote:
> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> Could you please resend the patch including the diff headers?
>> Preferably using a unified (or at least context) diff format (-u or
>> -c).
>
> certainly:
>
> --- gnus-art.el 2006-09-26 14:43:50.000000000 +0100
> +++ gnus-art.el.7.196 2006-09-26 14:53:16.000000000 +0100
> @@ -7499,24 +7499,18 @@
Committed.
BTW, this patch was reversed (wrong direction). You should use "diff
-u old-file new-file" or better use "cvs diff -u file" or even better
use Emacs version control features. I'd recommend PCL-CVS, see (info
"(pcl-cvs)Top").
> (defun gnus-insert-prev-page-button ()
> (let ((b (point))
> - (e (point))
I don't understand why you set `e' to `(point)' here, because later
you're unconditionally setting `e' to some other value. I've
installed a modification, please holler if there's something wrong
with it.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-09-27 12:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-28 12:04 security buttons without a face (3) Max Froumentin
2006-07-28 13:16 ` Reiner Steib
2006-07-29 18:18 ` Max Froumentin
2006-09-20 16:30 ` Reiner Steib
2006-09-26 13:55 ` Max Froumentin
2006-09-26 14:53 ` Reiner Steib
2006-09-27 10:18 ` Max Froumentin
2006-09-27 12:30 ` Reiner Steib
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).