Confusing *Group* after 'gnus-group-jump-to-group' (with topics)

Confusing *Group* after 'gnus-group-jump-to-group' (with topics)

[Adam Sjøgren]

  Hi.


I've got my various groups in topics and subtopics, but I think I've
hit a display-buglet:

Say, my group-buffer looks like this:

[468: Gnus ]
       1: nndraft:drafts 
  [1: email ]
         1: nnml:jens 
  [436: gmane ]
         1: nntp+news.gmane.org:gmane.emacs.gnus.general 
         3: nntp+news.gmane.org:gmane.linux.debian.devel.perl(m) 
         1: nntp+news.gmane.org:gmane.culture.language.word-of-the-day 
         1: nntp+news.gmane.org:gmane.comp.web.mason.devel 
         1: nntp+news.gmane.org:gmane.comp.web.mason.user(m) 
         1: nntp+news.gmane.org:gmane.mail.spam.crm114.announce(m) 
         2: nntp+news.gmane.org:gmane.discuss 
    [4: announce ]
           2: nntp+news.gmane.org:gmane.comp.gnome.announce 
           2: nntp+news.gmane.org:gmane.linux.debian.user.security.announce 
    [422: admin ]...
  [14: usenet ]
        10: dk.edb.system.unix 
         4: gnu.emacs.gnus 
  [16: rss ]
         2: nnrss:jwz 
        10: nnrss:slashdot 
         4: nnrss:salon 

(I've configured Gnus to hide topics with no new articles).

I then press 'j nnml+archive:mail-2005', and the resulting
group-buffer is:

[468: Gnus ]
  [0: archive ]
       0: nnml+archive:mail-2005 
       1: nndraft:drafts 
  [1: email ]
         1: nnml:jens 
  [436: gmane ]
         1: nntp+news.gmane.org:gmane.emacs.gnus.general 
         3: nntp+news.gmane.org:gmane.linux.debian.devel.perl(m) 
         1: nntp+news.gmane.org:gmane.culture.language.word-of-the-day 
         1: nntp+news.gmane.org:gmane.comp.web.mason.devel 
         1: nntp+news.gmane.org:gmane.comp.web.mason.user(m) 
         1: nntp+news.gmane.org:gmane.mail.spam.crm114.announce(m) 
         2: nntp+news.gmane.org:gmane.discuss 
    [4: announce ]
           2: nntp+news.gmane.org:gmane.comp.gnome.announce 
           2: nntp+news.gmane.org:gmane.linux.debian.user.security.announce 
    [422: admin ]...
  [14: usenet ]
        10: dk.edb.system.unix 
         4: gnu.emacs.gnus 
  [16: rss ]
         2: nnrss:jwz 
        10: nnrss:slashdot 
         4: nnrss:salon 

Notice how the nndraft:drafts group is suddenly under the
archive-topic, where it doesn't belong? That seems wrong.

If I enter the group 'nnml+archive:mail-2005' and tick an article (so
the group is always displayed in the group-buffer) and 'q' back, the
result is this, still wrong, group-buffer:

[469: Gnus ]
  [0: archive ]
*      0: nnml+archive:mail-2005 
       1: nndraft:drafts 
  [1: email ]
         1: nnml:jens 
  [437: gmane ]
         1: nntp+news.gmane.org:gmane.emacs.gnus.general 
         3: nntp+news.gmane.org:gmane.linux.debian.devel.perl(m) 
         1: nntp+news.gmane.org:gmane.culture.language.word-of-the-day 
         1: nntp+news.gmane.org:gmane.comp.web.mason.devel 
         1: nntp+news.gmane.org:gmane.comp.web.mason.user(m) 
         1: nntp+news.gmane.org:gmane.mail.spam.crm114.announce(m) 
         2: nntp+news.gmane.org:gmane.discuss 
    [4: announce ]
           2: nntp+news.gmane.org:gmane.comp.gnome.announce 
           2: nntp+news.gmane.org:gmane.linux.debian.user.security.announce 
    [423: admin ]...
  [14: usenet ]
        10: dk.edb.system.unix 
         4: gnu.emacs.gnus 
  [16: rss ]
         2: nnrss:jwz 
        10: nnrss:slashdot 
         4: nnrss:salon 

But if I press 'g', the buffer is updated to, the correct:

[469: Gnus ]
       1: nndraft:drafts 
  [0: archive ]
*        0: nnml+archive:mail-2005 
  [1: email ]
         1: nnml:jens 
  [437: gmane ]
         1: nntp+news.gmane.org:gmane.emacs.gnus.general 
         3: nntp+news.gmane.org:gmane.linux.debian.devel.perl(m) 
         1: nntp+news.gmane.org:gmane.culture.language.word-of-the-day 
         1: nntp+news.gmane.org:gmane.comp.web.mason.devel 
         1: nntp+news.gmane.org:gmane.comp.web.mason.user(m) 
         1: nntp+news.gmane.org:gmane.mail.spam.crm114.announce(m) 
         2: nntp+news.gmane.org:gmane.discuss 
    [4: announce ]
           2: nntp+news.gmane.org:gmane.comp.gnome.announce 
           2: nntp+news.gmane.org:gmane.linux.debian.user.security.announce 
    [423: admin ]...
  [14: usenet ]
        10: dk.edb.system.unix 
         4: gnu.emacs.gnus 
  [16: rss ]
         2: nnrss:jwz 
        10: nnrss:slashdot 
         4: nnrss:salon 

Quite odd... What could be the cause of this?


  Best regards,

    Adam

-- 
 "Du danser godt, men ude af takt"                            Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Confusing *Group* after 'gnus-group-jump-to-group' (with topics)

[Lars Magne Ingebrigtsen]

asjo@koldfront.dk (Adam Sjøgren) writes:

> Quite odd... What could be the cause of this?

I thought perhaps it might have something to do with having a group in
the top-level node, but trying that myself, I'm unable to reproduce
the bug.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Confusing *Group* after 'gnus-group-jump-to-group' (with topics)

[Adam Sjøgren]

On Fri, 14 Apr 2006 15:10:59 +0200, Lars wrote:

> asjo@koldfront.dk (Adam Sjøgren) writes:
>> Quite odd... What could be the cause of this?

> I thought perhaps it might have something to do with having a group in
> the top-level node, but trying that myself, I'm unable to reproduce
> the bug.

It only happens if there is something in the drafts-group. Can you
reproduce it if you put an article there?

(I just tried now, and could here).


  Best regards,

    Adam

-- 
 "You know, if the sun was an oboe, what would you do?"       Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Confusing *Group* after 'gnus-group-jump-to-group' (with topics)

[Lars Magne Ingebrigtsen]

asjo@koldfront.dk (Adam Sjøgren) writes:

> (I just tried now, and could here).

Here's what my group looks like (after I snip all ones below there).

[ Gnus -- 65441 ]
      19: nndraft:drafts 
  [ Stuff -- 3188 ]
        22: comp.lang.lisp 
*        0: nnml:misc 
         2: nnvirtual:emacs 

`j nntp+news.gmane.org:gmane.culture.sf.delany'

[ Gnus -- 65441 ]
      19: nndraft:drafts 
  [ Stuff -- 3188 ]
         0: nntp+news.gmane.org:gmane.culture.sf.delany (m)
        22: comp.lang.lisp 
*        0: nnml:misc 
         2: nnvirtual:emacs 

Which is what I'd expect.  I'm unable to get the drafts group to move
down no matter what group I `j' to.

Try edebugging `gnus-topic-jump-to-topic' in gnus-topic.el (and
related functions) to see if you can figure out what's happening. 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Confusing *Group* after 'gnus-group-jump-to-group' (with topics)

[Adam Sjøgren]

On Fri, 14 Apr 2006 16:35:35 +0200, Lars wrote:

> asjo@koldfront.dk (Adam Sjøgren) writes:
>> (I just tried now, and could here).

> Here's what my group looks like (after I snip all ones below there).

> [ Gnus -- 65441 ]
>       19: nndraft:drafts 
>   [ Stuff -- 3188 ]
>         22: comp.lang.lisp 
> *        0: nnml:misc 
>          2: nnvirtual:emacs 

> `j nntp+news.gmane.org:gmane.culture.sf.delany'

Oh, but the first topic you have after nndraft:drafts must not be
visible when you jump. And the group you jump to must be in that
first, hidden topic.

> Try edebugging `gnus-topic-jump-to-topic' in gnus-topic.el (and
> related functions) to see if you can figure out what's happening. 

I've tried following the path edebug-defun'ing a fun at a time, these
are my notes:

== =
The stuff that goes wrong gets called from:

 gnus-group.el: gnus-group-update-group 1699 - 1716

In line 1703:

  (funcall gnus-goto-missing-group-function group)

calls gnus-topic-goto-missing-group which makes Gnus insert "[0: archive]"
_above_ the  "1: nndraft:drafts"-line.

gnus-topic.el: gnus-topic-goto-missing-group: gnus-topic-display-missing-topic
is called in line 719.

gnus-topic.el: gnus-topic-display-missing-topic calls
gnus-topic-insert-topic-line in line 742-743.

When it does "[0: archive]" is inserted above "1: nndraft:drafts",
which is wrong. Also, "[0: archive]" and "[313: Gnus]" are both
inserted and removed again in to subsequent calls to
gnus-topic-insert-topic-line, for some reason.
== =

It looks like gnus-topic-insert-topic-line inserts the (so far hidden)
"archive" topic directly after its parent-topic "Gnus", instead of
after the groups in "Gnus" that "archive" is usually placed after.

My head is spinning a little now, so I hope someone else can pinpoint
the exact culprit.


  Best regards,

    Adam

-- 
 "You know, if the sun was an oboe, what would you do?"       Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Confusing *Group* after 'gnus-group-jump-to-group' (with topics)

[Lars Magne Ingebrigtsen]

asjo@koldfront.dk (Adam Sjøgren) writes:

> Oh, but the first topic you have after nndraft:drafts must not be
> visible when you jump. And the group you jump to must be in that
> first, hidden topic.

Sorry; missed that part.

> My head is spinning a little now, so I hope someone else can pinpoint
> the exact culprit.

:-)

I think the fix might be to simply have
`gnus-topic-display-missing-topic' skip past all the groups in the
parent topic.

Fixed in CVS.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Confusing *Group* after 'gnus-group-jump-to-group' (with topics)

[Adam Sjøgren]

On Sun, 16 Apr 2006 18:40:53 +0200, Lars wrote:

> I think the fix might be to simply have
> `gnus-topic-display-missing-topic' skip past all the groups in the
> parent topic.

Sounds good.

> Fixed in CVS.

Works fine.


  Thanks!!

   Adam

-- 
 "You know, if the sun was an oboe, what would you do?"       Adam Sjøgren
                                                         asjo@koldfront.dk