* exiting summary buffer does not move cursor in group buffer any more
@ 2005-01-24 11:39 Jani Grönberg
2005-01-24 14:58 ` Romain Francoise
0 siblings, 1 reply; 10+ messages in thread
From: Jani Grönberg @ 2005-01-24 11:39 UTC (permalink / raw)
I recently updated my cvs gnus into a newer version
(gnus-CURRENT-20050123). Before when I exit a group with "q" or "c",
the cursor in group buffer was automatically changed to next group
containing unread messages. Now it stays in (the currently empty)
group.
Is this a bug, and if not, can I get back the old behaviour? I seem to
have hard-coded in my brain the combination "c <space>", but it does
the wrong thing (for me) now.
//jani
--
A
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: exiting summary buffer does not move cursor in group buffer any more
2005-01-24 11:39 exiting summary buffer does not move cursor in group buffer any more Jani Grönberg
@ 2005-01-24 14:58 ` Romain Francoise
2005-01-25 18:26 ` Jani Grönberg
0 siblings, 1 reply; 10+ messages in thread
From: Romain Francoise @ 2005-01-24 14:58 UTC (permalink / raw)
chardhros@spamtrap.oneccuva.org (Jani Grönberg) writes:
> Before when I exit a group with "q" or "c", the cursor in group buffer
> was automatically changed to next group containing unread messages.
Works here, and I don't see any recent change that could cause this...
> I seem to have hard-coded in my brain the combination "c <space>", but
> it does the wrong thing (for me) now.
Well, use `Z n' then. ;-)
--
Romain Francoise <romain@orebokech.com> | No one should fear what they
it's a miracle -- http://orebokech.com/ | cannot see. --Beth Gibbons
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: exiting summary buffer does not move cursor in group buffer any more
2005-01-24 14:58 ` Romain Francoise
@ 2005-01-25 18:26 ` Jani Grönberg
2005-01-28 13:17 ` Jani Grönberg
0 siblings, 1 reply; 10+ messages in thread
From: Jani Grönberg @ 2005-01-25 18:26 UTC (permalink / raw)
Romain Francoise <romain@orebokech.com> writes:
> chardhros@spamtrap.oneccuva.org (Jani Grönberg) writes:
>
>> Before when I exit a group with "q" or "c", the cursor in group buffer
>> was automatically changed to next group containing unread messages.
>
> Works here, and I don't see any recent change that could cause this...
>
I don't have any intermediate versions at hand, but
gnus-CURRENT-20041125 does not exhibit this behaviour. Also exiting
group with "Q" sets the cursor normally. Probably I have some
customisation that causes the unwanted side effect, but the only thing
I could recognise is
(add-hook 'gnus-exit-group-hook 'gnus-dribble-save)
but removing this does not seem to change anything.
>> I seem to have hard-coded in my brain the combination "c <space>", but
>> it does the wrong thing (for me) now.
>
> Well, use `Z n' then. ;-)
>
ok, but I still like the old way. I'll probably do more
experimentation with different startup files when I have time.
//jani
--
A
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: exiting summary buffer does not move cursor in group buffer any more
2005-01-25 18:26 ` Jani Grönberg
@ 2005-01-28 13:17 ` Jani Grönberg
2005-01-29 12:35 ` Romain Francoise
0 siblings, 1 reply; 10+ messages in thread
From: Jani Grönberg @ 2005-01-28 13:17 UTC (permalink / raw)
chardhros@spamtrap.oneccuva.org (Jani Grönberg) writes:
> Romain Francoise <romain@orebokech.com> writes:
>
>> chardhros@spamtrap.oneccuva.org (Jani Grönberg) writes:
>>
>>> Before when I exit a group with "q" or "c", the cursor in group buffer
>>> was automatically changed to next group containing unread messages.
>>
>> Works here, and I don't see any recent change that could cause this...
>>
After experimentation, I have narrowed down the seeming cause of this
problem: This happens if the group buffer is visible when exiting the
summary buffer. This is not of course the default configuration, but I
like to use split screen. As I mentioned before, I did not encounter
this behaviour before gnus-20041125.
Is this a bug or has the behaviour of gnus-add-configuration somehow
changed? My setup is shamelessly copied and slightly modified from
this article:
http://groups-beta.google.com/group/gnu.emacs.gnus/msg/4436b5d9523408b1
//jani
--
A
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: exiting summary buffer does not move cursor in group buffer any more
2005-01-28 13:17 ` Jani Grönberg
@ 2005-01-29 12:35 ` Romain Francoise
2005-01-29 22:32 ` exiting summary buffer does not move cursor in group buffer any Stefan Monnier
0 siblings, 1 reply; 10+ messages in thread
From: Romain Francoise @ 2005-01-29 12:35 UTC (permalink / raw)
Cc: monnier
chardhros@spamtrap.oneccuva.org (Jani Grönberg) writes:
> After experimentation, I have narrowed down the seeming cause of this
> problem: This happens if the group buffer is visible when exiting the
> summary buffer.
Good catch, this is caused by the following change:
2004-11-22 Stefan Monnier <monnier@iro.umontreal.ca>
* gnus-sum.el (gnus-summary-exit): Remove redundant and harmful
pop-to-buffer, covered by the subsequent gnus-configure-windows.
When the group buffer is already visible the value of point in the
buffer is now reset to the window's value when we reselect it; before
this change we called pop-to-buffer which displayed the group buffer in
the selected window (the one displaying the summary buffer) and ensured
that the move was taken into account...
I don't remember why Stefan made that change and why pop-to-buffer was
harmful here... let's CC him.
--
Romain Francoise <romain@orebokech.com> | The world is a fine place,
it's a miracle -- http://orebokech.com/ | and worth fighting for.
| --Ernest Hemingway
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: exiting summary buffer does not move cursor in group buffer any
2005-01-29 12:35 ` Romain Francoise
@ 2005-01-29 22:32 ` Stefan Monnier
2005-01-29 23:01 ` Romain Francoise
2005-02-03 4:33 ` Stefan Monnier
0 siblings, 2 replies; 10+ messages in thread
From: Stefan Monnier @ 2005-01-29 22:32 UTC (permalink / raw)
>> After experimentation, I have narrowed down the seeming cause of this
>> problem: This happens if the group buffer is visible when exiting the
>> summary buffer.
> Good catch, this is caused by the following change:
> 2004-11-22 Stefan Monnier <monnier@iro.umontreal.ca>
> * gnus-sum.el (gnus-summary-exit): Remove redundant and harmful
> pop-to-buffer, covered by the subsequent gnus-configure-windows.
> When the group buffer is already visible the value of point in the
> buffer is now reset to the window's value when we reselect it; before
> this change we called pop-to-buffer which displayed the group buffer in
> the selected window (the one displaying the summary buffer) and ensured
> that the move was taken into account...
> I don't remember why Stefan made that change and why pop-to-buffer was
> harmful here... let's CC him.
When pop-to-frame is non-nil and the *Group* buffer is not visible,
pop-to-buffer creates a new frame and takes the careful window management
off-guard.
Does the patch below solve the problem?
Stefan
--- gnus-sum.el 04 jan 2005 14:46:56 -0500 1.56
+++ gnus-sum.el 29 jan 2005 17:31:08 -0500
@@ -6680,9 +6680,9 @@
(set-buffer gnus-group-buffer)
(if quit-config
(gnus-handle-ephemeral-exit quit-config)
- (goto-char group-point)
(unless leave-hidden
- (gnus-configure-windows 'group 'force)))
+ (gnus-configure-windows 'group 'force))
+ (goto-char group-point))
;; Clear the current group name.
(unless quit-config
(setq gnus-newsgroup-name nil)))))
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: exiting summary buffer does not move cursor in group buffer any
2005-01-29 22:32 ` exiting summary buffer does not move cursor in group buffer any Stefan Monnier
@ 2005-01-29 23:01 ` Romain Francoise
2005-02-03 4:33 ` Stefan Monnier
1 sibling, 0 replies; 10+ messages in thread
From: Romain Francoise @ 2005-01-29 23:01 UTC (permalink / raw)
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Does the patch below solve the problem?
> --- gnus-sum.el 04 jan 2005 14:46:56 -0500 1.56
> +++ gnus-sum.el 29 jan 2005 17:31:08 -0500
> @@ -6680,9 +6680,9 @@
> (set-buffer gnus-group-buffer)
> (if quit-config
> (gnus-handle-ephemeral-exit quit-config)
> - (goto-char group-point)
> (unless leave-hidden
> - (gnus-configure-windows 'group 'force)))
> + (gnus-configure-windows 'group 'force))
> + (goto-char group-point))
> ;; Clear the current group name.
> (unless quit-config
> (setq gnus-newsgroup-name nil)))))
Yes. It's obviously correct.
--
Romain Francoise <romain@orebokech.com> | When we were kids, we hated
it's a miracle -- http://orebokech.com/ | things our parents did.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: exiting summary buffer does not move cursor in group buffer any
2005-01-29 22:32 ` exiting summary buffer does not move cursor in group buffer any Stefan Monnier
2005-01-29 23:01 ` Romain Francoise
@ 2005-02-03 4:33 ` Stefan Monnier
[not found] ` <m3hdktlqrm.fsf@tanelorn.pacius.net>
1 sibling, 1 reply; 10+ messages in thread
From: Stefan Monnier @ 2005-02-03 4:33 UTC (permalink / raw)
Cc: Romain Francoise, chardhros
Any news? Is the patch helping at all?
Stefan
>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> After experimentation, I have narrowed down the seeming cause of this
>>> problem: This happens if the group buffer is visible when exiting the
>>> summary buffer.
>> Good catch, this is caused by the following change:
>> 2004-11-22 Stefan Monnier <monnier@iro.umontreal.ca>
>> * gnus-sum.el (gnus-summary-exit): Remove redundant and harmful
>> pop-to-buffer, covered by the subsequent gnus-configure-windows.
>> When the group buffer is already visible the value of point in the
>> buffer is now reset to the window's value when we reselect it; before
>> this change we called pop-to-buffer which displayed the group buffer in
>> the selected window (the one displaying the summary buffer) and ensured
>> that the move was taken into account...
>> I don't remember why Stefan made that change and why pop-to-buffer was
>> harmful here... let's CC him.
> When pop-to-frame is non-nil and the *Group* buffer is not visible,
> pop-to-buffer creates a new frame and takes the careful window management
> off-guard.
> Does the patch below solve the problem?
> Stefan
> --- gnus-sum.el 04 jan 2005 14:46:56 -0500 1.56
> +++ gnus-sum.el 29 jan 2005 17:31:08 -0500
> @@ -6680,9 +6680,9 @@
> (set-buffer gnus-group-buffer)
> (if quit-config
> (gnus-handle-ephemeral-exit quit-config)
> - (goto-char group-point)
> (unless leave-hidden
> - (gnus-configure-windows 'group 'force)))
> + (gnus-configure-windows 'group 'force))
> + (goto-char group-point))
> ;; Clear the current group name.
> (unless quit-config
> (setq gnus-newsgroup-name nil)))))
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2005-02-03 19:04 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-24 11:39 exiting summary buffer does not move cursor in group buffer any more Jani Grönberg
2005-01-24 14:58 ` Romain Francoise
2005-01-25 18:26 ` Jani Grönberg
2005-01-28 13:17 ` Jani Grönberg
2005-01-29 12:35 ` Romain Francoise
2005-01-29 22:32 ` exiting summary buffer does not move cursor in group buffer any Stefan Monnier
2005-01-29 23:01 ` Romain Francoise
2005-02-03 4:33 ` Stefan Monnier
[not found] ` <m3hdktlqrm.fsf@tanelorn.pacius.net>
2005-02-03 15:47 ` Romain Francoise
2005-02-03 19:04 ` Jani Grönberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).