From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: ding@gnus.org
Subject: Re: GitLab integration take two, light edition
Date: Sun, 06 Sep 2020 15:22:03 -0700 [thread overview]
Message-ID: <87pn6ysfzo.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87tuwashjf.fsf@ericabrahamsen.net>
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Adam Sjøgren <asjo@koldfront.dk> writes:
>
>> Eric writes:
>>
>
> [...]
>
>> It's just a list of lists of conses, so if only I could remember which
>> is which of car and cadr, it would indeed be easy.
>>
>> This is what I have currently:
>>
>> (defun adsj-article-treat-gitlab ()
>> "Show thumbsup on GitLab comments"
>> (when (and gnus-treat-type (string= gnus-treat-type "text/html"))
>>;;; (gnus-with-article-buffer
>> (let ((project-id (gnus-fetch-field "X-GitLab-Project-Id"))
>> (issue-iid (gnus-fetch-field "X-GitLab-Issue-IID"))
>> (message-id (gnus-fetch-field "Message-ID")))
>> (when project-id
>> (string-match "<note_\\([0-9]+\\)" message-id)
>> (ignore-errors
>> (let ((emojis (ghub-request "GET" (format "/projects/%s/issues/%s/notes/%s/award_emoji" project-id issue-iid (match-string 1 message-id)) nil :auth 'nngitlab :host "gitlab.nzcorp.net/api/v4" :username "adsj" :forge 'gitlab))
>> (name-to-emoji '(("thumbsup". "👍"))))
>> (widen)
>> (message-goto-eoh)
>> (dolist (emoji emojis)
>> (let ((name (cdr (assoc-string "name" emoji))))
>> (insert "GitLab-Emoji: " (cdr (or (assoc-string name name-to-emoji) `("default" . ,name))) "\n"))))))))))
>>
>> (add-hook 'gnus-part-display-hook 'adsj-article-treat-gitlab)
>>
>> The mapping of name-to-emoji needs to be expanded.
>>
>> Ideally I'd rewrite it to do a map and join over the list, so I'd get a
>> single header with a comma-separated list of emojis, if there is more
>> than one.
>
> `mapconcat' is what you're looking for there, something like:
>
> (insert "GitLab-Emoji: "
> (mapconcat
> (lambda (emo)
> (assoc-string emo name-to-emoji))
> emojis))
Bah, brain fart: mapconcat takes a third argument, the string to insert
between all the elements.
next prev parent reply other threads:[~2020-09-06 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 21:15 Adam Sjøgren
2020-08-29 18:45 ` Eric Abrahamsen
2020-09-06 17:58 ` Adam Sjøgren
2020-09-06 21:48 ` Eric Abrahamsen
2020-09-06 22:22 ` Eric Abrahamsen [this message]
2020-09-07 17:28 ` Adam Sjøgren
2020-09-08 16:58 ` Eric Abrahamsen
2020-09-08 17:28 ` Adam Sjøgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn6ysfzo.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).