From: Nikolaus Rath <Nikolaus@rath.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 21043@debbugs.gnu.org, ding@gnus.org, emacs-devel@gnu.org
Subject: Re: bug#21043: [PATCH] nnimap.el: make capability parsing more robust.
Date: Mon, 13 Jul 2015 12:00:19 -0700 [thread overview]
Message-ID: <87pp3vdgsc.fsf@thinkpad.rath.org> (raw)
In-Reply-To: <87egkcipqf.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 13 Jul 2015 13:35:52 +0800")
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
On Jul 13 2015, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
> Nikolaus Rath <Nikolaus@rath.org> writes:
>
>> Package: gnus
>> Tags: patch
>
> There was no patch!
Oops. Here it is.
--
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
»Time flies like an arrow, fruit flies like a Banana.«
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-nnimap.el-make-capability-parsing-more-robust.patch --]
[-- Type: text/x-diff, Size: 1532 bytes --]
From 241812047dedb1ba7d362c4211a06bf506d37237 Mon Sep 17 00:00:00 2001
From: Nikolaus Rath <Nikolaus@rath.org>
Date: Sun, 12 Jul 2015 18:42:48 -0700
Subject: [PATCH] nnimap.el: make capability parsing more robust.
* lisp/nnimap.el (nnimap-open-connection-1): explicitly ask server for
capabilities instead of relying on LOGIN response.
---
lisp/ChangeLog | 5 +++++
lisp/nnimap.el | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index d8ab42e..83ac4c4 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,10 @@
2015-07-12 Nikolaus Rath <Nikolaus@rath.org>
+ * nnimap.el (nnimap-open-connection-1): explicitly ask server for
+ capabilities instead of relying on LOGIN response.
+
+2015-07-12 Nikolaus Rath <Nikolaus@rath.org>
+
* nnimap.el (nnimap-request-group-scan)
(nnimap-request-create-group, nnimap-request-delete-group)
(nnimap-request-rename-group, nnimap-request-move-article)
diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index d11b3a2..19632ad 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -520,7 +520,7 @@ If non-nil, articles flagged as deleted (using the IMAP
(funcall (nth 2 credentials)))
;; See if CAPABILITY is set as part of login
;; response.
- (dolist (response (cddr login-result))
+ (dolist (response (cddr (nnimap-command "CAPABILITY")))
(when (string= "CAPABILITY" (upcase (car response)))
(setf (nnimap-capabilities nnimap-object)
(mapcar #'upcase (cdr response))))))
--
2.1.4
next prev parent reply other threads:[~2015-07-13 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 1:52 Nikolaus Rath
2015-07-13 5:35 ` Eric Abrahamsen
2015-07-13 19:00 ` Nikolaus Rath [this message]
2015-07-13 19:21 ` Lars Magne Ingebrigtsen
2015-07-14 0:37 ` Nikolaus Rath
2015-07-13 19:24 ` Lars Magne Ingebrigtsen
2015-07-14 0:36 ` Nikolaus Rath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp3vdgsc.fsf@thinkpad.rath.org \
--to=nikolaus@rath.org \
--cc=21043@debbugs.gnu.org \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).