From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/86067 Path: news.gmane.org!not-for-mail From: Nikolaus Rath Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: bug#21043: [PATCH] nnimap.el: make capability parsing more robust. Date: Mon, 13 Jul 2015 12:00:19 -0700 Message-ID: <87pp3vdgsc.fsf@thinkpad.rath.org> References: <87615olt7b.fsf@vostro.rath.org> <87egkcipqf.fsf@ericabrahamsen.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1436814043 18631 80.91.229.3 (13 Jul 2015 19:00:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 13 Jul 2015 19:00:43 +0000 (UTC) Cc: 21043@debbugs.gnu.org, ding@gnus.org, emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 13 21:00:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZEiy2-0006U6-8D for ged-emacs-devel@m.gmane.org; Mon, 13 Jul 2015 21:00:42 +0200 Original-Received: from localhost ([::1]:56392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEiy1-0006az-Kn for ged-emacs-devel@m.gmane.org; Mon, 13 Jul 2015 15:00:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEixq-0006al-ET for emacs-devel@gnu.org; Mon, 13 Jul 2015 15:00:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEixm-0000da-Ep for emacs-devel@gnu.org; Mon, 13 Jul 2015 15:00:30 -0400 Original-Received: from ebox.rath.org ([2600:3c01::f03c:91ff:fe69:db07]:45419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEixm-0000XU-87 for emacs-devel@gnu.org; Mon, 13 Jul 2015 15:00:26 -0400 Original-Received: from thinkpad ([192.168.12.2]) by ebox.rath.org with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1ZEixf-0005YL-OO; Mon, 13 Jul 2015 19:00:19 +0000 Original-Received: by thinkpad (Postfix, from userid 1000) id 26127C040C; Mon, 13 Jul 2015 12:00:19 -0700 (PDT) Mail-Copies-To: never Mail-Followup-To: Eric Abrahamsen , emacs-devel@gnu.org, ding@gnus.org, 21043@debbugs.gnu.org In-Reply-To: <87egkcipqf.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 13 Jul 2015 13:35:52 +0800") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fe69:db07 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187858 gmane.emacs.gnus.general:86067 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Jul 13 2015, Eric Abrahamsen wrote: > Nikolaus Rath writes: > >> Package: gnus >> Tags: patch > > There was no patch! Oops. Here it is. --=20 GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F =C2=BBTime flies like an arrow, fruit flies like a Banana.=C2= =AB --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-nnimap.el-make-capability-parsing-more-robust.patch >From 241812047dedb1ba7d362c4211a06bf506d37237 Mon Sep 17 00:00:00 2001 From: Nikolaus Rath Date: Sun, 12 Jul 2015 18:42:48 -0700 Subject: [PATCH] nnimap.el: make capability parsing more robust. * lisp/nnimap.el (nnimap-open-connection-1): explicitly ask server for capabilities instead of relying on LOGIN response. --- lisp/ChangeLog | 5 +++++ lisp/nnimap.el | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index d8ab42e..83ac4c4 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,5 +1,10 @@ 2015-07-12 Nikolaus Rath + * nnimap.el (nnimap-open-connection-1): explicitly ask server for + capabilities instead of relying on LOGIN response. + +2015-07-12 Nikolaus Rath + * nnimap.el (nnimap-request-group-scan) (nnimap-request-create-group, nnimap-request-delete-group) (nnimap-request-rename-group, nnimap-request-move-article) diff --git a/lisp/nnimap.el b/lisp/nnimap.el index d11b3a2..19632ad 100644 --- a/lisp/nnimap.el +++ b/lisp/nnimap.el @@ -520,7 +520,7 @@ If non-nil, articles flagged as deleted (using the IMAP (funcall (nth 2 credentials))) ;; See if CAPABILITY is set as part of login ;; response. - (dolist (response (cddr login-result)) + (dolist (response (cddr (nnimap-command "CAPABILITY"))) (when (string= "CAPABILITY" (upcase (car response))) (setf (nnimap-capabilities nnimap-object) (mapcar #'upcase (cdr response)))))) -- 2.1.4 --=-=-=--