gnus-delay-send-queue should not run message-send-hook

gnus-delay-send-queue should not run message-send-hook

[Peter Münster]

Hi,

IMO, `gnus-delay-send-queue' should not run `message-send-hook,' because
`gnus-delay-article' does it already, and sometimes, there can be
interactive commands in this hook, that needs user interaction.

Do you agree? And if yes, what could be done to suppress the second
execution of `message-send-hook'?

TIA for any hints,
-- 
           Peter

Re: gnus-delay-send-queue should not run message-send-hook

[Peter Münster]

On Tue, May 27 2014, Peter Münster wrote:

> IMO, `gnus-delay-send-queue' should not run `message-send-hook,' because
> `gnus-delay-article' does it already, and sometimes, there can be
> interactive commands in this hook, that needs user interaction.
>
> Do you agree? And if yes, what could be done to suppress the second
> execution of `message-send-hook'?

Hi,

Since there is no feedback, I'm looking for a workaround:

--8<---------------cut here---------------start------------->8---
(defun pm/message-send ()
  (unless (message-field-value gnus-delay-header)
    (do-interactive-things-like-spell-checking)))
(add-hook 'message-send-hook 'pm/message-send)
--8<---------------cut here---------------end--------------->8---

But this does not work, because the `gnus-delay-header' is removed just
before this function. Could you please make use of the `append' argument
to `add-hook' in function `gnus-delay-send-queue' (line 156 in
gnus-delay.el), like this:

--8<---------------cut here---------------start------------->8---
      (when (gnus-group-entry group)
	(gnus-activate-group group)
	(add-hook 'message-send-hook
		  (lambda () (message-remove-header gnus-delay-header)) t)
	(setq articles (nndraft-articles))
--8<---------------cut here---------------end--------------->8---

Then, there would be no more problem.

TIA,
-- 
           Peter