* Error when IMAP server UIDs change
@ 2011-12-13 8:57 Julien Danjou
2012-01-03 20:46 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Julien Danjou @ 2011-12-13 8:57 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 10961 bytes --]
Hi,
One of the IMAP server I use was upgraded, so almost everything changed,
except the groups names, obviously.
When I started Gnus, it stopped with the following backtrace:
Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
>(nil 1)
(and old-uidvalidity (not (equal old-uidvalidity uidvalidity)) (> start-article 1))
(let ((old-uidvalidity (cdr (assq (quote uidvalidity) (gnus-info-params info))))) (and old-uidvalidity (not (equal old-uidvalidity uidvalidity)) (> start-article 1)))
(cond ((and (not existing) (not uidnext)) (let ((active (cdr (assq (quote active) (gnus-info-params info))))) (when active (gnus-set-active (gnus-info-group info) active)))) ((let ((old-uidvalidity (cdr (assq (quote uidvalidity) (gnus-info-params info))))) (and old-uidvalidity (not (equal old-uidvalidity uidvalidity)) (> start-article 1))) (gnus-group-remove-parameter info (quote uidvalidity)) (gnus-group-remove-parameter info (quote modseq))) (t (let* ((group (gnus-info-group info)) (completep (and start-article (= start-article 1))) (active (or (gnus-active group) (cdr (assq ... ...))))) (when uidnext (setq high (1- uidnext))) (if (or completep (not (gnus-active group))) (gnus-set-active group (cond (active (cons ... ...)) ((and low high) (cons low high)) (uidnext (cons uidnext ...)) (start-article (cons start-article ...)) (t nil))) (gnus-set-active group (cons (car active) (or high (1- uidnext))))) (unless (eq permanent-flags (quote not-scanned)) (gnus-group-set-parameter info (quote permanent-flags) (and (or (memq ... permanent-flags) (memq ... permanent-flags)) permanent-flags))) (when (setq permanent-flags (cdr (assq (quote permanent-flags) (gnus-info-params info)))) (if (and highestmodseq (not start-article)) (nnimap-update-qresync-info info existing (nnimap-imap-ranges-to-gnus-ranges vanished) flags) (let* ((unread ...) (read ...)) (when (> start-article 1) (setq read ...)) (when (or ... ...) (gnus-info-set-read info read)) (setq marks (gnus-info-marks info)) (dolist (type ...) (when ... ...)) (gnus-info-set-marks info marks t)))) (let ((recent (cdr (assoc ... flags)))) (when (and active recent (> (car ...) (cdr active))) (push (list (cons ... 0)) nnmail-split-history))) (gnus-group-set-parameter info (quote active) (gnus-active group)) (gnus-group-set-parameter info (quote uidvalidity) uidvalidity) (gnus-group-set-parameter info (quote modseq) highestmodseq) (nnimap-store-info info (gnus-active group)))))
(let* ((--cl-rest-- marks) (existing (if (= (length --cl-rest--) 10) (pop --cl-rest--) (signal (quote wrong-number-of-arguments) (list nil (length --cl-rest--))))) (flags (pop --cl-rest--)) (high (pop --cl-rest--)) (low (pop --cl-rest--)) (uidnext (pop --cl-rest--)) (start-article (pop --cl-rest--)) (permanent-flags (pop --cl-rest--)) (uidvalidity (pop --cl-rest--)) (vanished (pop --cl-rest--)) (highestmodseq (car --cl-rest--))) (cond ((and (not existing) (not uidnext)) (let ((active (cdr (assq ... ...)))) (when active (gnus-set-active (gnus-info-group info) active)))) ((let ((old-uidvalidity (cdr (assq ... ...)))) (and old-uidvalidity (not (equal old-uidvalidity uidvalidity)) (> start-article 1))) (gnus-group-remove-parameter info (quote uidvalidity)) (gnus-group-remove-parameter info (quote modseq))) (t (let* ((group (gnus-info-group info)) (completep (and start-article (= start-article 1))) (active (or (gnus-active group) (cdr ...)))) (when uidnext (setq high (1- uidnext))) (if (or completep (not (gnus-active group))) (gnus-set-active group (cond (active ...) (... ...) (uidnext ...) (start-article ...) (t nil))) (gnus-set-active group (cons (car active) (or high ...)))) (unless (eq permanent-flags (quote not-scanned)) (gnus-group-set-parameter info (quote permanent-flags) (and (or ... ...) permanent-flags))) (when (setq permanent-flags (cdr (assq ... ...))) (if (and highestmodseq (not start-article)) (nnimap-update-qresync-info info existing (nnimap-imap-ranges-to-gnus-ranges vanished) flags) (let* (... ...) (when ... ...) (when ... ...) (setq marks ...) (dolist ... ...) (gnus-info-set-marks info marks t)))) (let ((recent (cdr ...))) (when (and active recent (> ... ...)) (push (list ...) nnmail-split-history))) (gnus-group-set-parameter info (quote active) (gnus-active group)) (gnus-group-set-parameter info (quote uidvalidity) uidvalidity) (gnus-group-set-parameter info (quote modseq) highestmodseq) (nnimap-store-info info (gnus-active group))))))
(progn (let* ((--cl-rest-- marks) (existing (if (= (length --cl-rest--) 10) (pop --cl-rest--) (signal (quote wrong-number-of-arguments) (list nil (length --cl-rest--))))) (flags (pop --cl-rest--)) (high (pop --cl-rest--)) (low (pop --cl-rest--)) (uidnext (pop --cl-rest--)) (start-article (pop --cl-rest--)) (permanent-flags (pop --cl-rest--)) (uidvalidity (pop --cl-rest--)) (vanished (pop --cl-rest--)) (highestmodseq (car --cl-rest--))) (cond ((and (not existing) (not uidnext)) (let ((active (cdr ...))) (when active (gnus-set-active (gnus-info-group info) active)))) ((let ((old-uidvalidity (cdr ...))) (and old-uidvalidity (not (equal old-uidvalidity uidvalidity)) (> start-article 1))) (gnus-group-remove-parameter info (quote uidvalidity)) (gnus-group-remove-parameter info (quote modseq))) (t (let* ((group (gnus-info-group info)) (completep (and start-article ...)) (active (or ... ...))) (when uidnext (setq high (1- uidnext))) (if (or completep (not ...)) (gnus-set-active group (cond ... ... ... ... ...)) (gnus-set-active group (cons ... ...))) (unless (eq permanent-flags (quote not-scanned)) (gnus-group-set-parameter info (quote permanent-flags) (and ... permanent-flags))) (when (setq permanent-flags (cdr ...)) (if (and highestmodseq ...) (nnimap-update-qresync-info info existing ... flags) (let* ... ... ... ... ... ...))) (let ((recent ...)) (when (and active recent ...) (push ... nnmail-split-history))) (gnus-group-set-parameter info (quote active) (gnus-active group)) (gnus-group-set-parameter info (quote uidvalidity) uidvalidity) (gnus-group-set-parameter info (quote modseq) highestmodseq) (nnimap-store-info info (gnus-active group)))))))
(destructuring-bind (existing flags high low uidnext start-article permanent-flags uidvalidity vanished highestmodseq) marks (cond ((and (not existing) (not uidnext)) (let ((active (cdr (assq ... ...)))) (when active (gnus-set-active (gnus-info-group info) active)))) ((let ((old-uidvalidity (cdr (assq ... ...)))) (and old-uidvalidity (not (equal old-uidvalidity uidvalidity)) (> start-article 1))) (gnus-group-remove-parameter info (quote uidvalidity)) (gnus-group-remove-parameter info (quote modseq))) (t (let* ((group (gnus-info-group info)) (completep (and start-article (= start-article 1))) (active (or (gnus-active group) (cdr ...)))) (when uidnext (setq high (1- uidnext))) (if (or completep (not (gnus-active group))) (gnus-set-active group (cond (active ...) (... ...) (uidnext ...) (start-article ...) (t nil))) (gnus-set-active group (cons (car active) (or high ...)))) (unless (eq permanent-flags (quote not-scanned)) (gnus-group-set-parameter info (quote permanent-flags) (and (or ... ...) permanent-flags))) (when (setq permanent-flags (cdr (assq ... ...))) (if (and highestmodseq (not start-article)) (nnimap-update-qresync-info info existing (nnimap-imap-ranges-to-gnus-ranges vanished) flags) (let* (... ...) (when ... ...) (when ... ...) (setq marks ...) (dolist ... ...) (gnus-info-set-marks info marks t)))) (let ((recent (cdr ...))) (when (and active recent (> ... ...)) (push (list ...) nnmail-split-history))) (gnus-group-set-parameter info (quote active) (gnus-active group)) (gnus-group-set-parameter info (quote uidvalidity) uidvalidity) (gnus-group-set-parameter info (quote modseq) highestmodseq) (nnimap-store-info info (gnus-active group))))))
nnimap-update-info(("nnimap+eNovance:Lists/ow2/compatible-poc2" 3 ((1 . 4344)) ((seen 1091 1828 1834 1858 1892 1913 4344)) "nnimap:eNovance" ((modseq . "9155") (uidvalidity . "1760") (active 1 . 4344) (permanent-flags %Answered %Deleted %Draft %Flagged %Seen $Forwarded $MDNSent Forwarded gnus-forward %*))) (nil nil nil nil 7243 nil not-scanned "3060" nil "6543"))
(progn (nnimap-update-info info marks))
(if marks (progn (nnimap-update-info info marks)))
(when marks (nnimap-update-info info marks))
(let* ((group (nnimap-decode-gnus-group (gnus-group-real-name (gnus-info-group info)))) (marks (cdr (assoc group flags)))) (when marks (nnimap-update-info info marks)))
(while --cl-dolist-temp-- (setq info (car --cl-dolist-temp--)) (let* ((group (nnimap-decode-gnus-group (gnus-group-real-name (gnus-info-group info)))) (marks (cdr (assoc group flags)))) (when marks (nnimap-update-info info marks))) (setq --cl-dolist-temp-- (cdr --cl-dolist-temp--)))
(let ((--cl-dolist-temp-- infos) info) (while --cl-dolist-temp-- (setq info (car --cl-dolist-temp--)) (let* ((group (nnimap-decode-gnus-group (gnus-group-real-name (gnus-info-group info)))) (marks (cdr (assoc group flags)))) (when marks (nnimap-update-info info marks))) (setq --cl-dolist-temp-- (cdr --cl-dolist-temp--))))
(catch (quote --cl-block-nil--) (let ((--cl-dolist-temp-- infos) info) (while --cl-dolist-temp-- (setq info (car --cl-dolist-temp--)) (let* ((group (nnimap-decode-gnus-group (gnus-group-real-name ...))) (marks (cdr (assoc group flags)))) (when marks (nnimap-update-info info marks))) (setq --cl-dolist-temp-- (cdr --cl-dolist-temp--)))))
(cl-block-wrapper (catch (quote --cl-block-nil--) (let ((--cl-dolist-temp-- infos) info) (while --cl-dolist-temp-- (setq info (car --cl-dolist-temp--)) (let* ((group (nnimap-decode-gnus-group ...)) (marks (cdr ...))) (when marks (nnimap-update-info info marks))) (setq --cl-dolist-temp-- (cdr --cl-dolist-temp--))))))
(block nil (let ((--cl-dolist-temp-- infos) info) (while --cl-dolist-temp-- (setq info (car --cl-dolist-temp--)) (let* ((group (nnimap-decode-gnus-group (gnus-group-real-name ...))) (marks (cdr (assoc group flags)))) (when marks (nnimap-update-info info marks))) (setq --cl-dolist-temp-- (cdr --cl-dolist-temp--)))))
(dolist (info infos) (let* ((group (nnimap-decode-gnus-group (gnus-group-real-name (gnus-info-group info)))) (marks (cdr (assoc group flags)))) (when marks (nnimap-update-info info marks))))
[…]
gnus()
I "fixed" it with the following hack:
diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index b4e6e31..56c06ff 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -1332,7 +1332,8 @@ textual parts.")
(cdr (assq 'uidvalidity (gnus-info-params info)))))
(and old-uidvalidity
(not (equal old-uidvalidity uidvalidity))
- (> start-article 1)))
+ (or (not start-article)
+ (> start-article 1))))
(gnus-group-remove-parameter info 'uidvalidity)
(gnus-group-remove-parameter info 'modseq))
;; We have the data needed to update.
Lars, WDYT?
--
Julien Danjou
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Error when IMAP server UIDs change
2011-12-13 8:57 Error when IMAP server UIDs change Julien Danjou
@ 2012-01-03 20:46 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-01-03 20:46 UTC (permalink / raw)
To: ding
Julien Danjou <julien@danjou.info> writes:
> I "fixed" it with the following hack:
>
> diff --git a/lisp/nnimap.el b/lisp/nnimap.el
> index b4e6e31..56c06ff 100644
> --- a/lisp/nnimap.el
> +++ b/lisp/nnimap.el
> @@ -1332,7 +1332,8 @@ textual parts.")
> (cdr (assq 'uidvalidity (gnus-info-params info)))))
> (and old-uidvalidity
> (not (equal old-uidvalidity uidvalidity))
> - (> start-article 1)))
> + (or (not start-article)
> + (> start-article 1))))
> (gnus-group-remove-parameter info 'uidvalidity)
> (gnus-group-remove-parameter info 'modseq))
> ;; We have the data needed to update.
>
> Lars, WDYT?
Looks good; please apply.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-03 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-13 8:57 Error when IMAP server UIDs change Julien Danjou
2012-01-03 20:46 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).