From: Ted Zlatanov <tzz@lifelogs.com>
To: ding@gnus.org
Subject: Re: Buildbot + registry errors
Date: Sun, 24 Apr 2011 23:06:21 -0500 [thread overview]
Message-ID: <87pqobf002.fsf@lifelogs.com> (raw)
In-Reply-To: <m3wrijcus4.fsf@quimbies.gnus.org>
On Sun, 24 Apr 2011 21:29:47 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
LMI> Whenever somebody checks something in, they get a message about the
LMI> failed build
That seems like something BuildBot should not be doing. It should CC
everyone involved since the LAST failure, not just the last committer.
But my problem was that I forgot to subscribe to the buildbot mailing
list. "It's so quiet around here..."
LMI> and it's because of:
LMI> ---
LMI> Ran 6 tests, 5 results as expected, 1 unexpected (2011-04-24 21:19:54+0200)
LMI> 1 unexpected results:
LMI> FAILED gnus-registry-usage-test
LMI> ---
LMI> Ted, could you fix the test, or remove it?
It's a problem with `gnus-parameter-registry-ignore': it fails if the
*Group* (`gnus-group-buffer') buffer doesn't exist. But this is a
problem deeper in Gnus.
I put a workaround for it, but I think `gnus-group-find-parameter'
should be fixed instead, see below (simply added a `when get-buffer'
around). Do you agree?
Ted
diff --git a/lisp/gnus.el b/lisp/gnus.el
index c30eaba..f12d5f4 100644
--- a/lisp/gnus.el
+++ b/lisp/gnus.el
@@ -3873,13 +3873,14 @@ If SYMBOL, return the value of that symbol in the group parameters.
If you call this function inside a loop, consider using the faster
`gnus-group-fast-parameter' instead."
- (with-current-buffer gnus-group-buffer
- (if symbol
- (gnus-group-fast-parameter group symbol allow-list)
- (nconc
- (copy-sequence
- (funcall gnus-group-get-parameter-function group))
- (gnus-parameters-get-parameter group)))))
+ (when (get-buffer gnus-group-buffer)
+ (with-current-buffer gnus-group-buffer
+ (if symbol
+ (gnus-group-fast-parameter group symbol allow-list)
+ (nconc
+ (copy-sequence
+ (funcall gnus-group-get-parameter-function group))
+ (gnus-parameters-get-parameter group))))))
(defun gnus-group-get-parameter (group &optional symbol allow-list)
"Return the group parameters for GROUP.
next prev parent reply other threads:[~2011-04-25 4:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-24 19:29 Lars Magne Ingebrigtsen
2011-04-24 19:42 ` David Engster
2011-04-25 4:06 ` Ted Zlatanov [this message]
2011-04-25 8:04 ` David Engster
2011-04-25 12:24 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqobf002.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).