From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/78582 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: Buildbot + registry errors Date: Sun, 24 Apr 2011 23:06:21 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87pqobf002.fsf@lifelogs.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1303704532 28574 80.91.229.12 (25 Apr 2011 04:08:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Apr 2011 04:08:52 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M26885@lists.math.uh.edu Mon Apr 25 06:08:48 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QED6N-0004BA-1m for ding-account@gmane.org; Mon, 25 Apr 2011 06:08:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1QED4L-0004yi-Eu; Sun, 24 Apr 2011 23:06:41 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1QED4K-0004yb-AG for ding@lists.math.uh.edu; Sun, 24 Apr 2011 23:06:40 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1QED4F-0004ip-SX for ding@lists.math.uh.edu; Sun, 24 Apr 2011 23:06:40 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1QED4C-0001sl-Um for ding@gnus.org; Mon, 25 Apr 2011 06:06:32 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QED4C-0003NS-J8 for ding@gnus.org; Mon, 25 Apr 2011 06:06:32 +0200 Original-Received: from c-67-186-102-106.hsd1.il.comcast.net ([67.186.102.106]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 25 Apr 2011 06:06:32 +0200 Original-Received: from tzz by c-67-186-102-106.hsd1.il.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 25 Apr 2011 06:06:32 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 57 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: c-67-186-102-106.hsd1.il.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:vst4EeU5Mi8aIB6lqXuM1D1MGW8= X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:78582 Archived-At: On Sun, 24 Apr 2011 21:29:47 +0200 Lars Magne Ingebrigtsen wrote: LMI> Whenever somebody checks something in, they get a message about the LMI> failed build That seems like something BuildBot should not be doing. It should CC everyone involved since the LAST failure, not just the last committer. But my problem was that I forgot to subscribe to the buildbot mailing list. "It's so quiet around here..." LMI> and it's because of: LMI> --- LMI> Ran 6 tests, 5 results as expected, 1 unexpected (2011-04-24 21:19:54+0200) LMI> 1 unexpected results: LMI> FAILED gnus-registry-usage-test LMI> --- LMI> Ted, could you fix the test, or remove it? It's a problem with `gnus-parameter-registry-ignore': it fails if the *Group* (`gnus-group-buffer') buffer doesn't exist. But this is a problem deeper in Gnus. I put a workaround for it, but I think `gnus-group-find-parameter' should be fixed instead, see below (simply added a `when get-buffer' around). Do you agree? Ted diff --git a/lisp/gnus.el b/lisp/gnus.el index c30eaba..f12d5f4 100644 --- a/lisp/gnus.el +++ b/lisp/gnus.el @@ -3873,13 +3873,14 @@ If SYMBOL, return the value of that symbol in the group parameters. If you call this function inside a loop, consider using the faster `gnus-group-fast-parameter' instead." - (with-current-buffer gnus-group-buffer - (if symbol - (gnus-group-fast-parameter group symbol allow-list) - (nconc - (copy-sequence - (funcall gnus-group-get-parameter-function group)) - (gnus-parameters-get-parameter group))))) + (when (get-buffer gnus-group-buffer) + (with-current-buffer gnus-group-buffer + (if symbol + (gnus-group-fast-parameter group symbol allow-list) + (nconc + (copy-sequence + (funcall gnus-group-get-parameter-function group)) + (gnus-parameters-get-parameter group)))))) (defun gnus-group-get-parameter (group &optional symbol allow-list) "Return the group parameters for GROUP.