* gnus-article-html and XEmacs 21.5 beta
@ 2010-09-01 20:23 Adam Sjøgren
2010-09-01 20:29 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 10+ messages in thread
From: Adam Sjøgren @ 2010-09-01 20:23 UTC (permalink / raw)
To: ding
Hi.
Trying the latest git (you have to be kind of quick these
days/hours/minutes) in a vanilla XEmacs 21.5 beta (none of the Kehoe
process-patches), I now get an error if the image has never been
fetched before:
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
sha1(nil)
gnus-html-image-id(nil)
gnus-html-curl-sentinel(#<process "images" pid 19831 state:exit> "finished\n")
(next-event "[internal]")
But if I look at the same article again - so the cached image is used -
the image is displayed as expected.
(It's kind of the opposite of what happened earlier, from a user
perspective.)
Probably trivial to fix?
O:-),
Adam
--
"Don't give me those sandy metal eyes Adam Sjøgren
'Cause I'm proud, and my hair is nice" asjo@koldfront.dk
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: gnus-article-html and XEmacs 21.5 beta
2010-09-01 20:23 gnus-article-html and XEmacs 21.5 beta Adam Sjøgren
@ 2010-09-01 20:29 ` Lars Magne Ingebrigtsen
2010-09-01 20:49 ` Adam Sjøgren
0 siblings, 1 reply; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-01 20:29 UTC (permalink / raw)
To: ding
asjo@koldfront.dk (Adam Sjøgren) writes:
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
> sha1(nil)
> gnus-html-image-id(nil)
> gnus-html-curl-sentinel(#<process "images" pid 19831 state:exit> "finish
[...]
> (It's kind of the opposite of what happened earlier, from a user
> perspective.)
>
> Probably trivial to fix?
This is the code that triggers this:
(let* ((images (gnus-process-get process 'images))
(buffer (gnus-process-get process 'buffer))
(spec (pop images))
(file (gnus-html-image-id (car spec))))
So gnus-process-get on the process returns nil...
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: gnus-article-html and XEmacs 21.5 beta
2010-09-01 20:29 ` Lars Magne Ingebrigtsen
@ 2010-09-01 20:49 ` Adam Sjøgren
2010-09-01 20:54 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 10+ messages in thread
From: Adam Sjøgren @ 2010-09-01 20:49 UTC (permalink / raw)
To: ding
On Wed, 01 Sep 2010 22:29:51 +0200, Lars wrote:
> This is the code that triggers this:
> (let* ((images (gnus-process-get process 'images))
> (buffer (gnus-process-get process 'buffer))
> (spec (pop images))
> (file (gnus-html-image-id (car spec))))
> So gnus-process-get on the process returns nil...
It Katsumi still up, perchance?
O:-),
Adam
--
"I wanted a computer, not a glorified fruit machine." Adam Sjøgren
asjo@koldfront.dk
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: gnus-article-html and XEmacs 21.5 beta
2010-09-01 20:49 ` Adam Sjøgren
@ 2010-09-01 20:54 ` Lars Magne Ingebrigtsen
2010-09-02 6:38 ` Katsumi Yamaoka
0 siblings, 1 reply; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-01 20:54 UTC (permalink / raw)
To: ding
asjo@koldfront.dk (Adam Sjøgren) writes:
>> So gnus-process-get on the process returns nil...
>
> It Katsumi still up, perchance?
Isn't he 9 hours ahead of us? So he should just have gotten up around
now... :-)
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: gnus-article-html and XEmacs 21.5 beta
2010-09-01 20:54 ` Lars Magne Ingebrigtsen
@ 2010-09-02 6:38 ` Katsumi Yamaoka
2010-09-02 6:59 ` Katsumi Yamaoka
0 siblings, 1 reply; 10+ messages in thread
From: Katsumi Yamaoka @ 2010-09-02 6:38 UTC (permalink / raw)
To: ding
Lars Magne Ingebrigtsen wrote:
> asjo@koldfront.dk (Adam Sjøgren) writes:
>>> So gnus-process-get on the process returns nil...
>>
>> It Katsumi still up, perchance?
> Isn't he 9 hours ahead of us? So he should just have gotten up around
> now... :-)
I believe I've fixed it in git repo. Sorry for the delay (I
needed time to read a *lot* of recent ding mails ;-).
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: gnus-article-html and XEmacs 21.5 beta
2010-09-02 6:38 ` Katsumi Yamaoka
@ 2010-09-02 6:59 ` Katsumi Yamaoka
2010-09-02 7:34 ` Katsumi Yamaoka
0 siblings, 1 reply; 10+ messages in thread
From: Katsumi Yamaoka @ 2010-09-02 6:59 UTC (permalink / raw)
To: ding
Katsumi Yamaoka wrote:
> I believe I've fixed it in git repo.
Oops. I got the same error that Adam Sjøgren brought up first.
I'll look into it...
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: gnus-article-html and XEmacs 21.5 beta
2010-09-02 6:59 ` Katsumi Yamaoka
@ 2010-09-02 7:34 ` Katsumi Yamaoka
2010-09-02 11:03 ` Adam Sjøgren
0 siblings, 1 reply; 10+ messages in thread
From: Katsumi Yamaoka @ 2010-09-02 7:34 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
Katsumi Yamaoka wrote:
> Katsumi Yamaoka wrote:
>> I believe I've fixed it in git repo.
> Oops. I got the same error that Adam Sjøgren brought up first.
> I'll look into it...
A temporary patch is attached. But it makes the plist data that
the `gnus-process-plist' symbol holds grow infinitely. I must
find a proper way...
[-- Attachment #2: Type: text/x-patch, Size: 781 bytes --]
--- gnus-ems.el~ 2010-09-01 22:55:06 +0000
+++ gnus-ems.el 2010-09-02 07:33:21 +0000
@@ -317,16 +317,6 @@
(put 'gnus-process-plist process plist))
(defun gnus-process-plist (process)
"Return the plist of PROCESS."
- ;; Remove those of dead processes from `gnus-process-plist'
- ;; to prevent it from growing.
- (let ((plist (symbol-plist 'gnus-process-plist))
- proc)
- (while (setq proc (car plist))
- (if (and (processp proc)
- (memq (process-status proc) '(open run)))
- (setq plist (cddr plist))
- (setcar plist (caddr plist))
- (setcdr plist (or (cdddr plist) '(nil))))))
(get 'gnus-process-plist process))
(defun gnus-process-get (process propname)
"Return the value of PROCESS' PROPNAME property.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: gnus-article-html and XEmacs 21.5 beta
2010-09-02 7:34 ` Katsumi Yamaoka
@ 2010-09-02 11:03 ` Adam Sjøgren
2010-09-03 0:44 ` Katsumi Yamaoka
0 siblings, 1 reply; 10+ messages in thread
From: Adam Sjøgren @ 2010-09-02 11:03 UTC (permalink / raw)
To: ding
On Thu, 02 Sep 2010 16:34:25 +0900, Katsumi wrote:
> Katsumi Yamaoka wrote:
>> Oops. I got the same error that Adam Sjøgren brought up first.
>> I'll look into it...
> A temporary patch is attached. But it makes the plist data that
> the `gnus-process-plist' symbol holds grow infinitely. I must
> find a proper way...
That helps - thanks for posting it, even if it isn't perfect!
Did you see Aidan Kehoes answer on xemacs-beta to my question about this
whole process-plist thing and XEmacs?
* http://article.gmane.org/gmane.emacs.xemacs.beta/33453
(As I understand it, that would only work in the future, not for older
emacsen, so it isn't really a solution, I guess).
Best regards,
Adam
--
"I have met a friend of yours." Adam Sjøgren
"A friend?!" asjo@koldfront.dk
"An enemy."
"Ah. Which one?"
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: gnus-article-html and XEmacs 21.5 beta
2010-09-02 11:03 ` Adam Sjøgren
@ 2010-09-03 0:44 ` Katsumi Yamaoka
2010-09-03 18:22 ` Adam Sjøgren
0 siblings, 1 reply; 10+ messages in thread
From: Katsumi Yamaoka @ 2010-09-03 0:44 UTC (permalink / raw)
To: ding
Adam Sjøgren wrote:
> Did you see Aidan Kehoes answer on xemacs-beta to my question about this
> whole process-plist thing and XEmacs?
> * http://article.gmane.org/gmane.emacs.xemacs.beta/33453
> (As I understand it, that would only work in the future, not for older
> emacsen, so it isn't really a solution, I guess).
I noticed process-plist functions got provided in XEmacs 21.5
after updating it last night (before reading neither your message
nor the xemacs-beta list ;-). Though I suspect that it may eat
memory, too.
I've installed the for-only-gnus-html-and-friends version.
Verified it with old XEmacs 21.5 and Emacs 21.1. I'd like to
make gnus-html work for XEmacs 21.4 as well.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: gnus-article-html and XEmacs 21.5 beta
2010-09-03 0:44 ` Katsumi Yamaoka
@ 2010-09-03 18:22 ` Adam Sjøgren
0 siblings, 0 replies; 10+ messages in thread
From: Adam Sjøgren @ 2010-09-03 18:22 UTC (permalink / raw)
To: ding
On Fri, 03 Sep 2010 09:44:33 +0900, Katsumi wrote:
> I've installed the for-only-gnus-html-and-friends version.
> Verified it with old XEmacs 21.5 and Emacs 21.1. I'd like to
> make gnus-html work for XEmacs 21.4 as well.
It works perfectly for me in XEmacs 21.5 beta (hg) - thanks for keeping
us XEmacs-using weirdos in the loop!
Best regards,
Adam
--
"The laws of perspective have been repealed! Adam Sjøgren
Objects no longer diminish in size with distance!" asjo@koldfront.dk
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-09-03 18:22 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-01 20:23 gnus-article-html and XEmacs 21.5 beta Adam Sjøgren
2010-09-01 20:29 ` Lars Magne Ingebrigtsen
2010-09-01 20:49 ` Adam Sjøgren
2010-09-01 20:54 ` Lars Magne Ingebrigtsen
2010-09-02 6:38 ` Katsumi Yamaoka
2010-09-02 6:59 ` Katsumi Yamaoka
2010-09-02 7:34 ` Katsumi Yamaoka
2010-09-02 11:03 ` Adam Sjøgren
2010-09-03 0:44 ` Katsumi Yamaoka
2010-09-03 18:22 ` Adam Sjøgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).