From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63295 Path: news.gmane.org!not-for-mail From: Andreas Seltenreich Newsgroups: gmane.emacs.gnus.general Subject: [PATCH] nnir vs. referring articles Date: Wed, 31 May 2006 21:17:19 +0200 Message-ID: <87pshu57i8.fsf@gate450.dyndns.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1149103348 22961 80.91.229.2 (31 May 2006 19:22:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 31 May 2006 19:22:28 +0000 (UTC) Original-X-From: ding-owner+m11822@lists.math.uh.edu Wed May 31 21:22:25 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FlWGe-0000Xy-UO for ding-account@gmane.org; Wed, 31 May 2006 21:22:09 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1FlWGV-0003EF-00; Wed, 31 May 2006 14:21:59 -0500 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1FlWCI-0003E7-00 for ding@lists.math.uh.edu; Wed, 31 May 2006 14:17:38 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1FlWCB-0008Aq-Az for ding@lists.math.uh.edu; Wed, 31 May 2006 14:17:38 -0500 Original-Received: from smtp1.rz.uni-karlsruhe.de ([129.13.185.217]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1FlWC6-0001Sn-00 for ; Wed, 31 May 2006 21:17:26 +0200 Original-Received: from rzstud2.stud.uni-karlsruhe.de (exim@rzstud2.stud.uni-karlsruhe.de [193.196.41.38]) by smtp1.rz.uni-karlsruhe.de with esmtp (Exim 4.50 #1) id 1FlWC5-0006PZ-S3; Wed, 31 May 2006 21:17:25 +0200 Original-Received: from uwi7 by rzstud2.stud.uni-karlsruhe.de with local (Exim 4.43) id 1FlWC5-0000oA-FE for ding@gnus.org; Wed, 31 May 2006 21:17:25 +0200 Original-To: ding@gnus.org X-Face: $:F<87a[gD1?#R6S3j21cr1&C&7bd63GHC.tSdskUb}hhwG(ci*=D5kJ<_N+p9q(7-,PnG. Et.Yh --=-=-= Hi, isn't the check for a message-id supposed to be in nnir-request-article instead of nnir-retrieve-headers? Trying to refer articles by message-id (gnus-summary-refer-parent-article, etc) ends in an error instead of gnus continuing to process gnus-refer-article-method. regards, andreas 2006-05-31 Andreas Seltenreich * nnir.el (nnir-retrieve-headers, nnir-request-article): Move check for message-id request. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=nnir.el.diff Index: nnir.el =================================================================== RCS file: /usr/local/cvsroot/gnus/contrib/nnir.el,v retrieving revision 7.12 diff -c -r7.12 nnir.el *** nnir.el 29 May 2006 22:13:00 -0000 7.12 --- nnir.el 31 May 2006 19:05:37 -0000 *************** *** 801,811 **** server) (while (not (null artlist)) (setq art (car artlist)) - (or (numberp art) - (nnheader-report - 'nnir - "nnir-retrieve-headers doesn't grok message ids: %s" - art)) (setq artitem (nnir-artlist-article nnir-artlist art)) (setq artrsv (nnir-artitem-rsv artitem)) (setq artfullgroup (nnir-artitem-group artitem)) --- 801,806 ---- *************** *** 854,875 **** (deffoo nnir-request-article (article &optional group server to-buffer) ! (save-excursion ! (let* ((artitem (nnir-artlist-article nnir-artlist ! article)) ! (artfullgroup (nnir-artitem-group artitem)) ! (artno (nnir-artitem-number artitem)) ! ;; Bug? ! ;; Why must we bind nntp-server-buffer here? It won't ! ;; work if `buf' is used, say. (Of course, the set-buffer ! ;; line below must then be updated, too.) ! (nntp-server-buffer (or to-buffer nntp-server-buffer))) ! (set-buffer nntp-server-buffer) ! (erase-buffer) ! (message "Requesting article %d from group %s" ! artno artfullgroup) ! (gnus-request-article artno artfullgroup nntp-server-buffer) ! (cons artfullgroup artno)))) (nnoo-define-skeleton nnir) --- 849,875 ---- (deffoo nnir-request-article (article &optional group server to-buffer) ! (if (stringp article) ! (nnheader-report ! 'nnir ! "nnir-retrieve-headers doesn't grok message ids: %s" ! article) ! (save-excursion ! (let* ((artitem (nnir-artlist-article nnir-artlist ! article)) ! (artfullgroup (nnir-artitem-group artitem)) ! (artno (nnir-artitem-number artitem)) ! ;; Bug? ! ;; Why must we bind nntp-server-buffer here? It won't ! ;; work if `buf' is used, say. (Of course, the set-buffer ! ;; line below must then be updated, too.) ! (nntp-server-buffer (or to-buffer nntp-server-buffer))) ! (set-buffer nntp-server-buffer) ! (erase-buffer) ! (message "Requesting article %d from group %s" ! artno artfullgroup) ! (gnus-request-article artno artfullgroup nntp-server-buffer) ! (cons artfullgroup artno))))) (nnoo-define-skeleton nnir) --=-=-=--