* PATCH: Browse URLs in new window
@ 1999-11-24 20:46 Peter von der Ahé
1999-11-25 0:33 ` Daniel Neri
0 siblings, 1 reply; 6+ messages in thread
From: Peter von der Ahé @ 1999-11-24 20:46 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 119 bytes --]
Hi!
I have noticed that Gnus ignores the variable
browse-url-new-window-p. Please apply the attached patch.
/Peter
[-- Attachment #2: Browse in new window --]
[-- Type: text/x-patch, Size: 1926 bytes --]
diff -rc pgnus-0.98-orig/lisp/ChangeLog pgnus-0.98/lisp/ChangeLog
*** pgnus-0.98-orig/lisp/ChangeLog Fri Nov 5 20:13:54 1999
--- pgnus-0.98/lisp/ChangeLog Wed Nov 24 21:39:09 1999
***************
*** 1,3 ****
--- 1,8 ----
+ 1999-11-24 Peter von der Ahé <nospam2159@daimi.au.dk>
+
+ * gnus-art.el (gnus-button-url): Use browse-url-new-window-p
+ (gnus-button-embedded-url): Ditto
+
Fri Nov 5 19:10:02 1999 Lars Magne Ingebrigtsen <larsi@menja.ifi.uio.no>
* gnus.el: Pterodactyl Gnus v0.98 is released.
diff -rc pgnus-0.98-orig/lisp/gnus-art.el pgnus-0.98/lisp/gnus-art.el
*** pgnus-0.98-orig/lisp/gnus-art.el Fri Nov 5 20:13:54 1999
--- pgnus-0.98/lisp/gnus-art.el Wed Nov 24 21:33:47 1999
***************
*** 4384,4397 ****
;; In Emacs 20, `browse-url-browser-function' may be an alist.
(if (listp browse-url-browser-function)
(browse-url address)
! (funcall browse-url-browser-function address)))
(defun gnus-button-embedded-url (address)
"Browse ADDRESS."
;; In Emacs 20, `browse-url-browser-function' may be an alist.
(if (listp browse-url-browser-function)
(browse-url (gnus-strip-whitespace address))
! (funcall browse-url-browser-function (gnus-strip-whitespace address))))
;;; Next/prev buttons in the article buffer.
--- 4384,4397 ----
;; In Emacs 20, `browse-url-browser-function' may be an alist.
(if (listp browse-url-browser-function)
(browse-url address)
! (funcall browse-url-browser-function address browse-url-new-window-p)))
(defun gnus-button-embedded-url (address)
"Browse ADDRESS."
;; In Emacs 20, `browse-url-browser-function' may be an alist.
(if (listp browse-url-browser-function)
(browse-url (gnus-strip-whitespace address))
! (funcall browse-url-browser-function (gnus-strip-whitespace address) browse-url-new-window-p)))
;;; Next/prev buttons in the article buffer.
[-- Attachment #3: Type: text/plain, Size: 177 bytes --]
--
· Peter von der Ahé · Systems programmer ·
· Office phone: +45 89 42 31 41 · Office: 540.030 ·
· <URL:http://www.daimi.au.dk/~pahe/> ·
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: PATCH: Browse URLs in new window
1999-11-24 20:46 PATCH: Browse URLs in new window Peter von der Ahé
@ 1999-11-25 0:33 ` Daniel Neri
1999-11-25 1:51 ` Daniel Pittman
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Neri @ 1999-11-25 0:33 UTC (permalink / raw)
nospam2159@daimi.au.dk (Peter von der Ahé) writes:
> I have noticed that Gnus ignores the variable
> browse-url-new-window-p. Please apply the attached patch.
Well, I've tried to get a similar patch in, but it was argued that
browse-url should check its own variables. It only does that when
called interactively. Maybe there should be a gnus-specific option
too...
Regards,
/Daniel
--
Daniel Neri
dne@mayonnaise.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH: Browse URLs in new window
1999-11-25 0:33 ` Daniel Neri
@ 1999-11-25 1:51 ` Daniel Pittman
1999-12-01 20:51 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Pittman @ 1999-11-25 1:51 UTC (permalink / raw)
On Thu, 25 Nov 1999, Daniel Neri <dne@mayonnaise.net> wrote:
> nospam2159@daimi.au.dk (Peter von der Ahé) writes:
>
>> I have noticed that Gnus ignores the variable
>> browse-url-new-window-p. Please apply the attached patch.
>
> Well, I've tried to get a similar patch in, but it was argued that
> browse-url should check its own variables. It only does that when
> called interactively. Maybe there should be a gnus-specific option
> too...
The problem is, at least with XEmacs 21.[12], that pGnus calls the value
of 'browse-url-browser-function' directly rather than through the
'browse-url' function. For some reason, unbeknownst to me.
Ideally, calling through the public interface would be nice. Less prone
to breakage as well...
Daniel
--
Without deviation, progress is not possible.
-- Frank Zappa
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: PATCH: Browse URLs in new window
1999-11-25 1:51 ` Daniel Pittman
@ 1999-12-01 20:51 ` Lars Magne Ingebrigtsen
1999-12-02 21:12 ` David S. Goldberg
0 siblings, 1 reply; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 1999-12-01 20:51 UTC (permalink / raw)
Daniel Pittman <daniel@danann.net> writes:
> The problem is, at least with XEmacs 21.[12], that pGnus calls the value
> of 'browse-url-browser-function' directly rather than through the
> 'browse-url' function. For some reason, unbeknownst to me.
This has now been fixed.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH: Browse URLs in new window
1999-12-01 20:51 ` Lars Magne Ingebrigtsen
@ 1999-12-02 21:12 ` David S. Goldberg
1999-12-03 0:27 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: David S. Goldberg @ 1999-12-02 21:12 UTC (permalink / raw)
> Daniel Pittman <daniel@danann.net> writes:
>> The problem is, at least with XEmacs 21.[12], that pGnus calls the
>> value of 'browse-url-browser-function' directly rather than through
>> the 'browse-url' function. For some reason, unbeknownst to me.
> This has now been fixed.
It still doesn't work for me. I wonder if it's a problem with the
browse-url distributed with XEmacs 21.1.7? Near as I can tell I've
got the latest mail-lib package which includes browse-url. Also,
based on the CVS update I did a little while ago, there's one thing
you missed fixing:
in gnus-art.el I still see:
(defun gnus-button-embedded-url (address)
"Browse ADDRESS."
;; In Emacs 20, `browse-url-browser-function' may be an alist.
(if (listp browse-url-browser-function)
(browse-url (gnus-strip-whitespace address))
(funcall browse-url-browser-function (gnus-strip-whitespace address))))
Anyway, my personal fix for this remains:
(defadvice browse-url (around always-do-new-window (url &optional nw) activate)
(ad-set-arg 1 t)
ad-do-it)
--
Dave Goldberg
Post: The Mitre Corporation\MS B325\202 Burlington Rd.\Bedford, MA 01730
Phone: 781-271-3887
Email: dsg@mitre.org
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: PATCH: Browse URLs in new window
1999-12-02 21:12 ` David S. Goldberg
@ 1999-12-03 0:27 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 1999-12-03 0:27 UTC (permalink / raw)
dsg@mitre.org (David S. Goldberg) writes:
> ;; In Emacs 20, `browse-url-browser-function' may be an alist.
> (if (listp browse-url-browser-function)
> (browse-url (gnus-strip-whitespace address))
> (funcall browse-url-browser-function (gnus-strip-whitespace address))))
Yup. Fix in Gnus v5.8.0.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~1999-12-03 0:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-11-24 20:46 PATCH: Browse URLs in new window Peter von der Ahé
1999-11-25 0:33 ` Daniel Neri
1999-11-25 1:51 ` Daniel Pittman
1999-12-01 20:51 ` Lars Magne Ingebrigtsen
1999-12-02 21:12 ` David S. Goldberg
1999-12-03 0:27 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).