Gnus development mailing list
 help / color / mirror / Atom feed
From: Dan Christensen <jdc@uwo.ca>
To: ding@gnus.org
Subject: list level not respected by gnus-group-get-new-news [was: Emacs 28.2 gnus: nntp read marks lost after going offline and online again]
Date: Sun, 25 Jun 2023 20:58:53 -0400	[thread overview]
Message-ID: <87r0pzujhu.fsf_-_@uwo.ca> (raw)
In-Reply-To: <871qhzboe5.fsf@dod.no>

On Jun 25, 2023, Steinar Bang <sb@dod.no> wrote:

>> So are you saying that `2 g' works fine for you, but the code you
>> posted does not work?  That seems really strange.
>
> No. I was trying to say that I observed the exact same behaviour as you did.
>
> Both the function I posted and '2 g' had the same result: groups on
> levels greater than 2 disappeared.
>
> But '3 g' made them reappear (at least the ones on level 3).

In the first message you said that the groups lost their marks, so
I was still under the impression that that was the issue.  If the
groups are just not being *displayed*, then `3 l' will show the groups
on levels <= 3.  Indeed, digging around shows this commit from two
years ago:

  https://github.com/emacs-mirror/emacs/commit/7f9ca3b2f4f1a9800d7557f64e25bb3ee5059cba

where lines 4208-4209 are changed from

  (gnus-group-list-groups (and (numberp arg)
                               (max (car gnus-group-list-mode) arg)))

to

  (gnus-group-list-groups (and (numberp arg) arg))

So the current list level is not taken into account any more.  I also
find this a bit annoying, to tell you the truth.  Even more, the new
code goes on to make this permanent:

    (when gnus-group-use-permanent-levels
      (setq gnus-group-use-permanent-levels (gnus-group-default-level arg)))))

Do others think it makes sense to hide groups currently being displayed
just because I refreshed groups at a lower level?

(I've changed the subject to reflect what's really going on here.)

Dan



  reply	other threads:[~2023-06-26  0:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 14:52 Emacs 28.2 gnus: nntp read marks lost after going offline and online again Steinar Bang
2023-06-19 16:27 ` Steinar Bang
2023-06-19 17:44   ` Steinar Bang
2023-06-19 18:16     ` dick
2023-06-20 17:00       ` Steinar Bang
2023-06-20 18:03         ` dick
2023-06-19 20:09     ` Steinar Bang
2023-06-20 19:24     ` Steinar Bang
2023-06-20 19:52       ` Steinar Bang
2023-06-21  1:39         ` Eric Abrahamsen
2023-06-21 18:46           ` Steinar Bang
2023-06-21 19:54             ` Steinar Bang
2023-06-21 20:05               ` Steinar Bang
2023-06-21 20:45                 ` Steinar Bang
2023-06-21 20:55                   ` Steinar Bang
2023-06-21 22:49                     ` Eric Abrahamsen
2023-06-22 16:55                       ` Steinar Bang
2023-06-25 14:21                         ` Steinar Bang
2023-06-22 13:52                     ` Dan Christensen
2023-06-24  5:52                       ` Steinar Bang
2023-06-25 13:34                         ` Dan Christensen
2023-06-25 14:35                           ` Steinar Bang
2023-06-26  0:58                             ` Dan Christensen [this message]
2023-06-27 17:13                               ` list level not respected by gnus-group-get-new-news [was: Emacs 28.2 gnus: nntp read marks lost after going offline and online again] Steinar Bang
2023-06-19 16:37 ` Emacs 28.2 gnus: nntp read marks lost after going offline and online again dick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0pzujhu.fsf_-_@uwo.ca \
    --to=jdc@uwo.ca \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).