Re: [PATCH] Use IMAP MOVE extension if available

[Nikolaus Rath <Nikolaus@rath.org>]

On Jul 27 2015, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
> diff --git a/lisp/nnimap.el b/lisp/nnimap.el
> index 161a6b4..f8e6e3e 100644
> --- a/lisp/nnimap.el
> +++ b/lisp/nnimap.el
> @@ -489,11 +489,18 @@ textual parts.")
>  		      (when (functionp (nth 2 credentials))
>  			(funcall (nth 2 credentials)))
>  		      ;; See if CAPABILITY is set as part of login
> -		      ;; response.
> -		      (dolist (response (cddr login-result))
> -			(when (string= "CAPABILITY" (upcase (car response)))
> -			  (setf (nnimap-capabilities nnimap-object)
> -				(mapcar #'upcase (cdr response))))))
> +		      ;; response.  If it wasn't, specifically request
> +		      ;; it.
> +		      (when
> +			  (catch 'caps
> +			    (dolist (response (cddr login-result))
> +			      (when (string= "CAPABILITY" (upcase (car response)))
> +				(throw 'caps (setq capabilities (cdr response)))))
> +			    (let ((req (nnimap-command "CAPABILITY")))
> +			      (when (car req)
> +				(throw 'caps (setq capabilities (cdaddr req))))))
> +			(setf (nnimap-capabilities nnimap-object)
> +			      (mapcar #'upcase capabilities))))
>  		  ;; If the login failed, then forget the credentials
>  		  ;; that are now possibly cached.
>  		  (dolist (host (list (nnoo-current-server 'nnimap)


This looks a lot more complex, but as far as I can tell it still
needlessy asks for capabilities if they have been supplied in the
response code of OK response instead of a in separate, untagged
response. So is it really worth the extra complexity, if in many cases
we still issue an explicit CAPABILITY command?

(For everyone unfamiliar with RFC3501, what I mean is that this:

* CAPABILITY IMAP4rev1 AND SOME MORE \r\n
1 OK Logged in\r\n

will be parsed correcly but this:

1 OK [CAPABILITY IMAP4rev1 AND SOME MORE] Logged in\r\n

will still cause Gnus to issue a separate CAPABILITY command).


Best,
-Nikolaus
-- 
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«