Re: gnus uses a cache? And how it affects mairix searches...

[Eric Abrahamsen <eric@ericabrahamsen.net>]

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

Dan Christensen <jdc@uwo.ca> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>>
>>>> Dan Christensen <jdc@uwo.ca> writes:
>>>>
>>>>> In gnus.el, it doesn't list nnmairix at all, but somehow when using
>>>>> nnmairix, an entry for nnmairix gets added to this list, without the
>>>>> virtual keyword (see below).
>>>>
>>>> diff --git a/lisp/nnmairix.el b/lisp/nnmairix.el
>>>> index 0cef699..b2f74e3 100644
>>>> --- a/lisp/nnmairix.el
>>>> +++ b/lisp/nnmairix.el
>>>> @@ -417,7 +417,7 @@ Other back ends might or might not work.")
>>>>  
>>>>  (nnoo-define-basics nnmairix)
>>>>  
>>>> -(gnus-declare-backend "nnmairix" 'mail 'address)
>>>> +(gnus-declare-backend "nnmairix" 'mail 'address 'virtual)
>>>>  
>>>>  (deffoo nnmairix-open-server (server &optional definitions)
>>>>    ;; just set server variables
>>>>
>>>> Andreas.
>>>
>>> After look at this for a while, I do think this is the right solution --
>>> what do you all think? Can someone apply this change?
>>
>> Oh never mind, I guess I didn't look long enough. For any backend
>> declared as virtual, `gnus-cache-possibly-enter-article' will use
>> `nnvirtual-find-group-art' to get the real group name.
>>
>> That means that if a backend is declared 'virtual but isn't actually
>> nnvirtual, the caching mechanism will use the wrong lookup function.
>
> I don't follow you.  Isn't the relevant function gnus-backlog-enter-article,
> which skips the backlog for groups that are declared virtual?
>
> I haven't actually tested the patch and instead simply disabled the
> backlog entirely, but I suspect the patch will work.

Ha, yes! Between then and now I somehow started looking at the wrong
mechanism altogether. Sorry about that.

I've attached patches for both the backlog edit and the nnmairix edit.

Eric



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Mark-nnmairix-as-a-virtual-backend.patch --]
[-- Type: text/x-diff, Size: 796 bytes --]

From 0f70f9fedda2de3a424384272c2e1adfdad9fdd7 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Thu, 13 Nov 2014 08:15:35 +0800
Subject: [PATCH 1/2] Mark nnmairix as a virtual backend

* lisp/nnmairix.el: Add 'virtual to call to `gnus-declare-backend'
---
 lisp/nnmairix.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/nnmairix.el b/lisp/nnmairix.el
index 0cef699..b2f74e3 100644
--- a/lisp/nnmairix.el
+++ b/lisp/nnmairix.el
@@ -417,7 +417,7 @@ Other back ends might or might not work.")
 
 (nnoo-define-basics nnmairix)
 
-(gnus-declare-backend "nnmairix" 'mail 'address)
+(gnus-declare-backend "nnmairix" 'mail 'address 'virtual)
 
 (deffoo nnmairix-open-server (server &optional definitions)
   ;; just set server variables
-- 
2.1.3


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-Disable-backlog-altogethe-for-virtual-groups.patch --]
[-- Type: text/x-diff, Size: 884 bytes --]

From f297d0bdc31e69661ad3e09279e16fd6605da621 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Thu, 13 Nov 2014 08:16:13 +0800
Subject: [PATCH 2/2] Disable backlog altogethe for virtual groups

* lisp/gnus-bcklg.el (gnus-backlog-enter-article): No articles from
  virtual groups should be added to the backlog.
---
 lisp/gnus-bcklg.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/gnus-bcklg.el b/lisp/gnus-bcklg.el
index db80800..eb3c9f0 100644
--- a/lisp/gnus-bcklg.el
+++ b/lisp/gnus-bcklg.el
@@ -61,7 +61,7 @@
 
 (defun gnus-backlog-enter-article (group number buffer)
   (when (and (numberp number)
-	     (not (string-match "^nnvirtual" group)))
+	     (not (gnus-virtual-group-p group)))
     (gnus-backlog-setup)
     (let ((ident (intern (concat group ":" (int-to-string number))
 			 gnus-backlog-hashtb))
-- 
2.1.3