Backtrace from gnus-html-display-image

Backtrace from gnus-html-display-image

[Knut Anders Hatlen]

Hi,

When I try to show remote images in an article using W D W, I get this
backtrace:

Debugger entered--Lisp error: (wrong-number-of-arguments #[(url start end alt-text) "\303\b	\"\203\x0e

Re: Backtrace from gnus-html-display-image

[Knut Anders Hatlen]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

Knut Anders Hatlen <kahatlen@gmail.com> writes:

> Hi,
>
> When I try to show remote images in an article using W D W, I get this
> backtrace:
>
> Debugger entered--Lisp error: (wrong-number-of-arguments #[(url start end alt-text)

Hmm... Not a good idea to include those control characters in the
backtrace, it seems. Don't know if the entire message made it to the
mailing list. It was truncated in Gmane at least.

Anyways, what I was trying to say, was that the attached patch makes
displaying remote images work again by removing some unused parameters
from the function's signature.

-- 
Knut Anders

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: images.diff --]
[-- Type: text/x-patch, Size: 836 bytes --]

diff --git a/lisp/gnus-html.el b/lisp/gnus-html.el
index cb5d3c6..cc3c871 100644
--- a/lisp/gnus-html.el
+++ b/lisp/gnus-html.el
@@ -245,10 +245,10 @@ CHARS is a regexp-like character alternative (e.g., \"[)$]\")."
                                (> height 4))
                            (or (null width)
                                (> width 4)))
-                  (gnus-html-display-image url start end alt-text))))))))))
+                  (gnus-html-display-image url alt-text))))))))))
 
-(defun gnus-html-display-image (url start end alt-text)
-  "Display image at URL on text from START to END.
+(defun gnus-html-display-image (url alt-text)
+  "Display image at URL.
 Use ALT-TEXT for the image string."
   (if (gnus-html-cache-expired url gnus-html-image-cache-ttl)
       ;; We don't have it, so schedule it for fetching

Re: Backtrace from gnus-html-display-image

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

On Sun, Sep 26 2010, Knut Anders Hatlen wrote:

> When I try to show remote images in an article using W D W, I get this
> backtrace:
>
> Debugger entered--Lisp error: (wrong-number-of-arguments #[(url start end alt-text) "\303\b	\"\203\x0e

I'll fix it.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Backtrace from gnus-html-display-image

[Lars Magne Ingebrigtsen]

Knut Anders Hatlen <kahatlen@gmail.com> writes:

> Anyways, what I was trying to say, was that the attached patch makes
> displaying remote images work again by removing some unused parameters
> from the function's signature.

They're not unused -- they're used in other code paths, but I think
Julien forgot to include them from the `W D W' code path.  Or they're
not stashed in the right overlay, or something.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Backtrace from gnus-html-display-image

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

On Sun, Sep 26 2010, Julien Danjou wrote:

> I'll fix it.

Should work now.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Backtrace from gnus-html-display-image

[Knut Anders Hatlen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Knut Anders Hatlen <kahatlen@gmail.com> writes:
>
>> Anyways, what I was trying to say, was that the attached patch makes
>> displaying remote images work again by removing some unused parameters
>> from the function's signature.
>
> They're not unused -- they're used in other code paths, but I think
> Julien forgot to include them from the `W D W' code path.  Or they're
> not stashed in the right overlay, or something.

But gnus-html-display-image doesn't actually use the values in the start
and end parameters, or?

-- 
Knut Anders

Re: Backtrace from gnus-html-display-image

[Knut Anders Hatlen]

Julien Danjou <julien@danjou.info> writes:

> On Sun, Sep 26 2010, Julien Danjou wrote:
>
>> I'll fix it.
>
> Should work now.

W D W works, but I still get the same error if I go to the image link
and press "i".

-- 
Knut Anders

Re: Backtrace from gnus-html-display-image

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

On Sun, Sep 26 2010, Knut Anders Hatlen wrote:

> W D W works, but I still get the same error if I go to the image link
> and press "i".

Should be better.

[ Except that I just see there's another bug somehow. It seems if you
  have 2 overlays, one with local-map and the other one without, the
  local-map is not used. So "i" does not seems to press on images with
  some other overlay.

  I did not dig into it yet, but maybe it'd raise a bell to someone. Or
  maybe I'm wrong. ]

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Backtrace from gnus-html-display-image

[Lars Magne Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> [ Except that I just see there's another bug somehow. It seems if you
>   have 2 overlays, one with local-map and the other one without, the
>   local-map is not used. So "i" does not seems to press on images with
>   some other overlay.

Yes.  If you have a <a> overlay over a <img> overlay, one of the keymaps
go missing.  I've been wondering what to do about that.  There should be
a way to combine the keymaps from all the overlays?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Backtrace from gnus-html-display-image

[Knut Anders Hatlen]

Julien Danjou <julien@danjou.info> writes:

> On Sun, Sep 26 2010, Knut Anders Hatlen wrote:
>
>> W D W works, but I still get the same error if I go to the image link
>> and press "i".
>
> Should be better.

Thanks! Works fine now.

-- 
Knut Anders

Re: Backtrace from gnus-html-display-image

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

On Sun, Sep 26 2010, Lars Magne Ingebrigtsen wrote:

> Yes.  If you have a <a> overlay over a <img> overlay, one of the keymaps
> go missing.  I've been wondering what to do about that.  There should be
> a way to combine the keymaps from all the overlays?

To me, it sounds like an Emacs bug rather than our problem.
But I might be wrong.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Backtrace from gnus-html-display-image

[Lars Magne Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> To me, it sounds like an Emacs bug rather than our problem.
> But I might be wrong.

I think it's how 'local-map is documented to work, actually.  But I may
be wrong.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Backtrace from gnus-html-display-image

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

On Sun, Sep 26 2010, Lars Magne Ingebrigtsen wrote:

> I think it's how 'local-map is documented to work, actually.  But I may
> be wrong.  :-)

You mean, it does not merge anything?

That sounds boring. Eventually we would need some function to merge all
overlays. Pfff…

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]