Gnus development mailing list
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bmork@dod.no>
To: ding@gnus.org
Subject: Re: Comments in References
Date: Fri, 26 Sep 2008 09:22:42 +0200	[thread overview]
Message-ID: <87r677z7zx.fsf@obelix.mork.no> (raw)
In-Reply-To: <87ljxhpaf3.fsf@marauder.physik.uni-ulm.de>

Reiner Steib <reinersteib+gmane@imap.cc> writes:
> On Wed, Sep 24 2008, Andreas Schwab wrote:
>> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>>> On Wed, Sep 24 2008, Andreas Schwab wrote:
>>>> Should gnus-parent-id strip comments, or is this the duty of its
>>>> callers?
>>>
>>> According to it's doc string, I'd say `gnus-parent-id' should strip
>>> it: [...]
>> What about this then?  I've tested it with
>> gmane.linux.kernel.wireless.general, the false orphans are now correctly
>> threaded.
> [...]
>> 	* gnus-util.el (gnus-split-references): Strip comments.
>> 	(gnus-parent-id): Likewise.
>
> Looks good, thank.  Unless someone points out a problem (within ~1
> day), please install[1] it.  I'd say there is no doubt that this
> qualifies as a bug fix (I assume you verified that the RFCs allow
> CFWS).

RFC2822 does allow CFWS before and after a message-id. Quote from
section "3.6.4. Identification fields":


   The message identifier (msg-id) is similar in syntax to an angle-addr
   construct without the internal CFWS.

     message-id      =       "Message-ID:" msg-id CRLF

     in-reply-to     =       "In-Reply-To:" 1*msg-id CRLF

     references      =       "References:" 1*msg-id CRLF

     msg-id          =       [CFWS] "<" id-left "@" id-right ">" [CFWS]



Note that RFC2822 defines the CFWS as part of the msg-id, which IMHO
implies that the gnus-parent-id help text isn't really clear wrt
stripping comments.  Maybe the documentation should be updated to
clearify this?


Bjørn
-- 
Your subtlety reminds me of a sexual fantasy




  reply	other threads:[~2008-09-26  7:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-24 11:44 Andreas Schwab
2008-09-24 17:00 ` Reiner Steib
2008-09-24 18:49   ` Andreas Schwab
2008-09-24 20:16     ` Reiner Steib
2008-09-26  7:22       ` Bjørn Mork [this message]
2008-09-27  8:12         ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r677z7zx.fsf@obelix.mork.no \
    --to=bmork@dod.no \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).