From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67454 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Bj=F8rn_Mork?= Newsgroups: gmane.emacs.gnus.general Subject: Re: Comments in References Date: Fri, 26 Sep 2008 09:22:42 +0200 Organization: Disgusting on Decadent Message-ID: <87r677z7zx.fsf@obelix.mork.no> References: <87hc85qy0z.fsf@marauder.physik.uni-ulm.de> <87ljxhpaf3.fsf@marauder.physik.uni-ulm.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1222414003 9189 80.91.229.12 (26 Sep 2008 07:26:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Sep 2008 07:26:43 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M15904@lists.math.uh.edu Fri Sep 26 09:27:41 2008 connect(): Connection refused Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kj7jl-0000d4-8x for ding-account@gmane.org; Fri, 26 Sep 2008 09:27:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Kj7fL-0006bX-6C; Fri, 26 Sep 2008 02:23:03 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Kj7fJ-0006bN-HM for ding@lists.math.uh.edu; Fri, 26 Sep 2008 02:23:01 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1Kj7fG-0006dI-Jf for ding@lists.math.uh.edu; Fri, 26 Sep 2008 02:23:01 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1Kj7fK-0004xZ-00 for ; Fri, 26 Sep 2008 09:23:02 +0200 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Kj7fA-0006yN-0f for ding@gnus.org; Fri, 26 Sep 2008 07:22:52 +0000 Original-Received: from obelix.mork.no ([148.122.252.2]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 26 Sep 2008 07:22:52 +0000 Original-Received: from bmork by obelix.mork.no with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 26 Sep 2008 07:22:52 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 47 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: obelix.mork.no User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux) Cancel-Lock: sha1:9014cB8v4A+sQLMrNlD7bhn8ek4= X-Spam-Score: -3.6 (---) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67454 Archived-At: Reiner Steib writes: > On Wed, Sep 24 2008, Andreas Schwab wrote: >> Reiner Steib writes: >>> On Wed, Sep 24 2008, Andreas Schwab wrote: >>>> Should gnus-parent-id strip comments, or is this the duty of its >>>> callers? >>> >>> According to it's doc string, I'd say `gnus-parent-id' should strip >>> it: [...] >> What about this then? I've tested it with >> gmane.linux.kernel.wireless.general, the false orphans are now correctly >> threaded. > [...] >> * gnus-util.el (gnus-split-references): Strip comments. >> (gnus-parent-id): Likewise. > > Looks good, thank. Unless someone points out a problem (within ~1 > day), please install[1] it. I'd say there is no doubt that this > qualifies as a bug fix (I assume you verified that the RFCs allow > CFWS). RFC2822 does allow CFWS before and after a message-id. Quote from section "3.6.4. Identification fields": The message identifier (msg-id) is similar in syntax to an angle-addr construct without the internal CFWS. message-id = "Message-ID:" msg-id CRLF in-reply-to = "In-Reply-To:" 1*msg-id CRLF references = "References:" 1*msg-id CRLF msg-id = [CFWS] "<" id-left "@" id-right ">" [CFWS] Note that RFC2822 defines the CFWS as part of the msg-id, which IMHO implies that the gnus-parent-id help text isn't really clear wrt stripping comments. Maybe the documentation should be updated to clearify this? Bjørn -- Your subtlety reminds me of a sexual fantasy