From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65009 Path: news.gmane.org!not-for-mail From: michael@cadilhac.name (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.gnus.general Subject: Highlighting with GPG signed messages. Date: Wed, 01 Aug 2007 16:17:52 +0200 Organization: Epita/LRDE Message-ID: <87r6mn8hkf.fsf@lrde.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: sea.gmane.org 1185978208 24561 80.91.229.12 (1 Aug 2007 14:23:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 1 Aug 2007 14:23:28 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M13519@lists.math.uh.edu Wed Aug 01 16:23:21 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1IGF6Q-0005xL-EQ for ding-account@gmane.org; Wed, 01 Aug 2007 16:23:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1IGF5O-0001Oz-Iu; Wed, 01 Aug 2007 09:22:02 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1IGF5M-0001OV-M3 for ding@lists.math.uh.edu; Wed, 01 Aug 2007 09:22:00 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1IGF5G-0001ah-DJ for ding@lists.math.uh.edu; Wed, 01 Aug 2007 09:22:00 -0500 Original-Received: from ext.lri.fr ([129.175.15.4]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1IGF5F-0000w4-00 for ; Wed, 01 Aug 2007 16:21:53 +0200 Original-Received: from localhost (localhost [127.0.0.1]) by ext.lri.fr (Postfix) with ESMTP id DA2DCA4718 for ; Wed, 1 Aug 2007 16:21:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at lri.fr Original-Received: from ext.lri.fr ([127.0.0.1]) by localhost (ext.lri.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OR3wNl4Dex3P for ; Wed, 1 Aug 2007 16:21:22 +0200 (CEST) Original-Received: from smtp.lri.fr (vhost3-23.lri.fr [129.175.3.23]) by ext.lri.fr (Postfix) with ESMTP id 3FFABA4915 for ; Wed, 1 Aug 2007 16:17:23 +0200 (CEST) Original-Received: from lri4-154 (pc4-154 [129.175.4.154]) by smtp.lri.fr (Postfix) with ESMTP id 83219E04F5 for ; Wed, 1 Aug 2007 16:17:22 +0200 (CEST) X-Website: http://michael.cadilhac.name Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEU/JREXDATg1LV8UCao i1fQpmoP3Nd6AAACa0lEQVQ4jWWUQW7jMAxFqZEPICJzAjXeM6W8dyNqX9ji/a8yn04xnWIEJLD9 LJH85DcJFyJV3erqPty8ExHfBikXSdn0WVezC0hOAQiA2nCsAHOqEnPe4k+puU8zw/t+xquqjRKA 4lHsmQBT8C5pDtBwfwH8VdcHI5+FHtjRxrQRwZsf3hNjZRKAPEzHEdH9mFNSYb5dQK3r8KM6ftNy KikAirDZFWdVkDqbxjGFbAcwbQCxxc8mPRHUGOcCIMgMACV23RfJTch3gC6ofT3qCdG0NyUUPfYF yQrKCIAnuYsgX2qPzW2i9sNrfSOSPPZQiygtCNlCjlpXJV38lIKshF/AZzsAMoArdCKNHfXukPuJ ImbLh+9J2gXwap0QpZ7NjZ7ekdkFcDiqPiLGcHmuvaG/AHgy62s52Lae1ABoA7D6d2kDoAvgbnyD ZutEd6lTHOXfYPHVJDH1K8a1+oyrjoZpAGn1x5pfwPr2E9yjxSpk50/gEyKgD/+BD/KzN3tQ13b8 Cx5loF0AgnZf5IUny9hRHQOYBllHDM+6s3oviZBu77mFjDm621Np3hkjR90wE1BkTYvhdDgDgCmR xWChFfcYAOqMm5NZkVWMur8AL5+oeMQOob2FmY76FiM+PrDDZypwGdqokSlAaQOmGH6mW8KpsOwl 0YOLedjSITr6scNRF8D4PesH33QmLrx8AzjpV/3kkg025w2gfAFYKCLluJAc4Ap+h18oo4S8wzaY klDsBUTiY8EZFkg5Iass75FubC9wd8qa0u9+gRxAsAKEaRAo6iB+vwCMGmdBjvgidQGA1ntMX4CS ZYGV/wADyL80LIX/UAAAAABJRU5ErkJggg== User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:65009 Archived-At: --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Hi=A0! When viewing a GPG signed message, the highlighting of citation and signature isn't made. This is due to the `last' condition for the highlighting to happen in the treatment functions. For example, if you have a two parts message (Text + sig), gnus-mime-display-security is called with the first one and the second part is like discarded. So current-part and total-parts are never equals and `last' is never validated. This is the shortest patch I could came with : Index: lisp/gnus-art.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v retrieving revision 7.222 diff -c -r7.222 gnus-art.el *** lisp/gnus-art.el 20 Jul 2007 11:30:50 -0000 7.222 =2D-- lisp/gnus-art.el 1 Aug 2007 14:11:14 -0000 *************** *** 8042,8048 **** (narrow-to-region (point) (point)) (unless (gnus-unbuttonized-mime-type-p (car handle)) (gnus-insert-mime-security-button handle)) ! (gnus-mime-display-part (cadr handle)) (unless (bolp) (insert "\n")) (unless (gnus-unbuttonized-mime-type-p (car handle)) =2D-- 8042,8051 ---- (narrow-to-region (point) (point)) (unless (gnus-unbuttonized-mime-type-p (car handle)) (gnus-insert-mime-security-button handle)) ! ;; Remove an element in g-a-m-h so that the 'last condition of ! ;; treatment functions can be validated. ! (let ((gnus-article-mime-handles (cdr gnus-article-mime-handles))) ! (gnus-mime-display-part (cadr handle))) (unless (bolp) (insert "\n")) (unless (gnus-unbuttonized-mime-type-p (car handle)) Thanks. =2D-=20 | Micha=EBl `Micha' Cadilhac | Si j'=E9tais sous-secr=E9taire d'= =C9tat | | http://michael.cadilhac.name | aux choux farcis, vous entendriez = | | JID/MSN: | beaucoup parler des choux farcis ! = | `---- michael.cadilhac@gmail.com | -- Nicolas Sarkozy - = --' --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.5 (GNU/Linux) iD8DBQFGsJYRUJhDmOfFA3URAjQgAJ45JrQBe3+hPgjrToNbSi1/1eHT+QCfeks5 psbLvD+FNAiwkkEJ+DRESCs= =llU0 -----END PGP SIGNATURE----- --=-=-=--