message-header-xheader unused, maybe

[Kevin Ryde <user42@zip.com.au>]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

In message.el, the message-header-xheader face seems to be unused.
Is that accidental, or deliberate?


Incidentally, some of the colours in message mode with "dark background"
seem a bit dark to me, like DarkGreen for message-header-name.  Do dark
users find them ok?  I use dark, but only on the console, where in fact
"blue3" in message-separator comes out pretty much unreadable -- but
perhaps that's the fault of "tty-color"s mapping.


2007-05-17  Kevin Ryde  <user42@zip.com.au>

	* message.el (message-font-lock-keywords): Use message-header-xheader
	face for "X-Foo", its apparent intended purpose.  Move "X-" pattern
	ahead of the anything pattern, to get it recognised.

(Note the diff is a bit zany, it's actually a swap of the two forms, not
changes to the patterns.)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: message.el.xheader-face.diff --]
[-- Type: text/x-diff, Size: 881 bytes --]

--- message.el	14 May 2007 08:08:50 +1000	7.212
+++ message.el	17 May 2007 15:18:13 +1000	
@@ -1444,13 +1444,13 @@
        (1 'message-header-name)
        (2 'message-header-newsgroups nil t))
       (,(message-font-lock-make-header-matcher
-	 (concat "^\\([A-Z][^: \n\t]+:\\)" content))
+	 (concat "^\\(X-[A-Za-z0-9-]+:\\|In-Reply-To:\\)" content))
        (1 'message-header-name)
-       (2 'message-header-other nil t))
+       (2 'message-header-xheader))
       (,(message-font-lock-make-header-matcher
-	 (concat "^\\(X-[A-Za-z0-9-]+:\\|In-Reply-To:\\)" content))
+	 (concat "^\\([A-Z][^: \n\t]+:\\)" content))
        (1 'message-header-name)
-       (2 'message-header-name))
+       (2 'message-header-other nil t))
       ,@(if (and mail-header-separator
 		 (not (equal mail-header-separator "")))
 	    `((,(concat "^\\(" (regexp-quote mail-header-separator) "\\)$")