Re: funny problems with nnmail-cache and split-fancy-with-parent

[Josh Huber <huber@alum.wpi.edu>]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> Strange.  I don't know why that could be.  But you could trace the
> relevant code...

Well, here's the problem.  In nnmail-cache-insert --

    (let ((g nil))
      (cond (grp
	     (setq g grp))
	    ((and (boundp 'group) group)
	     (setq g group))
	    ((and (boundp 'group-art-list) group-art-list
		  (listp group-art-list))
	     (setq g (caar group-art-list)))
	    ((and (boundp 'group-art) group-art (listp group-art))
	     (setq g (caar group-art)))
	    (t (setq g "")))

group is bound to "misc" (almost always).  (caar group-art) returns
the correct group name for splitting, but since this logic checks
group first, it gets the wrong value.

diff -u -r6.39 nnmail.el
--- lisp/nnmail.el	2002/04/29 20:08:18	6.39
+++ lisp/nnmail.el	2002/05/07 14:29:55
@@ -1469,13 +1469,13 @@
     (let ((g nil))
       (cond (grp
 	     (setq g grp))
+	    ((and (boundp 'group-art) group-art (listp group-art))
+	     (setq g (caar group-art)))
 	    ((and (boundp 'group) group)
 	     (setq g group))
 	    ((and (boundp 'group-art-list) group-art-list
 		  (listp group-art-list))
 	     (setq g (caar group-art-list)))
-	    ((and (boundp 'group-art) group-art (listp group-art))
-	     (setq g (caar group-art)))
 	    (t (setq g "")))
       (unless (gnus-buffer-live-p nnmail-cache-buffer)
 	(nnmail-cache-open))

Works for me, but after looking at this -- shouldn't there be a better
interface into nnmail-cache-insert?  We should go through and find all
the places which call it, which is only 10 places, and use the
optional argument for group name if possible.  checking for bound
symbols and using heuristics to get the group name seems a little
hackish to me ;)  (no offense to Kai!)

ttyl,

-- 
Josh Huber