Gnus development mailing list
 help / color / mirror / Atom feed
From: Dan Christensen <jdc@uwo.ca>
To: ding@gnus.org
Subject: Re: problem with (display . [not expire]) with git emacs
Date: Fri, 02 Feb 2024 09:58:36 -0500	[thread overview]
Message-ID: <87sf2aoqub.fsf@uwo.ca> (raw)
In-Reply-To: <87cytfkecx.fsf@ericabrahamsen.net>

On Feb  1, 2024, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:

> I just tried it out, and actually got a popup buffer with the "Malformed
> function" error you mentioned in your first message.

Glad to hear that it's not just me.  I wish I could get that pop-up as
well, or that I could make emacs enter the debugger when this happens.
It would be easier to figure out that way.  Any idea why we would have
different behaviour here?

> Looks like the culprit is effectively this:
>
> (gnus-byte-compile
>   `(lambda ()
>     ,(cdr (assoc 'expire gnus-summary-display-cache))))

I think it's like that but with '(not expire).  When the predicate
is a single symbol, it looks like this code skips byte compilation:

    (if (and (= (length func) 1)
	     (symbolp (car func)))
	(car func)
      (gnus-byte-compile `(lambda () ,func)))))

(But I'm not sure how (display . expire) results in a *list* of length
one.)  Can you confirm that you don't get the error with (display . expire)?

Do you think the issue is that we're trying to byte-compile an already
compiled function?  Do you think the commit I referenced introduces a
bug, or that it reveals an existing bug in Gnus?  Do you suggest that
I post to an emacs devel list, or can we fix it here?

Dan



  reply	other threads:[~2024-02-02 15:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 20:10 Dan Christensen
2024-01-31 23:41 ` Dan Christensen
2024-02-01 22:29   ` Eric Abrahamsen
2024-02-02 14:58     ` Dan Christensen [this message]
2024-02-05 13:47       ` Dan Christensen
2024-02-05 15:18         ` Eric Abrahamsen
2024-02-01 22:33   ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf2aoqub.fsf@uwo.ca \
    --to=jdc@uwo.ca \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).