Gnus development mailing list
 help / color / mirror / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: 21071@debbugs.gnu.org
Cc: ding <ding@gnus.org>,  Nikolaus Rath <Nikolaus@rath.org>
Subject: Re: bug#21071: Gnus message flags must be set before expiration, not afterwards
Date: Thu, 26 Jan 2017 20:43:53 +0100	[thread overview]
Message-ID: <87sho5obd2.fsf@gnus.org> (raw)
In-Reply-To: <87bncbu2un.fsf@vostro.rath.org> (Nikolaus Rath's message of "Tue, 06 Oct 2015 14:03:12 -0700")

Nikolaus Rath <Nikolaus@rath.org> writes:

> I did not find any specific guarantees on when
> gnus-summary-prepare-exit-hook is called in the documentation, but that
> doesn't mean that people are not relying on the current calling
> order. Would a change like that nevertheless be acceptable?
>
> Alternatively, is what do people think about removing
> gnus-summary-expire-articles from the default value of
> gnus-summary-prepare-exit-hook and explicitly calling
> gnus-summary-expire-articles from gnus-summary-exit?

I don't know why that function is in that hook by default; it seems
kinda messy.  But removing things from hooks isn't that easy since
people add things, or set values explicitly.

But we could call gnus-summary-expire-articles in the natural place
unless it's in that hook, perhaps?  And then remove it from the default
value and hope for the best.

Patches welcome.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2017-01-26 19:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  0:14 Nikolaus Rath
2015-07-16  0:21 ` Glenn Morris
2015-07-16  8:49   ` Steinar Bang
     [not found]   ` <87fv4p2b9n.fsf@vostro.rath.org>
2015-10-06 21:03     ` Nikolaus Rath
2017-01-26 19:43       ` Lars Ingebrigtsen [this message]
2019-09-27 16:04       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sho5obd2.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=21071@debbugs.gnu.org \
    --cc=Nikolaus@rath.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).