Gnus development mailing list
 help / color / mirror / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: ding@gnus.org
Subject: Re: nnir, gnus-goto-article and such
Date: Thu, 29 Sep 2011 03:27:05 -0500	[thread overview]
Message-ID: <87sjnfn486.fsf@lifelogs.com> (raw)
In-Reply-To: <m2aa9odrv6.fsf@pluto.luannocracy.com>

On Wed, 28 Sep 2011 22:06:37 -0400 Dave Abrahams <dave@boostpro.com> wrote: 

DA> So, thanks, you seem to have gotten me over one hump... here's my patch:
DA> 	Modified   lisp/gnus-sum.el
DA> diff --git a/lisp/gnus-sum.el b/lisp/gnus-sum.el
DA> index 423de35..8452bb9 100644
DA> --- a/lisp/gnus-sum.el
DA> +++ b/lisp/gnus-sum.el
DA> @@ -9077,6 +9077,13 @@ non-numeric or nil fetch the number specified by the
DA>  		       (setq number (gnus-summary-insert-subject message-id)))
DA>  	      ;; and display the article.
DA>  	      (gnus-summary-select-article nil nil nil number)
DA> +              (when (bound-and-true-p gnus-registry-install)
DA> +                (let ((header (gnus-summary-article-header (gnus-summary-article-number))))
DA> +                  (gnus-registry-handle-action
DA> +                   message-id nil
DA> +                   (gnus-method-to-full-server-name gnus-override-method)
DA> +                   (mail-header-subject header)
DA> +                   (mail-header-from header))))
DA>  	      (throw 'found t)))
DA>  	  (gnus-message 3 "Couldn't fetch article %s" message-id)))))))

DA> But now, of course, gnus-warp-to-article doesn't consult the registry to
DA> find out the article's group, so `A T' still fails.  For some reason, it
DA> goes directly to the backend, only one of which supports warping: nnir.

I think you need to explicitly enable nnregistry so that will work (see
the comments).  Perhaps it should be automatically loaded when the Gnus
registry is initialized.  Andy Cohen did that work IIRC so I don't know
if there are any reasons not to do it.  It seems reasonable to me.

DA> [Aside: it seems like this territory is full of components that could in
DA> principle be nicely generalized, but whose implementation has only been
DA> made to work for one specific usage scenario]

I can't tell, I was not involved with writing these components.  At
least for the registry I know it's optional so we can't depend on it.

Ted




  reply	other threads:[~2011-09-29  8:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 18:24 Dave Abrahams
2011-09-16 15:05 ` gnus-warp-to-article (was: nnir, gnus-goto-article and such) Dave Abrahams
2011-09-21 18:03 ` nnir, gnus-goto-article and such Lars Magne Ingebrigtsen
2011-09-21 21:16   ` John Wiegley
2011-09-22 13:01     ` Andrew Cohen
2011-09-26 19:17       ` Lars Magne Ingebrigtsen
2011-09-26 20:46       ` Dave Abrahams
2011-09-27  7:04         ` John Wiegley
2011-09-27 15:36           ` Dave Abrahams
2011-09-26 20:01   ` Dave Abrahams
2011-09-26 21:35     ` Ted Zlatanov
2011-09-27 15:35       ` Dave Abrahams
2011-09-27 21:12         ` Ted Zlatanov
2011-09-28 14:34           ` Dave Abrahams
2011-09-29  0:32             ` Ted Zlatanov
2011-09-29  1:19               ` Dave Abrahams
2011-09-29  2:06                 ` Dave Abrahams
2011-09-29  8:27                   ` Ted Zlatanov [this message]
2011-09-29 13:40                     ` Dave Abrahams
2011-09-29 14:00                       ` Ted Zlatanov
2011-09-29 14:40                         ` Dave Abrahams
2011-09-29 14:58                           ` Ted Zlatanov
2011-09-29 20:04                             ` Dave Abrahams
2011-09-29 23:40                               ` Ted Zlatanov
2011-09-29  8:22                 ` Ted Zlatanov
2011-09-27 16:04       ` Dave Abrahams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjnfn486.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).