Gnus development mailing list
 help / color / mirror / Atom feed
From: Dan Christensen <jdc@uwo.ca>
To: ding@gnus.org
Subject: Re: Gnus registry upgrade didn't import old registry
Date: Mon, 26 Sep 2011 22:35:25 -0400	[thread overview]
Message-ID: <87sjnizp8y.fsf@uwo.ca> (raw)
In-Reply-To: <87fwjizqbc.fsf@uwo.ca>

Dan Christensen <jdc@uwo.ca> writes:

>> I have max-entries at 100000, could you try that?  
>
> I did
>
> (setq gnus-registry-max-entries 100000)
>
> and still I get the error when trying to import my old .eld file
> with 10000 entries.  And still
>
> (registry-size gnus-registry-db)
> 10000

I restarted emacs with the increased value in my .gnus.el, and
then it worked.  But I fear this is just delaying the problem for a
decade or two.  

Here's my guess at the bug:

In gnus-registry.el:

(defun gnus-registry-fixup-registry (db)
  (when db
    (let ((old (oref db :tracked)))
...
      (oset db :max-hard
            (or gnus-registry-max-entries
                most-positive-fixnum))
...
      (oset db :max-soft
            (or gnus-registry-max-pruned-entries
                most-positive-fixnum))

If the user sets gnus-registry-max-entries but not
gnus-registry-max-pruned-entries, then the soft limit might be (much)
higher than the hard limit.  Maybe the last line should be changed to
replace `most-positive-fixnum' with something like `(oget db :max-hard)'
(just guessing at how to read a stored value).

Dan




  reply	other threads:[~2011-09-27  2:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-13 14:59 Dan Christensen
2011-09-26 20:25 ` Ted Zlatanov
2011-09-26 20:37   ` Dan Christensen
2011-09-26 20:50     ` Dan Christensen
2011-09-26 22:02       ` Ted Zlatanov
2011-09-27  2:12         ` Dan Christensen
2011-09-27  2:35           ` Dan Christensen [this message]
2011-09-27 21:25             ` Ted Zlatanov
2011-09-28  2:43               ` Dan Christensen
2011-09-29  0:37                 ` Ted Zlatanov
2011-09-27 10:42           ` Ted Zlatanov
2011-09-26 20:41   ` Dan Christensen
2011-09-26 21:57     ` Ted Zlatanov
2011-09-27  2:07       ` Dan Christensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjnizp8y.fsf@uwo.ca \
    --to=jdc@uwo.ca \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).