Re: How do I get bigger gravatars (setting gravatar-size doesn't cut it)?

["Štěpán Němec" <stepnem@gmail.com>]

Julien Danjou <julien@danjou.info> writes:

> On Mon, Nov 29 2010, Štěpán Němec wrote:
>
>> ISTM better would be making `gnus-gravatar-size' nil by default, meaning
>> to just use `gravatar-size'. Thoughts?
>
> Sounds right. Done.

Thanks.

Another glitch I noticed: you encode the name in
`gnus-gravatar-transform-address', but then don't decode it in
`gnus-gravatar-insert', meaning the search fails and gravatars don't
work for non-ascii names (such as mine ;-)).

You also don't need to bind `inhibit-read-only' to t inside
`gnus-with-article-headers', as the latter already does that.

This works for me:

diff --git a/lisp/gnus/gnus-gravatar.el b/lisp/gnus/gnus-gravatar.el
index a6ecd43..beb661f 100644
--- a/lisp/gnus/gnus-gravatar.el
+++ b/lisp/gnus/gnus-gravatar.el
@@ -85,7 +85,8 @@ (defun gnus-gravatar-insert (gravatar header address category)
       (when (buffer-live-p (current-buffer))
         (gnus-article-goto-header header)
         (mail-header-narrow-to-field)
-        (let ((real-name (cdr address))
+        (let ((real-name (when (cdr address)
+                           (mail-decode-encoded-word-string (cdr address))))
               (mail-address (car address)))
           (when (if real-name             ; have a realname, go for it!
                     (and (search-forward real-name nil t)
@@ -101,8 +102,7 @@ (defun gnus-gravatar-insert (gravatar header address category)
             ;; example we were fetching someaddress, and then we change to
             ;; another mail with the same someaddress.
             (unless (memq 'gnus-gravatar (text-properties-at (point)))
-              (let ((inhibit-read-only t)
-                    (point (point)))
+              (let ((point (point)))
                 (unless (featurep 'xemacs)
                   (setq gravatar (append gravatar gnus-gravatar-properties)))
                 (gnus-put-image gravatar nil category)