From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/74554 Path: news.gmane.org!not-for-mail From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= Newsgroups: gmane.emacs.gnus.general Subject: Re: How do I get bigger gravatars (setting gravatar-size doesn't cut it)? Date: Tue, 30 Nov 2010 16:33:19 +0100 Message-ID: <87sjyi7rnk.fsf@gmail.com> References: <8762vg835x.fsf@gmail.com> <871v639668.fsf@gmail.com> <8762vfp3mb.fsf@keller.adm.naquadah.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1291132266 31866 80.91.229.12 (30 Nov 2010 15:51:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 30 Nov 2010 15:51:06 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M22912@lists.math.uh.edu Tue Nov 30 16:51:01 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PNSTr-0004sn-DZ for ding-account@gmane.org; Tue, 30 Nov 2010 16:50:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1PNSTN-0007HH-68; Tue, 30 Nov 2010 09:50:29 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1PNSEd-00076c-6a for ding@lists.math.uh.edu; Tue, 30 Nov 2010 09:35:15 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1PNSEb-0007IF-FF for ding@lists.math.uh.edu; Tue, 30 Nov 2010 09:35:15 -0600 Original-Received: from mail-bw0-f44.google.com ([209.85.214.44]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1PNSEa-0006os-00 for ; Tue, 30 Nov 2010 16:35:12 +0100 Original-Received: by bwz12 with SMTP id 12so5186886bwz.17 for ; Tue, 30 Nov 2010 07:35:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:in-reply-to :references:user-agent:date:message-id:mime-version:content-type :content-transfer-encoding; bh=1EluMBlgVr3ydShSId9i3GHRZRSnXg1fYczQZ3t7awI=; b=IJc1t9Kx3InS+IFq4uUEvqJRbkJQKqEPeFk6d087jBapZr1e5o5De2R/AueqEorxYX CqjjI/Tk1SpAM/ibGdi2qWff4OWZtst94RWc/6s7X+fT+piriod9oy2pfEn/LE4XvWhi 2VUsud15KqKV3j4sPHet8Rtmz5kFnzQcOQrYY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type:content-transfer-encoding; b=scYEPUdrDip13d0bo1YTU5SAc4h8Gn75Jh1wwyWokZ7u/DUOQIRGN4JSMMn7q8TSKj zBYzHsPA7Mw6Kj19qqWlSliKHGVFL9oeSZOQBN19tAmt+PGrLIa9Ybe4n7T2czT+Rgeg dLp9+SmCbYUAJbZUi56I28bij9kU2WjW3QrHY= Original-Received: by 10.204.113.211 with SMTP id b19mr4505561bkq.180.1291131312020; Tue, 30 Nov 2010 07:35:12 -0800 (PST) Original-Received: from localhost (176.119.broadband10.iol.cz [90.177.119.176]) by mx.google.com with ESMTPS id p22sm2774309bkp.9.2010.11.30.07.35.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 30 Nov 2010 07:35:09 -0800 (PST) In-Reply-To: <8762vfp3mb.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Tue, 30 Nov 2010 10:22:52 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Spam-Score: -2.0 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:74554 Archived-At: Julien Danjou writes: > On Mon, Nov 29 2010, =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec wrote: > >> ISTM better would be making `gnus-gravatar-size' nil by default, meaning >> to just use `gravatar-size'. Thoughts? > > Sounds right. Done. Thanks. Another glitch I noticed: you encode the name in `gnus-gravatar-transform-address', but then don't decode it in `gnus-gravatar-insert', meaning the search fails and gravatars don't work for non-ascii names (such as mine ;-)). You also don't need to bind `inhibit-read-only' to t inside `gnus-with-article-headers', as the latter already does that. This works for me: diff --git a/lisp/gnus/gnus-gravatar.el b/lisp/gnus/gnus-gravatar.el index a6ecd43..beb661f 100644 --- a/lisp/gnus/gnus-gravatar.el +++ b/lisp/gnus/gnus-gravatar.el @@ -85,7 +85,8 @@ (defun gnus-gravatar-insert (gravatar header address cate= gory) (when (buffer-live-p (current-buffer)) (gnus-article-goto-header header) (mail-header-narrow-to-field) - (let ((real-name (cdr address)) + (let ((real-name (when (cdr address) + (mail-decode-encoded-word-string (cdr address))= )) (mail-address (car address))) (when (if real-name ; have a realname, go for it! (and (search-forward real-name nil t) @@ -101,8 +102,7 @@ (defun gnus-gravatar-insert (gravatar header address ca= tegory) ;; example we were fetching someaddress, and then we change to ;; another mail with the same someaddress. (unless (memq 'gnus-gravatar (text-properties-at (point))) - (let ((inhibit-read-only t) - (point (point))) + (let ((point (point))) (unless (featurep 'xemacs) (setq gravatar (append gravatar gnus-gravatar-properties= ))) (gnus-put-image gravatar nil category)