Re: Recentering during article scrolling with scroll-margin

[Ralf Angeli <angeli@caeruleus.net>]

* Katsumi Yamaoka (2008-08-11) writes:

> I tried (setq scroll-margin 3) on the latest Emacs 22.0.50 and
> 23.0.60 and confirmed this fix is necessary for the case where
> `gnus-article-over-scroll' is nil (the default).

Thanks for confirming.

>> If necessary I can provide a change log entry for such a change.
>
> Please provide it and I'll commit the slightly modified one like:
>
> (move-to-window-line (if (featurep 'xemacs) -1 (- -1 scroll-margin)))
>
> (Note that there is no `scroll-margin' control in XEmacs.)

Okay, here is a change log entry and a patch:

2008-08-11  Ralf Angeli  <angeli@caeruleus.net>

	* gnus-art.el (gnus-article-next-page): Respect `scroll-margin' when
	moving point to the bottom of the window in order to avoid recentering.


--- gnus-art.el.~7.279.~	2008-08-03 12:03:34.000000000 +0200
+++ gnus-art.el	2008-08-11 18:30:35.000000000 +0200
@@ -6113,7 +6113,7 @@
 If end of article, return non-nil.  Otherwise return nil.
 Argument LINES specifies lines to be scrolled up."
   (interactive "p")
-  (move-to-window-line -1)
+  (move-to-window-line (if (featurep 'xemacs) -1 (- -1 scroll-margin)))
   (if (and (not (and gnus-article-over-scroll
 		     (> (count-lines (window-start) (point-max))
 			(+ (or lines (1- (window-height)))


-- 
Ralf