From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67223 Path: news.gmane.org!not-for-mail From: Ralf Angeli Newsgroups: gmane.emacs.gnus.general Subject: Re: Recentering during article scrolling with scroll-margin Date: Mon, 11 Aug 2008 18:35:07 +0200 Message-ID: <87sktb8q84.fsf@photon.caeruleus.net> References: <878wv52p9o.fsf@photon.caeruleus.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1218472610 19685 80.91.229.12 (11 Aug 2008 16:36:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Aug 2008 16:36:50 +0000 (UTC) Cc: ding@gnus.org To: Katsumi Yamaoka Original-X-From: ding-owner+M15677@lists.math.uh.edu Mon Aug 11 18:37:41 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1KSaOn-0007lc-Kx for ding-account@gmane.org; Mon, 11 Aug 2008 18:37:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1KSaN0-0001Gz-UC; Mon, 11 Aug 2008 11:35:46 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1KSaMz-0001Gr-Vv for ding@lists.math.uh.edu; Mon, 11 Aug 2008 11:35:45 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1KSaMv-00042I-V6 for ding@lists.math.uh.edu; Mon, 11 Aug 2008 11:35:45 -0500 Original-Received: from moutng.kundenserver.de ([212.227.126.186]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1KSaMv-0000y6-00 for ; Mon, 11 Aug 2008 18:35:41 +0200 Original-Received: from photon.caeruleus.net (p54A526DF.dip0.t-ipconnect.de [84.165.38.223]) by mrelayeu.kundenserver.de (node=mrelayeu6) with ESMTP (Nemesis) id 0ML29c-1KSaMO2sAq-0001mT; Mon, 11 Aug 2008 18:35:09 +0200 In-Reply-To: (Katsumi Yamaoka's message of "Mon, 11 Aug 2008 11:51:54 +0900") X-Provags-ID: V01U2FsdGVkX1/e+RqMGCbkHJ6Co1jFh6rK/CiUpOkmuq3hxJo eNcuf7y1tzYsAgSWOk6gpcENJdTEtXL+felw/ae2iIiebsrNd8 E7qCiUwjWj+JRp7VFcWWg== X-Spam-Score: 0.0 (/) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67223 Archived-At: * Katsumi Yamaoka (2008-08-11) writes: > I tried (setq scroll-margin 3) on the latest Emacs 22.0.50 and > 23.0.60 and confirmed this fix is necessary for the case where > `gnus-article-over-scroll' is nil (the default). Thanks for confirming. >> If necessary I can provide a change log entry for such a change. > > Please provide it and I'll commit the slightly modified one like: > > (move-to-window-line (if (featurep 'xemacs) -1 (- -1 scroll-margin))) > > (Note that there is no `scroll-margin' control in XEmacs.) Okay, here is a change log entry and a patch: 2008-08-11 Ralf Angeli * gnus-art.el (gnus-article-next-page): Respect `scroll-margin' when moving point to the bottom of the window in order to avoid recentering. --- gnus-art.el.~7.279.~ 2008-08-03 12:03:34.000000000 +0200 +++ gnus-art.el 2008-08-11 18:30:35.000000000 +0200 @@ -6113,7 +6113,7 @@ If end of article, return non-nil. Otherwise return nil. Argument LINES specifies lines to be scrolled up." (interactive "p") - (move-to-window-line -1) + (move-to-window-line (if (featurep 'xemacs) -1 (- -1 scroll-margin))) (if (and (not (and gnus-article-over-scroll (> (count-lines (window-start) (point-max)) (+ (or lines (1- (window-height))) -- Ralf