Gnus development mailing list
 help / color / mirror / Atom feed
From: dme@dme.org
Cc: ding@gnus.org
Subject: Re: someone broke message-newline-and-reformat
Date: 13 Nov 2000 12:17:55 +0000	[thread overview]
Message-ID: <87snowukuk.fsf@serafina-pekkala.dme.org> (raw)
In-Reply-To: <ey3dgw9mfw.fsf@video.uic.vsu.ru>

* vvv@vvv.vsu.ru [2000-11-13 10:49:07]
| did you ever test your patch before committing it?!

Obviously not sufficiently ! The change isn't committed yet.

| 1) a hack in message-newline-and-reformat that should be removed
|    (reverted):
| 
| -      (insert quoted))
| +      (insert quoted " "))

The regexp I used didn't consume the space(s) at the end of the
citation in the tests, so this was required.

| 2) the new value of message-cite-prefix-regexp is the reason why
|    message-newline-and-reformat still does not work. i propose the
|    following:
| 
| (setq message-cite-prefix-regexp "[ \t]*\\w*>+[ \t]*\\|[
| \t]*[]>»|:}+ ]*[]>»|:}+][ \t]*")

This works for m-n-a-f, but it has a bad effect if used for citation
highlighting in message-mode (something else I've been looking at).
Sigh.

| (setq message-cite-prefix-regexp "[ \t]*\\(\\w\\|[-._]\\)*>+[
| \t]*\\|[ \t]*[]>»|:}+ ]*[]>»|:}+][ \t]*")

I'll play with the two new regexps and post another patch later.

dme.



  reply	other threads:[~2000-11-13 12:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-10 11:39 Vladimir Volovich
2000-11-10 12:20 ` dme
2000-11-10 12:58 ` dme
2000-11-10 15:16   ` Vladimir Volovich
2000-11-10 15:37     ` dme
2000-11-10 16:52     ` Kai Großjohann
2000-11-11 18:35       ` dme
2000-11-11 22:38         ` Kai Großjohann
2000-11-12 11:21         ` dme
2000-11-13 10:49     ` Vladimir Volovich
2000-11-13 12:17       ` dme [this message]
2000-11-13 12:23     ` Vladimir Volovich
2000-11-10 11:46 Vladimir Volovich
2000-11-17 11:42 Vladimir Volovich
2000-11-17 11:51 ` dme
2000-11-17 13:09   ` ShengHuo ZHU
2000-11-17 13:09 ` ShengHuo ZHU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87snowukuk.fsf@serafina-pekkala.dme.org \
    --to=dme@dme.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).