From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/26672 Path: main.gmane.org!not-for-mail From: "Rene H. Larsen" Newsgroups: gmane.emacs.gnus.general Subject: Re: message.el: mail-host-address ignored Date: 11 Nov 1999 19:45:53 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: <87so2chnoe.fsf@worldonline.dk> References: <87n1slizjk.fsf@worldonline.dk> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: main.gmane.org 1035163837 20651 80.91.224.250 (21 Oct 2002 01:30:37 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 01:30:37 +0000 (UTC) Return-Path: Original-Received: from lisa.math.uh.edu (lisa.math.uh.edu [129.7.128.49]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id NAA21087 for ; Thu, 11 Nov 1999 13:48:13 -0500 (EST) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by lisa.math.uh.edu (8.9.1/8.9.1) with ESMTP id MAB05888; Thu, 11 Nov 1999 12:48:10 -0600 (CST) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Thu, 11 Nov 1999 12:47:49 -0600 (CST) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id MAA09524 for ; Thu, 11 Nov 1999 12:47:38 -0600 (CST) Original-Received: from fe060.worldonline.dk (fe060.worldonline.dk [212.54.64.207]) by sclp3.sclp.com (8.8.5/8.8.5) with SMTP id NAA21078 for ; Thu, 11 Nov 1999 13:47:07 -0500 (EST) Original-Received: (qmail 16881 invoked by uid 0); 11 Nov 1999 18:47:03 -0000 Original-Received: from 38.ppp1-15.image.dk (HELO izzlazz.ournet.dk) (212.54.76.166) by fe060.worldonline.dk with SMTP; 11 Nov 1999 18:47:03 -0000 Original-Received: from renehl.ournet.dk [192.168.0.1] (mail) by izzlazz.ournet.dk with esmtp (Exim 3.03 #1 (Debian)) id 11lzEI-0001v5-00; Thu, 11 Nov 1999 19:45:54 +0100 Original-Received: from renehl by renehl.ournet.dk with local (Exim 3.03 #1 (Debian)) id 11lzEH-00021h-00; Thu, 11 Nov 1999 19:45:53 +0100 Original-To: ding@gnus.org In-Reply-To: Toby Speight's message of "11 Nov 1999 12:41:00 +0000" Original-Lines: 46 User-Agent: Gnus/5.070099 (Pterodactyl Gnus v0.99) XEmacs/21.1 (Bryce Canyon) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:26672 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:26672 --=-=-= Toby Speight writes: > Rene> Rene H. Larsen > > 0> In article <87n1slizjk.fsf@worldonline.dk>, Rene wrote: > > Rene> This came up on the list about 2 months ago, but nothing was done > Rene> about it. This patch against current CVS will fix the message-id > Rene> generation to match the documentation: > Rene> > Rene> --- message.el.orig Sat Nov 6 04:15:15 1999 > Rene> +++ message.el Thu Nov 11 02:25:28 1999 [...] > But doesn't this mean that on a network of machines that share a > mail-host-address (quite common IME), that there's a much greater > chance of ID collision? Oh, I hadn't thought of this. I was writing this from the perspective of a user on a stand-alone machine. > Don't use mail-host-address for what it's not intended for - it's > okay by me as a fallback, but as you have it, there's no way to use > it for its intended purpose without getting the undesirable > message-id behaviour. What exactly is the intended purpose? The doc-string simply says: *Name of this machine, for purposes of naming users. Oh, I see from the code in message.el that this is used to create the email address if user-mail-address is not set. > Create a new variable instead, if you must (message-id-host). Ok, (small) patch follows: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=pgnus-message.el-mail-host-address-fix-try2.patch Content-Description: Better fix for message-make-fqdn --- message.el.orig Sat Nov 6 04:15:15 1999 +++ message.el Thu Nov 11 19:39:26 1999 @@ -2939,6 +2939,12 @@ (let ((system-name (system-name)) (user-mail (message-user-mail-address))) (cond + ;; First check if `message-id-host' is set and valid. + ((and (boundp 'message-id-host) + (stringp message-id-host) + (string-match "\\." message-id-host)) + message-id-host) + ;; Then try `system-name'. ((string-match "[^.]\\.[^.]" system-name) ;; `system-name' returned the right result. system-name) --=-=-= Note that this does not add documentation nor customize support. I don't really grok the elisp side of customize yet. -- Echelon bait: cracking COSCO genetic Marxist clones NORAD Peking Area 51 CIA David John Oates Kennedy NWO smuggle Serbian counter-intelligence --=-=-=--