MIME error with pgnus 0.96

MIME error with pgnus 0.96

[Thomas H. Olsen]

        I tried to send a picture yesterday using pgnus 0.96.  When I
try to read the message with pine or Netscape I get an error message
like "Formatting error: Non-hexadecimal character in QP encoding."  This
bug was not present in version 0.95.

        THO

-- 

Thomas Olsen                            mailto:tolsen@nas.nasa.gov
MCAT, Inc.                               Phone: (650)604-1043
NASA Ames Research Center                  Fax: (650)604-2238

Re: MIME error with pgnus 0.96

[Mark Buda]

>>>>> "Thomas" == Thomas H Olsen <tolsen@nas.nasa.gov> writes:

    Thomas>         I tried to send a picture yesterday using pgnus
    Thomas> 0.96.  When I try to read the message with pine or
    Thomas> Netscape I get an error message like "Formatting error:
    Thomas> Non-hexadecimal character in QP encoding."  This bug was
    Thomas> not present in version 0.95.

Both quoted-printable and base64 encodings appear to be broken in 0.96.
-- 
I get my monkeys for nothing and my chimps for free.
http://www.clark.net/pub/hermit/

Re: MIME error with pgnus 0.96

[Mark Buda]

>>>>> "Mark" == Mark Buda <hermit@clark.net> writes:

    Mark> Both quoted-printable and base64 encodings appear to be
    Mark> broken in 0.96.

Furthermore, in 0.95 under Xemacs 20.4 on Debian GNU/Linux 2.1, zip
archives (for example) sent as attachments are corrupted. The cause is
that newlines are replaced with carriage returns, or maybe it was the
other way around. Apparently the raw-text coding system set by
nnheader-file-coding-system was resulting in Xemacs thinking it should
use the no-conversion-mac coding system.

(setq nnheader-file-coding-system 'binary)

appears to fix the problem, but it almost certainly isn't the Right
Solution (tm).
-- 
I get my monkeys for nothing and my chimps for free.
http://www.clark.net/pub/hermit/

Fix for broken QP-encoding bug

[Shenghuo ZHU]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]


I hope this patch will fix broken QP-encoding bug.


In <xyf7lm7oi6u.fsf@win219.nas.nasa.gov> 
>>>>> "Thomas" == Thomas H Olsen <tolsen@nas.nasa.gov> writes:

    Thomas>         I tried to send a picture yesterday using pgnus
    Thomas> 0.96.  When I try to read the message with pine or
    Thomas> Netscape I get an error message like "Formatting error:
    Thomas> Non-hexadecimal character in QP encoding."  This bug was
    Thomas> not present in version 0.95.

I am not sure whether Netscape accept QP encoded image. Please test
it.

In <87vh9qrqyo.fsf@pazuzu.eudaemonia.org> 
>>>>> "Mark" == Mark Buda <hermit@clark.net> writes:

    Mark> Both quoted-printable and base64 encodings appear to be
    Mark> broken in 0.96.

Does base64 encodings appear to broken in 0.96? I can not reproduce
such broken message.

Shenghuo


1999-09-08  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* mm-encode.el (mm-encode-content-transfer-encoding): Fold
	quoted-printable-encode-region.

	* qp.el (quoted-printable-encode-region): Assume charset
	encoded. Fold every line in the region.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 96-zsh3.diff --]
[-- Type: text/x-patch, Size: 1423 bytes --]

--- ../../pgnus-sent/lisp/mm-encode.el	Thu Sep  2 15:23:36 1999
+++ mm-encode.el	Wed Sep  8 17:49:45 1999
@@ -63,7 +63,7 @@
 (defun mm-encode-content-transfer-encoding (encoding &optional type)
   (cond
    ((eq encoding 'quoted-printable)
-    (quoted-printable-encode-region (point-min) (point-max)))
+    (quoted-printable-encode-region (point-min) (point-max) t))
    ((eq encoding 'base64)
     (when (equal type "text/plain")
       (goto-char (point-min))
--- ../../pgnus-sent/lisp/qp.el	Thu Sep  2 15:23:37 1999
+++ qp.el	Wed Sep  8 17:07:36 1999
@@ -73,7 +73,7 @@
   (save-excursion
     (save-restriction
       (narrow-to-region from to)
-      (mm-encode-body)
+;;      (mm-encode-body)
       ;; Encode all the non-ascii and control characters.
       (goto-char (point-min))
       (while (and (skip-chars-forward
@@ -95,13 +95,15 @@
       (when fold
 	;; Fold long lines.
 	(goto-char (point-min))
-	(end-of-line)
-	(while (> (current-column) 72)
-	  (beginning-of-line)
-	  (forward-char 72)
-	  (search-backward "=" (- (point) 2) t)
-	  (insert "=\n")
-	  (end-of-line))))))
+	(while (not (eobp))
+	  (end-of-line)
+	  (while (> (current-column) 72)
+	    (beginning-of-line)
+	    (forward-char 72)
+	    (search-backward "=" (- (point) 2) t)
+	    (insert "=\n")
+	    (end-of-line))
+	  (forward-line))))))
 
 (defun quoted-printable-encode-string (string)
  "QP-encode STRING and return the results."