Gnus development mailing list
 help / color / mirror / Atom feed
From: Roland Winkler <winkler@gnu.org>
To: Sam Steingold <sds@gnu.org>
Cc: bbdb-user@nongnu.org, ding@gnus.org
Subject: Re: bug#54423: 29.0.50; gnus-fetch-original-field returns nil in digest
Date: Tue, 22 Mar 2022 12:27:22 -0500	[thread overview]
Message-ID: <87tubp7v9h.fsf@gnu.org> (raw)
In-Reply-To: <lzbkxxj4nq.fsf@3c22fb11fdab.ant.amazon.com> (Sam Steingold's message of "Tue, 22 Mar 2022 13:08:57 -0400")

On Tue, Mar 22 2022, Sam Steingold wrote:
> when the current group is _not_ `nndoc`, there is no `quit-config'
> and `with-current-buffer' will signal an "nil is not a buffer" error.

Do you refer to the possibility that the first `or' clause

  (or (gnus-fetch-original-field header)

fails because a header is absent in an otherwise ordinary message?
Then looking for parent-summary-buffer won't help either.

> +         (let ((parent-summary-buffer
> +                (cadr (assq 'quit-config
> +                            (gnus-info-params
> +                             (gnus-get-info gnus-newsgroup-name))))))
> +           (and parent-summary-buffer
> +                (with-current-buffer parent-summary-buffer
> +                  (gnus-fetch-original-field header))))))

Thanks, I find this much cleaner!


  parent reply	other threads:[~2022-03-22 19:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <lzr172szfa.fsf@3c22fb11fdab.ant.amazon.com>
     [not found] ` <87ee30vo80.fsf@gnus.org>
     [not found]   ` <87cziku6kv.fsf@gnus.org>
     [not found]     ` <lzmthotxdi.fsf@3c22fb11fdab.ant.amazon.com>
     [not found]       ` <87k0cssiaw.fsf@gnus.org>
2022-03-22  0:04         ` Sam Steingold
2022-03-22 16:49           ` Roland Winkler
     [not found]             ` <lzbkxxj4nq.fsf@3c22fb11fdab.ant.amazon.com>
2022-03-22 17:27               ` Roland Winkler [this message]
2022-03-22 18:06                 ` Sam Steingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tubp7v9h.fsf@gnu.org \
    --to=winkler@gnu.org \
    --cc=bbdb-user@nongnu.org \
    --cc=ding@gnus.org \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).