face problem when lowering the score

face problem when lowering the score

[Uwe Brauer]

Hi


When I raise the score of a particular message by say

C-u 1000 I arp


The corresponding message ends up in my Score file and the associated face is 
gnus-summary-high-ticked

However when I lower a score


C-u 1000 L arp

Then the corresponding face is 
gnus-summary-low-read  

Instead of gnus-summary-low-ticked

And that looks like a bug to me.

Anybody can confirm that?

Uwe Brauer

--
I strongly condem Putin's war of agression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.

Re: face problem when lowering the score

[Andreas Schwab]

On Mär 08 2022, Uwe Brauer wrote:

> When I raise the score of a particular message by say
>
> C-u 1000 I arp
>
>
> The corresponding message ends up in my Score file and the associated face is 
> gnus-summary-high-ticked
>
> However when I lower a score
>
>
> C-u 1000 L arp
>
> Then the corresponding face is 
> gnus-summary-low-read  
>
> Instead of gnus-summary-low-ticked

The *-ticked faces are only used for articles that are ticked or
dormant.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: face problem when lowering the score

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

>>> "AS" == Andreas Schwab <schwab@linux-m68k.org> writes:

> On Mär 08 2022, Uwe Brauer wrote:

[Snip]...

>> Then the corresponding face is 
>> gnus-summary-low-read  
>> 
>> Instead of gnus-summary-low-ticked

> The *-ticked faces are only used for articles that are ticked or
> dormant.

Well not in my case, on I don't understand it, but back to the point.

What should be the face of low score messages
and what the face for high score messages. 

I understand that this is an important feature



--
I strongly condem Putin's war of agression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
https://how-to-help-ukraine-now.super.site/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: face problem when lowering the score

[Andreas Schwab]

On Mär 08 2022, Uwe Brauer wrote:

> What should be the face of low score messages
> and what the face for high score messages. 

Whatever gnus-summary-highlight is telling.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: face problem when lowering the score

[Eric S Fraga]

On Tuesday,  8 Mar 2022 at 15:10, Andreas Schwab wrote:
> Whatever gnus-summary-highlight is telling.

I think the point is that Uwe is suprised (as would I be) because gnus
is using the -ticked face instead of -unread or -read.  For low scoring
articles, he is having the correct face applied.

I don't see this in my groups: high scored articles are shown with
gnus-summary-high-{unread,read,ancient} as appropriate.

Uwe, are you sure the high score article has not been "ticked"?
-- 
Eric S Fraga with org 9.5.2 in Emacs 29.0.50 on Debian 11.2

Re: face problem when lowering the score

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

>>> "ESF" == Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> On Tuesday,  8 Mar 2022 at 15:10, Andreas Schwab wrote:
>> Whatever gnus-summary-highlight is telling.

> I think the point is that Uwe is suprised (as would I be) because gnus
> is using the -ticked face instead of -unread or -read.  For low scoring
> articles, he is having the correct face applied.

> I don't see this in my groups: high scored articles are shown with
> gnus-summary-high-{unread,read,ancient} as appropriate.

> Uwe, are you sure the high score article has not been "ticked"?

I just realized that I have to carefully check the setting of 
gnus-summary-highlight 

I think it is a bit screwed, uff ☹️
> --
I strongly condem Putin's war of agression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
https://how-to-help-ukraine-now.super.site/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: face problem when lowering the score

[Eric S Fraga]

On Tuesday,  8 Mar 2022 at 16:55, Uwe Brauer wrote:
> I just realized that I have to carefully check the setting of 
> gnus-summary-highlight 

yes, that would affect the display!  Hope you sort it out.

-- 
Eric S Fraga with org 9.5.2 in Emacs 29.0.50 on Debian 11.2

Re: face problem when lowering the score

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 2761 bytes --]

>>> "ESF" == Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> On Tuesday,  8 Mar 2022 at 16:55, Uwe Brauer wrote:
>> I just realized that I have to carefully check the setting of 
>> gnus-summary-highlight 

> yes, that would affect the display!  Hope you sort it out.
Here is what I did. I deleted all my gnus-summary-highlight setting in
my custom file and restarted emacs and gnus, now the default
gnus-summary-highlight setting is confusing to say the least and frankly
I am more on Eric's side and thinking that the setting needs to be
extended for example for the scoring.

Here is the setting what confuses me is the true setting for scroe
default-high and low

So there is stuff like 

(and
   (> score default-high)
   (or
    (eq mark gnus-dormant-mark)
    (eq mark gnus-ticked-mark)))
  . gnus-summary-high-ticked)

But also 

 ((and
   (> score default-high)
   (eq mark gnus-ancient-mark))
  . gnus-summary-high-ancient)
 ((and
   (< score default-low)
   (eq mark gnus-ancient-mark))
  . gnus-summary-low-ancient)

So what is the reason, what is relevant here


If somebody can enlighten I would be grateful
(((eq mark gnus-canceled-mark)
  . gnus-summary-cancelled) ; not relevant
 ((and uncached
       (> score default-high))
  . gnus-summary-high-undownloaded) 
 ((and uncached
       (< score default-low))
  . gnus-summary-low-undownloaded)
 (uncached . gnus-summary-normal-undownloaded)
 ((and
   (> score default-high)
   (or
    (eq mark gnus-dormant-mark)
    (eq mark gnus-ticked-mark)))
  . gnus-summary-high-ticked)
 ((and
   (< score default-low)
   (or
    (eq mark gnus-dormant-mark)
    (eq mark gnus-ticked-mark)))
  . gnus-summary-low-ticked)
 ((or
   (eq mark gnus-dormant-mark)
   (eq mark gnus-ticked-mark))
  . gnus-summary-normal-ticked)
 ((and
   (> score default-high)
   (eq mark gnus-ancient-mark))
  . gnus-summary-high-ancient)
 ((and
   (< score default-low)
   (eq mark gnus-ancient-mark))
  . gnus-summary-low-ancient)
 ((eq mark gnus-ancient-mark)
  . gnus-summary-normal-ancient)
 ((and
   (> score default-high)
   (eq mark gnus-unread-mark))
  . gnus-summary-high-unread)
 ((and
   (< score default-low)
   (eq mark gnus-unread-mark))
  . gnus-summary-low-unread)
 ((eq mark gnus-unread-mark)
  . gnus-summary-normal-unread)
 ((> score default-high)
  . gnus-summary-high-read)
 ((< score default-low)
  . gnus-summary-low-read)
 (t . gnus-summary-normal-read))



> --
I strongly condem Putin's war of agression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
https://how-to-help-ukraine-now.super.site/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

[SOLVED (more or less)] (was: face problem when lowering the score)

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]



> Here is what I did. I deleted all my gnus-summary-highlight setting in
> my custom file and restarted emacs and gnus, now the default
> gnus-summary-highlight setting is confusing to say the least and frankly
> I am more on Eric's side and thinking that the setting needs to be
> extended for example for the scoring.

> Here is the setting what confuses me is the true setting for scroe
> default-high and low

These are the relevant lines

>  ((> score default-high)
>   . gnus-summary-high-read)
>  ((< score default-low)
>   . gnus-summary-low-read)
>  (t . gnus-summary-normal-read))

And I think this really emphasise  the point Eric made: the best
solution  would be to have a separate face for the scores.



gnus-summary-low-ancient or gnus-summary-high-ancient might be one alternative



--
I strongly condem Putin's war of agression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
https://how-to-help-ukraine-now.super.site/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]