Re: [RFC] Gnus generalized search, part II

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Andrew Cohen <cohen@bu.edu> writes:
>
>> I found a few minutes to try the generalized search but couldn't get the
>> file to load :( I suspect just some simple typos, but I haven't had the
>> time to track them down (and they all seem to be in search backends that
>> aren't functional anyway).
>
> Bah, it looks like I pushed a slightly older version from the wrong
> machine. Sorry about that. Those changes look correct, but there might
> be a few more, I'll check in a second.
>
> Actually, I decided it was silly to try to maintain two versions of the
> same code, so I'm just going to rebase the whole thing on top of
> features/gnus-select. I'll try to get that done today, and that will
> include fixing these blunders.

Okay, the scratch/gnus-search branch is now rebased onto
features/gnus-select. I've renamed everything from nnir to gnus-search,
and dropped all the unused code. I'll admit it was enjoyable.

I think you'll have to pull --force to make it work. It was a right mess
getting it rebased, and I hope I haven't screwed anything up.

Things:

1. I moved the -make-search-group functions out of nnselect and into
   gnus-search, since that seems like the right place for them.
2. I renamed the `nnir-mode' function to `nnselect-mode' and moved it
   into nnselect.el. That function should apply to all nnselect groups,
   not just search groups. But I don't know the right place to trigger
   it, and currently it isn't called at all. I wish groups had a
   parameter holding a group-specific bit of code to run on summary
   buffer creation.
3. I poked at nnselect here and there, to get it basically working with
   gnus-search. It shouldn't be anything too invasive.

Next:

1. I'd like to address the threading issue, and write
   `gnus-search-refer-thread'. I haven't really looked at this issue
   yet.
2. I'm curious when `nnselect-request-article' is ever called with a
   message-id string, rather than an article number. As I said, I'll
   re-instate the shortcut for message-id searching in the imap engine,
   but does this ever actually happen?
3. Figure out a proper way to run the nnselect-mode function in nnselect
   summary buffers. I tried making that a real major mode, derived from
   Gnus' summary-mode, but that made a mess of things and I backed off
   from it.

At some point, I guess when the threading issue is resolved, I'm hoping
you'll merge this scratch branch into features/gnus-select. Then
development/testing can continue in that branch (we can let it mellow
for a bit while docs are written), and then eventually that gets merged
into master.

Eric