From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/87501 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.gnus.general Subject: Re: [RFC] Gnus generalized search, part II Date: Wed, 26 Apr 2017 15:31:37 -0700 Message-ID: <87tw5aztpy.fsf@ericabrahamsen.net> References: <87zif930mt.fsf@ericabrahamsen.net> <87shkx5z17.fsf@ericabrahamsen.net> <87zif3fupv.fsf@hanan> <87h91b3z2m.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493245962 17973 195.159.176.226 (26 Apr 2017 22:32:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Apr 2017 22:32:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: ding@gnus.org Original-X-From: ding-owner+m35716@lists.math.uh.edu Thu Apr 27 00:32:37 2017 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from mxfilter-048035.atla03.us.yomura.com ([107.189.48.35]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3VUC-0004UX-2C for ding-account@gmane.org; Thu, 27 Apr 2017 00:32:36 +0200 X-Yomura-MXScrub: 1.0 Original-Received: from lists1.math.uh.edu (unknown [129.7.128.208]) by mxfilter-048035.atla03.us.yomura.com (Halon) with ESMTPS id 41419af5-2ad0-11e7-b087-b499baabecb2; Wed, 26 Apr 2017 22:32:40 +0000 (UTC) Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.87) (envelope-from ) id 1d3VTU-0004LW-J2; Wed, 26 Apr 2017 17:31:52 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1d3VTS-0004Kz-BM for ding@lists.math.uh.edu; Wed, 26 Apr 2017 17:31:50 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.87) (envelope-from ) id 1d3VTR-0001YO-92 for ding@lists.math.uh.edu; Wed, 26 Apr 2017 17:31:50 -0500 Original-Received: from [195.159.176.226] (helo=blaine.gmane.org) by quimby.gnus.org with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1d3VTP-0000OM-SL for ding@gnus.org; Thu, 27 Apr 2017 00:31:47 +0200 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d3VTI-0003G8-Hf for ding@gnus.org; Thu, 27 Apr 2017 00:31:40 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 59 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:IhwbqHP0s8IOmleBTUW+lFtCiFs= List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:87501 Archived-At: Eric Abrahamsen writes: > Andrew Cohen writes: > >> I found a few minutes to try the generalized search but couldn't get the >> file to load :( I suspect just some simple typos, but I haven't had the >> time to track them down (and they all seem to be in search backends that >> aren't functional anyway). > > Bah, it looks like I pushed a slightly older version from the wrong > machine. Sorry about that. Those changes look correct, but there might > be a few more, I'll check in a second. > > Actually, I decided it was silly to try to maintain two versions of the > same code, so I'm just going to rebase the whole thing on top of > features/gnus-select. I'll try to get that done today, and that will > include fixing these blunders. Okay, the scratch/gnus-search branch is now rebased onto features/gnus-select. I've renamed everything from nnir to gnus-search, and dropped all the unused code. I'll admit it was enjoyable. I think you'll have to pull --force to make it work. It was a right mess getting it rebased, and I hope I haven't screwed anything up. Things: 1. I moved the -make-search-group functions out of nnselect and into gnus-search, since that seems like the right place for them. 2. I renamed the `nnir-mode' function to `nnselect-mode' and moved it into nnselect.el. That function should apply to all nnselect groups, not just search groups. But I don't know the right place to trigger it, and currently it isn't called at all. I wish groups had a parameter holding a group-specific bit of code to run on summary buffer creation. 3. I poked at nnselect here and there, to get it basically working with gnus-search. It shouldn't be anything too invasive. Next: 1. I'd like to address the threading issue, and write `gnus-search-refer-thread'. I haven't really looked at this issue yet. 2. I'm curious when `nnselect-request-article' is ever called with a message-id string, rather than an article number. As I said, I'll re-instate the shortcut for message-id searching in the imap engine, but does this ever actually happen? 3. Figure out a proper way to run the nnselect-mode function in nnselect summary buffers. I tried making that a real major mode, derived from Gnus' summary-mode, but that made a mess of things and I backed off from it. At some point, I guess when the threading issue is resolved, I'm hoping you'll merge this scratch branch into features/gnus-select. Then development/testing can continue in that branch (we can let it mellow for a bit while docs are written), and then eventually that gets merged into master. Eric