commit 1d2c4fbb9bdc1078d1727b27139e4df5ba7cb2cb

commit 1d2c4fbb9bdc1078d1727b27139e4df5ba7cb2cb

[Tassilo Horn]

Hi Thierry,

it seems your latest commit broke burying the message buffer after
sending a message for me.  I use

  (setq message-kill-buffer-on-exit t)

and now I get this error after sending messages:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  message-bury()
  message-send-and-exit(nil)
  call-interactively(message-send-and-exit nil nil)
  command-execute(message-send-and-exit)
--8<---------------cut here---------------end--------------->8---

The problem is that `with-current-buffer' doesn't work if the given
buffer is nil?

This simplified definition of `message-bury' works for me:

--8<---------------cut here---------------start------------->8---
(defun message-bury (&optional buffer)
  "Bury this mail BUFFER."
  (when message-return-action
    (apply (car message-return-action) (cdr message-return-action)))
  (bury-buffer buffer))
--8<---------------cut here---------------end--------------->8---

However, I don't use `message-return-action', so I can't tell if
reversing the order (first `message-return-action', then bury the
buffer, instead of the other way round) has any negative effects.

Bye,
Tassilo

Re: commit 1d2c4fbb9bdc1078d1727b27139e4df5ba7cb2cb

[Andreas Schwab]

Tassilo Horn <tsdh@gnu.org> writes:

> This simplified definition of `message-bury' works for me:

The bug was already fixed by 0ab87d9, so 1d2c4fb should just be
reverted.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: commit 1d2c4fbb9bdc1078d1727b27139e4df5ba7cb2cb

[Tassilo Horn]

Andreas Schwab <schwab@linux-m68k.org> writes:

Hi Andreas,

>> This simplified definition of `message-bury' works for me:
>
> The bug was already fixed by 0ab87d9, so 1d2c4fb should just be
> reverted.

0ab87d9 is a commit in emacs that will be synced to Gnus' git anytime
soon?

Anyway, I've reverted 1d2c4fb in Gnus' git just now since that caused
serious problems like data loss, e.g., the error prevents things like
archiving of sent messages.

Bye,
Tassilo

Re: commit 1d2c4fbb9bdc1078d1727b27139e4df5ba7cb2cb

[Andreas Schwab]

http://git.gnus.org/cgit/gnus.git/commit/?id=0ab87d9

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."