From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/78151 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: message-yank-original issue Date: Tue, 29 Mar 2011 09:55:06 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87tyemgenp.fsf@lifelogs.com> References: <871v2ako4c.fsf@fencepost.gnu.org> <87lj0ha52s.fsf@lifelogs.com> <87y64g6833.fsf@lifelogs.com> <87ei5tzneu.fsf@turtle.gmx.de> <877hbjkquz.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301410546 18065 80.91.229.12 (29 Mar 2011 14:55:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 Mar 2011 14:55:46 +0000 (UTC) Cc: , David Kastrup , Katsumi Yamaoka To: Stefan Monnier Original-X-From: ding-owner+M26462@lists.math.uh.edu Tue Mar 29 16:55:42 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4aKb-0000f0-Bq for ding-account@gmane.org; Tue, 29 Mar 2011 16:55:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Q4aKF-0002BQ-1v; Tue, 29 Mar 2011 09:55:19 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Q4aKD-0002BD-JF for ding@lists.math.uh.edu; Tue, 29 Mar 2011 09:55:17 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1Q4aKB-0000p0-BO for ding@lists.math.uh.edu; Tue, 29 Mar 2011 09:55:17 -0500 Original-Received: from chirelay1o.jumptrading.com ([38.98.147.153] helo=chirelay1.jumptrading.com) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1Q4aKA-0000mh-FP for ding@gnus.org; Tue, 29 Mar 2011 16:55:14 +0200 Original-Received: from chirelay1.jumptrading.com (unknown [127.0.0.1]) by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id 5E62932004D for ; Tue, 29 Mar 2011 09:55:08 -0500 (CDT) X-AuditID: 26629395-9fde7bb0000019cd-e4-4d91f2ccd797 Original-Received: from chiexchange02.w2k.jumptrading.com (unknown [38.98.147.140]) by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id 1D8022DC005 for ; Tue, 29 Mar 2011 09:55:08 -0500 (CDT) Original-Received: from internalsmtp.w2k.jumptrading.com (10.2.4.29) by chiexchange02.w2k.jumptrading.com (10.2.4.71) with Microsoft SMTP Server id 8.1.291.1; Tue, 29 Mar 2011 09:55:07 -0500 Original-Received: from tzlatanov-ubuntu-desktop.jumptrading.com ([10.2.14.81]) by internalsmtp.w2k.jumptrading.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 29 Mar 2011 09:55:07 -0500 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" In-Reply-To: (Stefan Monnier's message of "Mon, 28 Mar 2011 16:41:38 -0400") User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux) X-OriginalArrivalTime: 29 Mar 2011 14:55:07.0777 (UTC) FILETIME=[4B796710:01CBEE21] X-Brightmail-Tracker: AAAAAA== X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:78151 Archived-At: On Mon, 28 Mar 2011 16:41:38 -0400 Stefan Monnier wrote: SM> How 'bout the patch below, which makes the bulk of the eval'd code SM> visible to the byte-compiler, as god intended it to be. Looks good, committed to Gnus. On Tue, 29 Mar 2011 07:37:08 +0200 Antoine Levitt wrote: AL> I used eval and mentioned the code might use some improvment, but AL> nobody touched it. What's the preferred way to do this? The way Stefan did it is usually OK. You could have also maybe done it with macros. It's kind of an ugly construct but that's not your fault :) Thanks Ted