Re: message-yank-original issue

[Sven Joachim <svenjoac@gmx.de>]

On 2011-03-28 21:05 +0200, Ted Zlatanov wrote:

> On Sat, 26 Mar 2011 20:34:17 +0100 Sven Joachim <svenjoac@gmx.de> wrote: 
>
> SJ> On 2011-03-15 10:34 +0100, Ted Zlatanov wrote:
>>> On Mon, 14 Mar 2011 14:13:15 -0500 Ted Zlatanov <tzz@lifelogs.com> wrote: 
>>> 
> TZ> On Mon, 14 Mar 2011 11:11:47 +0100 David Kastrup <dak@gnu.org> wrote: 
> DK> It has now been about two weeks that message-yank-original has stopped
> DK> being functional for installations that don't have cl loaded permanently
> DK> (namely standard Emacs installations).
>>> 
> TZ> I posted a fix on the bug list, can you reply there if it worked?
>>> 
>>> Since I didn't hear back I've pushed this patch.
>
> SJ> Alas, this patch was reverted later that day in commit 5edabb7b1 (Author
> SJ> Stefan and committed by Katsumi, apparently in merging changes between
> SJ> Gnus and Emacs), so as of now message-yank-original still requires cl to
> SJ> be loaded at runtime. :-(  Could you please restore the message.el
> SJ> version from commit 698d90df ?
>
> I'm not sure what's going on with message.el.  It clearly says 
>
> (eval-when-compile
>   (require 'cl))
>
> so it should not be erroring out.

IIUC, the problem is that the bulk of message-yank-original, including
the (case …) statement, is inside a backquoted list, so the
byte-compiler will leave it alone.

> Stefan wanted to go back to using
> `case' instead of `cond' so I'll defer to him.

Cheers,
       Sven