Gnus development mailing list
 help / color / mirror / Atom feed
From: Wang Diancheng <dcwang@kingbase.com.cn>
To: ding@gnus.org
Subject: [Wang Diancheng] patch for Gnus, fix goto article failed when nnml-use-compressed-files is t
Date: Mon, 27 Dec 2010 22:02:56 +0800	[thread overview]
Message-ID: <87tyhzjotr.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]


Hi,

Could someone review and process my patch, this is my first patch for
Gnus.  thank you very much.

I am really appreciated your response.


[-- Attachment #2: Type: message/rfc822, Size: 1725 bytes --]

[-- Attachment #2.1.1.1: Type: text/plain, Size: 389 bytes --]


Hi, 

Gnus backend is nnml with "(setq nnml-use-compressed-files t)"

when calling function:

(gnus-summary-goto-article
         "<201012201809341712361@163.com>")

here, "<201012201809341712361@163.com>" is a message-id of a exist
article, which is compressed by nnml.

will print error message:

Couldn't fetch article <201012201809341712361@163.com>


the attached patch for fix it.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.1.2: fix-goto-article.patch --]
[-- Type: text/x-diff, Size: 588 bytes --]

--- nnml.el~	2010-12-21 17:33:07.000000000 +0800
+++ nnml.el	2010-12-21 17:33:09.000000000 +0800
@@ -235,7 +235,11 @@
 			  (nnheader-article-to-file-alist
 			   (setq gpath (nnml-group-pathname (car group-num)
 							    nil server))))))
-	  (setq path (concat gpath (int-to-string (cdr group-num)))))
+	  (nnml-update-file-alist)
+	  (setq path (concat gpath  (if nnml-use-compressed-files
+					(cdr (assq (cdr group-num)
+						   nnml-article-file-alist))
+				      (number-to-string (cdr group-num))))))
       (setq path (nnml-article-to-file id)))
     (cond
      ((not path)

[-- Attachment #2.1.2: Type: text/plain, Size: 35 bytes --]



-- 
Best Regards,
Wang Diancheng

             reply	other threads:[~2010-12-27 14:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-27 14:02 Wang Diancheng [this message]
2011-01-19 22:07 ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyhzjotr.fsf@gmail.com \
    --to=dcwang@kingbase.com.cn \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).