From: Reiner Steib <reinersteib+gmane@imap.cc>
To: James Cloos <cloos@jhcloos.com>
Cc: ding@gnus.org
Subject: Re: Unable to use gnus on a nox build
Date: Fri, 29 Oct 2010 21:10:13 +0200 [thread overview]
Message-ID: <87tyk4izmy.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <sa3bp6dcob7.fsf@cigue.easter-eggs.fr> (Julien Danjou's message of "Fri, 29 Oct 2010 11:59:08 +0200")
On Fri, Oct 29 2010, Julien Danjou wrote:
> On Thu, Oct 28 2010, James Cloos wrote:
>
>> But that should not be required on a -nox emacs build. It is just silly
>> that everyone who wants to use gnus on a gui-less build should have to
>> add that sexp to their .emacs.
>
> I've pushed a fix.
,----
| --- a/lisp/gnus-group.el
| +++ b/lisp/gnus-group.el
| @@ -1090,8 +1090,7 @@ When FORCE, rebuild the tool bar."
| (when (and (not (featurep 'xemacs))
| (boundp 'tool-bar-mode)
| tool-bar-mode
| - ;; The Gnus 5.10.6 code checked (default-value 'tool-bar-mode).
| - ;; Why? --rsteib
| + (display-graphic-p)
| (or (not gnus-group-tool-bar-map) force))
| (let* ((load-path
| (gmm-image-load-path-for-library "gnus"
`----
Hm, I think with this check, the failure will be deferred to
`gnus-summary-make-tool-bar' or `message-make-tool-bar' instead.
I still think it is a bug in Emacs 24, because tool-bar-mode should
not be non-nil in this case.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next prev parent reply other threads:[~2010-10-29 19:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 8:29 James Cloos
2010-10-27 7:01 ` Reiner Steib
2010-10-28 17:12 ` James Cloos
2010-10-29 6:26 ` Reiner Steib
2010-10-29 9:59 ` Julien Danjou
2010-10-29 19:10 ` Reiner Steib [this message]
2010-10-29 19:20 ` James Cloos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyk4izmy.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=cloos@jhcloos.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).