From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/72136 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Introduce gnus-completing-read Date: Tue, 28 Sep 2010 15:07:14 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87tyl91vkd.fsf@lifelogs.com> References: <1285688153-19680-1-git-send-email-julien@danjou.info> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285704463 17892 80.91.229.12 (28 Sep 2010 20:07:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 28 Sep 2010 20:07:43 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M20509@lists.math.uh.edu Tue Sep 28 22:07:42 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P0gSk-0007cx-1O for ding-account@gmane.org; Tue, 28 Sep 2010 22:07:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1P0gSV-0005Cw-6o; Tue, 28 Sep 2010 15:07:27 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1P0gST-0005Cm-H9 for ding@lists.math.uh.edu; Tue, 28 Sep 2010 15:07:25 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1P0gSS-0005Ir-2z for ding@lists.math.uh.edu; Tue, 28 Sep 2010 15:07:25 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1P0gSR-0003uU-00 for ; Tue, 28 Sep 2010 22:07:23 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1P0gSR-0007Xm-4V for ding@gnus.org; Tue, 28 Sep 2010 22:07:23 +0200 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Sep 2010 22:07:23 +0200 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Sep 2010 22:07:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 33 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:p5FGgnF0H+/UQRhtk7MTWAM6/lU= X-Spam-Score: 0.8 (/) X-Spam-Report: SpamAssassin (3.3.1 2010-03-16) analysis follows Bayesian score: 0.0000 Ham tokens: 0.000-852--1576h-0s--0d--H*M:fsf, 0.000-746--1381h-0s--0d--H*u:Emacs, 0.000-735--1360h-0s--0d--H*u:Gnus, 0.000-710--1314h-0s--0d--H*u:linux, 0.000-710--1314h-0s--0d--H*UA:linux Spam tokens: 0.862-166--1189h-22075s--0d--HX-Spam-Relays-External:quimby.gnus.org, 0.862-166--1189h-22075s--0d--H*RU:quimby.gnus.org, 0.851-47--1255h-21209s--0d--HTo:D*gnus.org Autolearn status: no 1.2 RCVD_NUMERIC_HELO Received: contains an IP address used for HELO 1.5 URIBL_RHS_DOB Contains an URI of a new domain (Day Old Bread) [URIs: danjou.info] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:72136 Archived-At: On Tue, 28 Sep 2010 17:35:53 +0200 Julien Danjou wrote: JD> As promised yesterday, here's my patch! JD> It adds `gnus-completion-styles' which set `completion-styles' when calling JD> `completing-read'. JD> It adds `gnus-use-ido' which makes `gnus-completing-read' use JD> `ido-completing-read' rather than `completing-read' JD> It replaces (almost) all occurences of `completing-read' with JD> `gnus-completing-read', so it works with ido too. Thanks for the patch, I think it's very useful. Are there any specific completion styles and behavior (e.g. `gnus-use-ido') you'd recommend? I don't use ido so I don't know how it's useful. Some documentation would be helpful, even if minimal, for what your patch does in the manual. I think it should go in the Gnus news file, too, because it's a pretty major change across Gnus. The default gnus-completion-styles appends 'substring to whatever else the user has if it's not present (the docstring should reflect that). Should we add 'partial-completion as well? Or 'initials? There seem to be many places where gnus-completing-read makes sense with a different completion style from the normal one. For example the "lower score" command now asks for a series of choices one by one, which IMO could be better done with completing-read choices. In that case, 'initials would work well to represent `L s s p' (lower subject, substring, permanent) as the completion choice "lower-subject-substring-permanent" that the user can input as `lssp'. Ted